)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b35deee5cd4ba7af1c0e8a3fcfe4348c78782536","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Conflicts:"},{"line_number":24,"context_line":"      nova/tests/unit/network/test_neutronv2.py"},{"line_number":25,"context_line":"Conflicts due to mox removal patches merged in train. I basically needed"},{"line_number":26,"context_line":"to redo the change in test_neutronv2.py as the merge conflict was huge."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Icc631cf2e81a5c78cb7fb1d0b625d19bd8f5a274"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_6029609a","line":25,"updated":"2019-11-18 17:25:11.000000000","message":"Yup, another reason why I dislike the mox removal effort. It doesn\u0027t buy us anything but it costs us work.","commit_id":"d9940e8e3bbf97aafb4853fd1dabdccaec35c0d0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b0715a9493391f19ac08478ad4b7f6c77e68792c","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Conflicts:"},{"line_number":24,"context_line":"      nova/tests/unit/network/test_neutronv2.py"},{"line_number":25,"context_line":"Conflicts due to mox removal patches merged in train. I basically needed"},{"line_number":26,"context_line":"to redo the change in test_neutronv2.py as the merge conflict was huge."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Icc631cf2e81a5c78cb7fb1d0b625d19bd8f5a274"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_521e6f70","line":25,"in_reply_to":"3fa7e38b_6029609a","updated":"2019-11-19 08:16:22.000000000","message":"All the wide spread refactor efforts has the same effect on stable backports. If I have to compare what I hated most a) re-doing the test change b) using mox to re-do the test changes, then I definitely say b) was a lot worst experience than a)","commit_id":"d9940e8e3bbf97aafb4853fd1dabdccaec35c0d0"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"f9213ae828678ac9a7bb4460df7af4a66681dc9e","unresolved":false,"context_lines":[{"line_number":6764,"context_line":"        self.assertEqual(len(result), 2)"},{"line_number":6765,"context_line":"        self.assertEqual(result[0], {\"id\": uuids.created})"},{"line_number":6766,"context_line":"        self.assertEqual(result[1], {\"id\": uuids.preexist})"},{"line_number":6767,"context_line":""},{"line_number":6768,"context_line":"    def test_populate_mac_address_skip_if_none(self):"},{"line_number":6769,"context_line":"        api \u003d neutronapi.API()"},{"line_number":6770,"context_line":"        port_req_body \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_779ecfb8","line":6767,"updated":"2019-11-21 16:35:09.000000000","message":"In the original cherry-picked patch here we had an extra assert:\n\n        mock_validate_ports.assert_called_once_with(\n            self.context, self.instance, \"admin\", None, attach\u003dFalse)\n\nIs that intentionally left out here?","commit_id":"d9940e8e3bbf97aafb4853fd1dabdccaec35c0d0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a70c10be22fbbb6e453ad771f4d88ca063fce65c","unresolved":false,"context_lines":[{"line_number":6764,"context_line":"        self.assertEqual(len(result), 2)"},{"line_number":6765,"context_line":"        self.assertEqual(result[0], {\"id\": uuids.created})"},{"line_number":6766,"context_line":"        self.assertEqual(result[1], {\"id\": uuids.preexist})"},{"line_number":6767,"context_line":""},{"line_number":6768,"context_line":"    def test_populate_mac_address_skip_if_none(self):"},{"line_number":6769,"context_line":"        api \u003d neutronapi.API()"},{"line_number":6770,"context_line":"        port_req_body \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8e76cad7","line":6767,"in_reply_to":"3fa7e38b_779ecfb8","updated":"2019-11-22 12:40:10.000000000","message":"you are right. It was lost in the cherry-pick. Added it back.","commit_id":"d9940e8e3bbf97aafb4853fd1dabdccaec35c0d0"}]}
