)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"5828f4bacf32e1460649b18cd3858fa646211e3d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    MIN_QEMU_FILE_BACKED_VERSION"},{"line_number":26,"context_line":"    MIN_QEMU_FILE_BACKED_DISCARD_VERSION"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"And here[2] discussion for picking future libvirt/QEMU versions for \"V\""},{"line_number":29,"context_line":"release on the list."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[1] https://opendev.org/openstack/nova/commit/489b5f762e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_226a7bb4","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":8},"updated":"2019-11-19 18:16:32.000000000","message":"\"here[2]\" --\u003e \"here[2] is the\"","commit_id":"f4e5305884a38fe59bf3eb9f1f4c037dc5016e23"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d8b3f6e2f2b2ababfa2a624dd3f2d741ab87ba8a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As part of this bump, fix the small fallout:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  - Remove the MIN_LIBVIRT_MDEV_SUPPORT version constant; fix tests."},{"line_number":16,"context_line":"  - Remove the \"GOP\" (Graphic Output Protocol) video model version"},{"line_number":17,"context_line":"    constant from MIN_LIBVIRT_VIDEO_MODEL_VERSIONS; fix tests."},{"line_number":18,"context_line":"  - Fix the fucntional test:"},{"line_number":19,"context_line":"    VGPUReshapeTests.test_create_servers_with_vgpu"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_997b56f2","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":62},"updated":"2019-11-25 19:16:28.000000000","message":"So why did we have to do these here, but not the others?","commit_id":"22c1916b49a774fceebeffa7fc5da1a40573d26c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dacd0c4a5d7a1549a5201115c0bc84d4e94db934","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As part of this bump, fix the small fallout:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  - Remove the MIN_LIBVIRT_MDEV_SUPPORT version constant; fix tests."},{"line_number":16,"context_line":"  - Remove the \"GOP\" (Graphic Output Protocol) video model version"},{"line_number":17,"context_line":"    constant from MIN_LIBVIRT_VIDEO_MODEL_VERSIONS; fix tests."},{"line_number":18,"context_line":"  - Fix the fucntional test:"},{"line_number":19,"context_line":"    VGPUReshapeTests.test_create_servers_with_vgpu"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_a76f045f","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":62},"in_reply_to":"3fa7e38b_997b56f2","updated":"2019-11-26 10:08:56.000000000","message":"I\u0027m guessing it\u0027s because the other tests are specifically setting the minimum libvirt version so they continue to work after it\u0027s bumped, while these two do not and therefore fail","commit_id":"22c1916b49a774fceebeffa7fc5da1a40573d26c"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"3417f69fcf67233b92e0e6f623f3423a4fe3ea6f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As part of this bump, fix the small fallout:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  - Remove the MIN_LIBVIRT_MDEV_SUPPORT version constant; fix tests."},{"line_number":16,"context_line":"  - Remove the \"GOP\" (Graphic Output Protocol) video model version"},{"line_number":17,"context_line":"    constant from MIN_LIBVIRT_VIDEO_MODEL_VERSIONS; fix tests."},{"line_number":18,"context_line":"  - Fix the fucntional test:"},{"line_number":19,"context_line":"    VGPUReshapeTests.test_create_servers_with_vgpu"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_841c46c3","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":62},"in_reply_to":"3fa7e38b_997b56f2","updated":"2019-11-26 13:46:13.000000000","message":"That\u0027s the minimum work required to make the bump work on Git/master.","commit_id":"22c1916b49a774fceebeffa7fc5da1a40573d26c"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"9c1b526db2dae50a151196240087ba6da9d24039","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As part of this bump, fix the small fallout:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  - Remove the MIN_LIBVIRT_MDEV_SUPPORT version constant; fix tests."},{"line_number":16,"context_line":"  - Remove the \"GOP\" (Graphic Output Protocol) video model version"},{"line_number":17,"context_line":"    constant from MIN_LIBVIRT_VIDEO_MODEL_VERSIONS; fix tests."},{"line_number":18,"context_line":"  - Fix the fucntional test:"},{"line_number":19,"context_line":"    VGPUReshapeTests.test_create_servers_with_vgpu"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_f84d99c5","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":62},"in_reply_to":"3fa7e38b_a76f045f","updated":"2019-11-26 13:46:52.000000000","message":"\u003e I\u0027m guessing it\u0027s because the other tests are specifically setting\n \u003e the minimum libvirt version so they continue to work after it\u0027s\n \u003e bumped, while these two do not and therefore fail\n\nStephen\u0027s guess is correct :-)","commit_id":"22c1916b49a774fceebeffa7fc5da1a40573d26c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d8b3f6e2f2b2ababfa2a624dd3f2d741ab87ba8a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  - Remove the MIN_LIBVIRT_MDEV_SUPPORT version constant; fix tests."},{"line_number":16,"context_line":"  - Remove the \"GOP\" (Graphic Output Protocol) video model version"},{"line_number":17,"context_line":"    constant from MIN_LIBVIRT_VIDEO_MODEL_VERSIONS; fix tests."},{"line_number":18,"context_line":"  - Fix the fucntional test:"},{"line_number":19,"context_line":"    VGPUReshapeTests.test_create_servers_with_vgpu"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The following version constants and related tests, which are now no"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_590cfe91","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":22},"updated":"2019-11-25 19:16:28.000000000","message":"functional","commit_id":"22c1916b49a774fceebeffa7fc5da1a40573d26c"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"3417f69fcf67233b92e0e6f623f3423a4fe3ea6f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  - Remove the MIN_LIBVIRT_MDEV_SUPPORT version constant; fix tests."},{"line_number":16,"context_line":"  - Remove the \"GOP\" (Graphic Output Protocol) video model version"},{"line_number":17,"context_line":"    constant from MIN_LIBVIRT_VIDEO_MODEL_VERSIONS; fix tests."},{"line_number":18,"context_line":"  - Fix the fucntional test:"},{"line_number":19,"context_line":"    VGPUReshapeTests.test_create_servers_with_vgpu"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The following version constants and related tests, which are now no"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_a41942d2","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":22},"in_reply_to":"3fa7e38b_590cfe91","updated":"2019-11-26 13:46:13.000000000","message":"Wanted to fix the typo; but it got already merged.","commit_id":"22c1916b49a774fceebeffa7fc5da1a40573d26c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d8b3f6e2f2b2ababfa2a624dd3f2d741ab87ba8a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  - Fix the fucntional test:"},{"line_number":19,"context_line":"    VGPUReshapeTests.test_create_servers_with_vgpu"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The following version constants and related tests, which are now no"},{"line_number":22,"context_line":"longer required, will be removed in separate patches:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    MIN_LIBVIRT_KVM_AARCH64_VERSION"},{"line_number":25,"context_line":"    MIN_LIBVIRT_MULTIATTACH"},{"line_number":26,"context_line":"    MIN_LIBVIRT_FILE_BACKED_VERSION"},{"line_number":27,"context_line":"    MIN_QEMU_FILE_BACKED_VERSION"},{"line_number":28,"context_line":"    MIN_QEMU_FILE_BACKED_DISCARD_VERSION"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"And here[2] is the discussion for picking future libvirt/QEMU versions"},{"line_number":31,"context_line":"for \"V\" release on the list."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_d93eae24","line":28,"range":{"start_line":21,"start_character":0,"end_line":28,"end_character":40},"updated":"2019-11-25 19:16:28.000000000","message":"IMO there\u0027s *no* reason not to squash these in here.","commit_id":"22c1916b49a774fceebeffa7fc5da1a40573d26c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e2e0ce005e56b5eef9efb18b31796003ba7825aa","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  - Fix the fucntional test:"},{"line_number":19,"context_line":"    VGPUReshapeTests.test_create_servers_with_vgpu"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The following version constants and related tests, which are now no"},{"line_number":22,"context_line":"longer required, will be removed in separate patches:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    MIN_LIBVIRT_KVM_AARCH64_VERSION"},{"line_number":25,"context_line":"    MIN_LIBVIRT_MULTIATTACH"},{"line_number":26,"context_line":"    MIN_LIBVIRT_FILE_BACKED_VERSION"},{"line_number":27,"context_line":"    MIN_QEMU_FILE_BACKED_VERSION"},{"line_number":28,"context_line":"    MIN_QEMU_FILE_BACKED_DISCARD_VERSION"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"And here[2] is the discussion for picking future libvirt/QEMU versions"},{"line_number":31,"context_line":"for \"V\" release on the list."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_a77864c1","line":28,"range":{"start_line":21,"start_character":0,"end_line":28,"end_character":40},"in_reply_to":"3fa7e38b_d93eae24","updated":"2019-11-26 10:31:12.000000000","message":"+1, but I want the patch more.","commit_id":"22c1916b49a774fceebeffa7fc5da1a40573d26c"}]}