)]}'
{"nova/conductor/tasks/cross_cell_migrate.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1571ca1d71688c50e77155bf70f18e57125622bb","unresolved":false,"context_lines":[{"line_number":1458,"context_line":"            # cell we update the records in the source cell, otherwise we"},{"line_number":1459,"context_line":"            # update the records in the target cell."},{"line_number":1460,"context_line":"            instance_at_source \u003d self._source_cell_migration is not None"},{"line_number":1461,"context_line":"            migration \u003d self._source_cell_migration \\"},{"line_number":1462,"context_line":"                if self._source_cell_migration else self.migration"},{"line_number":1463,"context_line":"            instance \u003d self._source_cell_instance \\"},{"line_number":1464,"context_line":"                if self._source_cell_instance else self.instance"},{"line_number":1465,"context_line":"            # NOTE(mriedem): This exception log is fairly generic. We could"},{"line_number":1466,"context_line":"            # probably make this more targeted based on what we know of the"},{"line_number":1467,"context_line":"            # state of the system if we want to make it more detailed, e.g."}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_279c7e59","line":1464,"range":{"start_line":1461,"start_character":0,"end_line":1464,"end_character":64},"updated":"2019-12-13 11:46:40.000000000","message":"nit:\n\n  migration \u003d self._source_cell_migration or self.migration\n  instance \u003d self._source_cell_instance or self.instance","commit_id":"87ade6d0f0aff986e5749398cea92949a66ae633"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"135e75c8c5aa1c6e5a5b9d8feab39e025edcd191","unresolved":false,"context_lines":[{"line_number":1458,"context_line":"            # cell we update the records in the source cell, otherwise we"},{"line_number":1459,"context_line":"            # update the records in the target cell."},{"line_number":1460,"context_line":"            instance_at_source \u003d self._source_cell_migration is not None"},{"line_number":1461,"context_line":"            migration \u003d self._source_cell_migration \\"},{"line_number":1462,"context_line":"                if self._source_cell_migration else self.migration"},{"line_number":1463,"context_line":"            instance \u003d self._source_cell_instance \\"},{"line_number":1464,"context_line":"                if self._source_cell_instance else self.instance"},{"line_number":1465,"context_line":"            # NOTE(mriedem): This exception log is fairly generic. We could"},{"line_number":1466,"context_line":"            # probably make this more targeted based on what we know of the"},{"line_number":1467,"context_line":"            # state of the system if we want to make it more detailed, e.g."}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_0ff398a0","line":1464,"range":{"start_line":1461,"start_character":0,"end_line":1464,"end_character":64},"in_reply_to":"3fa7e38b_279c7e59","updated":"2019-12-13 15:08:23.000000000","message":"Done in a FUP.","commit_id":"87ade6d0f0aff986e5749398cea92949a66ae633"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"68a72cad454076bc4eb4e2f53567c8c87665d149","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"                \u0027was deleted from the target cell %s then the target host %s \u0027"},{"line_number":1475,"context_line":"                \u0027was already cleaned up. If the instance is back in the \u0027"},{"line_number":1476,"context_line":"                \u0027source cell then you can try hard-rebooting it to recover.\u0027,"},{"line_number":1477,"context_line":"                (\u0027source\u0027 if instance_at_source else \u0027target\u0027),"},{"line_number":1478,"context_line":"                migration._context.cell_uuid, self.context.cell_uuid,"},{"line_number":1479,"context_line":"                migration.dest_compute, instance\u003dinstance)"},{"line_number":1480,"context_line":"            # If anything failed set the migration status to \u0027error\u0027."},{"line_number":1481,"context_line":"            migration.status \u003d \u0027error\u0027"},{"line_number":1482,"context_line":"            migration.save()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_7f28a835","line":1479,"range":{"start_line":1477,"start_character":16,"end_line":1479,"end_character":38},"updated":"2019-12-16 07:23:23.000000000","message":"nit: format these log parameters, it will be looks easy to read. Maybe define the parameters\u0027 name is not easy. source_or_target??","commit_id":"87ade6d0f0aff986e5749398cea92949a66ae633"}]}