)]}'
{"nova/tests/functional/test_cross_cell_migrate.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0357eb144d7c3f3d8a84cc890e71602abcd2c743","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        # There should be at least two actions, one for create and one for the"},{"line_number":262,"context_line":"        # resize. There will be a third action if the server was stopped. Use"},{"line_number":263,"context_line":"        # assertGreaterEqual in case a test performed some actions on a"},{"line_number":264,"context_line":"        # pre-created server before resizing it, like attaching a volume."},{"line_number":265,"context_line":"        actions \u003d self.api.api_get("},{"line_number":266,"context_line":"            \u0027/servers/%s/os-instance-actions\u0027 % server[\u0027id\u0027]"},{"line_number":267,"context_line":"        ).body[\u0027instanceActions\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_8704527f","line":264,"updated":"2019-12-13 11:53:05.000000000","message":"ta","commit_id":"f1ac153b036ed09055642a0fd510f016ef854e13"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0357eb144d7c3f3d8a84cc890e71602abcd2c743","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            \u0027/servers/%s/os-instance-actions\u0027 % server[\u0027id\u0027]"},{"line_number":267,"context_line":"        ).body[\u0027instanceActions\u0027]"},{"line_number":268,"context_line":"        expected_num_of_actions \u003d 3 if stopped else 2"},{"line_number":269,"context_line":"        self.assertGreaterEqual(len(actions), expected_num_of_actions, actions)"},{"line_number":270,"context_line":"        # Each action should have events (make sure these were copied from"},{"line_number":271,"context_line":"        # the source cell to the target cell)."},{"line_number":272,"context_line":"        for action in actions:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_07cf0257","line":269,"range":{"start_line":269,"start_character":13,"end_line":269,"end_character":31},"updated":"2019-12-13 11:53:05.000000000","message":"I fricking hate this assert because I always get it backwards. note for self: it\u0027s assertGreater(LARGE, SMALL) and presumably the same for assertGreaterEqual","commit_id":"f1ac153b036ed09055642a0fd510f016ef854e13"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"10c98f782e63f2bda6e325a55dba198259439284","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            \u0027/servers/%s/os-instance-actions\u0027 % server[\u0027id\u0027]"},{"line_number":267,"context_line":"        ).body[\u0027instanceActions\u0027]"},{"line_number":268,"context_line":"        expected_num_of_actions \u003d 3 if stopped else 2"},{"line_number":269,"context_line":"        self.assertGreaterEqual(len(actions), expected_num_of_actions, actions)"},{"line_number":270,"context_line":"        # Each action should have events (make sure these were copied from"},{"line_number":271,"context_line":"        # the source cell to the target cell)."},{"line_number":272,"context_line":"        for action in actions:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_2fb0d4fc","line":269,"range":{"start_line":269,"start_character":13,"end_line":269,"end_character":31},"in_reply_to":"3fa7e38b_07cf0257","updated":"2019-12-13 15:01:07.000000000","message":"I have also screwed it up before which led to a gate bug so I\u0027m sure to check the docs before using it each time now.","commit_id":"f1ac153b036ed09055642a0fd510f016ef854e13"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0357eb144d7c3f3d8a84cc890e71602abcd2c743","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        \"\"\"Detaches the volume from the server and waits for the"},{"line_number":412,"context_line":"        \"instance.volume_detach.end\" versioned notification."},{"line_number":413,"context_line":"        \"\"\""},{"line_number":414,"context_line":"        self.api.api_delete("},{"line_number":415,"context_line":"            \u0027/servers/%s/os-volume_attachments/%s\u0027 % (server_id, volume_id))"},{"line_number":416,"context_line":"        fake_notifier.wait_for_versioned_notifications("},{"line_number":417,"context_line":"            \u0027instance.volume_detach.end\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_67fd966b","line":414,"range":{"start_line":414,"start_character":17,"end_line":414,"end_character":27},"updated":"2019-12-13 11:53:05.000000000","message":"delete_server_volume","commit_id":"f1ac153b036ed09055642a0fd510f016ef854e13"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e57cddfccec83f4d363dba29a76b31cc0598830","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        \"\"\"Detaches the volume from the server and waits for the"},{"line_number":412,"context_line":"        \"instance.volume_detach.end\" versioned notification."},{"line_number":413,"context_line":"        \"\"\""},{"line_number":414,"context_line":"        self.api.api_delete("},{"line_number":415,"context_line":"            \u0027/servers/%s/os-volume_attachments/%s\u0027 % (server_id, volume_id))"},{"line_number":416,"context_line":"        fake_notifier.wait_for_versioned_notifications("},{"line_number":417,"context_line":"            \u0027instance.volume_detach.end\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_af536439","line":414,"range":{"start_line":414,"start_character":17,"end_line":414,"end_character":27},"in_reply_to":"3fa7e38b_67fd966b","updated":"2019-12-13 15:25:38.000000000","message":"I\u0027m going to skip this nit because I really don\u0027t like the name of that helper function - it would make more sense if it were called detach_volume, or delete_server_volume_attachment (that\u0027s really wordy for what it does though and is commonly known as - detach_volume).","commit_id":"f1ac153b036ed09055642a0fd510f016ef854e13"}]}