)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0e2b75dab8876c3ae1efb2a09394baf08a92e5a1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"so contributors can follow along and see where things fit into"},{"line_number":15,"context_line":"the puzzle."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"A sequence diagram is sorely need for this as well but that will"},{"line_number":18,"context_line":"come in a separate change."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I11b401a3f874226fdc20a0ee0bd518192f70fa1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_7d8f892d","line":17,"range":{"start_line":17,"start_character":29,"end_line":17,"end_character":33},"updated":"2019-11-22 00:47:01.000000000","message":"needed","commit_id":"1e084096b96c5a3f031c6a83cc6e01c8ee00ec80"}],"doc/source/contributor/resize-and-cold-migrate.rst":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9790e35efd21f75ded30edcd0e8611d95ec3523d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"~~~~~~~~~~"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":":doc:`Cold migrate \u003c/admin/migration\u003e` is an operation performed by an"},{"line_number":14,"context_line":"administrator to power off and move a server from one host to a **different**"},{"line_number":15,"context_line":"host using the **same** flavor. Volumes and network interfaces are disconnected"},{"line_number":16,"context_line":"from the source host and connected on the destination host. The type of file"},{"line_number":17,"context_line":"system between the hosts and image backend determine if the server files and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_5d7ded19","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":13},"updated":"2019-11-22 00:54:22.000000000","message":"Should we mention that this is only by default, and the policy is customisable?\n\n\u003cLater\u003e\n\nAh I see you mention it lower down.","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3e40f14da2fae2457f78797db9a38013cd82e8f6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"host using the **same** flavor. Volumes and network interfaces are disconnected"},{"line_number":16,"context_line":"from the source host and connected on the destination host. The type of file"},{"line_number":17,"context_line":"system between the hosts and image backend determine if the server files and"},{"line_number":18,"context_line":"disks have to be copied. Root and ephemeral disks are copied, swap disks are"},{"line_number":19,"context_line":"re-created."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":":doc:`Resize \u003c/user/resize\u003e` is an operation which can be performed by a"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_067cfab3","line":18,"range":{"start_line":18,"start_character":24,"end_line":18,"end_character":25},"updated":"2019-11-22 19:03:39.000000000","message":"I\u0027d prefix this with something like \"If copy is necessary, root and ephemeral [...]\"","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbc9a53d0d28677db85049a296acb52acd057a8f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"host using the **same** flavor. Volumes and network interfaces are disconnected"},{"line_number":16,"context_line":"from the source host and connected on the destination host. The type of file"},{"line_number":17,"context_line":"system between the hosts and image backend determine if the server files and"},{"line_number":18,"context_line":"disks have to be copied. Root and ephemeral disks are copied, swap disks are"},{"line_number":19,"context_line":"re-created."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":":doc:`Resize \u003c/user/resize\u003e` is an operation which can be performed by a"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_a98139c4","line":18,"range":{"start_line":18,"start_character":24,"end_line":18,"end_character":25},"in_reply_to":"3fa7e38b_067cfab3","updated":"2019-11-22 19:58:00.000000000","message":"Done","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9790e35efd21f75ded30edcd0e8611d95ec3523d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"system between the hosts and image backend determine if the server files and"},{"line_number":18,"context_line":"disks have to be copied. Root and ephemeral disks are copied, swap disks are"},{"line_number":19,"context_line":"re-created."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":":doc:`Resize \u003c/user/resize\u003e` is an operation which can be performed by a"},{"line_number":22,"context_line":"non-administrative owner of the server (the user) with a **different** flavor."},{"line_number":23,"context_line":"As such aspects of the server can change depending on the new flavor, for"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_1d73f54f","line":20,"updated":"2019-11-22 00:54:22.000000000","message":"Should we mention that we can rebuild with a new image?","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"be72a7b0480b921dbd5b462e37811432ad448da2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"system between the hosts and image backend determine if the server files and"},{"line_number":18,"context_line":"disks have to be copied. Root and ephemeral disks are copied, swap disks are"},{"line_number":19,"context_line":"re-created."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":":doc:`Resize \u003c/user/resize\u003e` is an operation which can be performed by a"},{"line_number":22,"context_line":"non-administrative owner of the server (the user) with a **different** flavor."},{"line_number":23,"context_line":"As such aspects of the server can change depending on the new flavor, for"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_ddb79dd7","line":20,"in_reply_to":"3fa7e38b_1d73f54f","updated":"2019-11-22 00:57:08.000000000","message":"Nope. That feels like a slippery slope to me.\n\nIf you\u0027re asking \"does the image ever change with either resize or cold migrate\" because people wonder that, then I think I could probably work *that* in with a simple statement.","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3e40f14da2fae2457f78797db9a38013cd82e8f6","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":":doc:`Resize \u003c/user/resize\u003e` is an operation which can be performed by a"},{"line_number":22,"context_line":"non-administrative owner of the server (the user) with a **different** flavor."},{"line_number":23,"context_line":"As such aspects of the server can change depending on the new flavor, for"},{"line_number":24,"context_line":"example the number of vcpus, ram and disk can change. Otherwise for the most"},{"line_number":25,"context_line":"part the internal details are the same as a cold migration."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Scheduling"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_0655da1d","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":53},"updated":"2019-11-22 19:03:39.000000000","message":"Bit awkward. How about:\n\n\"The new flavor can change certain aspects of the server, like the number of CPUs [do we need to distinguish between vCPUs and pCPUs here?], RAM and disk size.\"","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbc9a53d0d28677db85049a296acb52acd057a8f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":":doc:`Resize \u003c/user/resize\u003e` is an operation which can be performed by a"},{"line_number":22,"context_line":"non-administrative owner of the server (the user) with a **different** flavor."},{"line_number":23,"context_line":"As such aspects of the server can change depending on the new flavor, for"},{"line_number":24,"context_line":"example the number of vcpus, ram and disk can change. Otherwise for the most"},{"line_number":25,"context_line":"part the internal details are the same as a cold migration."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Scheduling"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_0972cd12","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":53},"in_reply_to":"3fa7e38b_0655da1d","updated":"2019-11-22 19:58:00.000000000","message":"Done","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9790e35efd21f75ded30edcd0e8611d95ec3523d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"~~~~~~"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"As noted above, with resize the flavor *must* change and with cold migrate the"},{"line_number":46,"context_line":"flavor *will not* change."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Resource claims"},{"line_number":49,"context_line":"~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_3d6ef163","line":46,"range":{"start_line":46,"start_character":18,"end_line":46,"end_character":24},"updated":"2019-11-22 00:54:22.000000000","message":"but the image can.","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"be72a7b0480b921dbd5b462e37811432ad448da2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"~~~~~~"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"As noted above, with resize the flavor *must* change and with cold migrate the"},{"line_number":46,"context_line":"flavor *will not* change."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Resource claims"},{"line_number":49,"context_line":"~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_fdba99bd","line":46,"range":{"start_line":46,"start_character":18,"end_line":46,"end_character":24},"in_reply_to":"3fa7e38b_3d6ef163","updated":"2019-11-22 00:57:08.000000000","message":"No, it can\u0027t. :)","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3e40f14da2fae2457f78797db9a38013cd82e8f6","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Both resize and cold migration perform a `resize claim`_ on the destination"},{"line_number":52,"context_line":"host. Historically the resize claim was meant as a safety check on the selected"},{"line_number":53,"context_line":"compute to work around race conditions in the scheduler. Since the scheduler"},{"line_number":54,"context_line":"started `atomically claiming`_ vcpu, ram and disk allocations using Placement,"},{"line_number":55,"context_line":"the role of the resize claim is mostly just to detect the same race conditions"},{"line_number":56,"context_line":"but for resources like PCI devices and NUMA topology which, at least as of the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_e61c3e78","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":7},"updated":"2019-11-22 19:03:39.000000000","message":"\"host\", to stay consistent?","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbc9a53d0d28677db85049a296acb52acd057a8f","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Both resize and cold migration perform a `resize claim`_ on the destination"},{"line_number":52,"context_line":"host. Historically the resize claim was meant as a safety check on the selected"},{"line_number":53,"context_line":"compute to work around race conditions in the scheduler. Since the scheduler"},{"line_number":54,"context_line":"started `atomically claiming`_ vcpu, ram and disk allocations using Placement,"},{"line_number":55,"context_line":"the role of the resize claim is mostly just to detect the same race conditions"},{"line_number":56,"context_line":"but for resources like PCI devices and NUMA topology which, at least as of the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_89579d5a","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":7},"in_reply_to":"3fa7e38b_e61c3e78","updated":"2019-11-22 19:58:00.000000000","message":"Done - though it should probably be node since the ResourceTracker works on nodes rather than hosts.","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3e40f14da2fae2457f78797db9a38013cd82e8f6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Both resize and cold migration perform a `resize claim`_ on the destination"},{"line_number":52,"context_line":"host. Historically the resize claim was meant as a safety check on the selected"},{"line_number":53,"context_line":"compute to work around race conditions in the scheduler. Since the scheduler"},{"line_number":54,"context_line":"started `atomically claiming`_ vcpu, ram and disk allocations using Placement,"},{"line_number":55,"context_line":"the role of the resize claim is mostly just to detect the same race conditions"},{"line_number":56,"context_line":"but for resources like PCI devices and NUMA topology which, at least as of the"},{"line_number":57,"context_line":"20.0.0 (Train) release, are not modeled in Placement and as such are not"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_66084e2c","line":54,"range":{"start_line":54,"start_character":37,"end_line":54,"end_character":40},"updated":"2019-11-22 19:03:39.000000000","message":"RAM","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3e40f14da2fae2457f78797db9a38013cd82e8f6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Both resize and cold migration perform a `resize claim`_ on the destination"},{"line_number":52,"context_line":"host. Historically the resize claim was meant as a safety check on the selected"},{"line_number":53,"context_line":"compute to work around race conditions in the scheduler. Since the scheduler"},{"line_number":54,"context_line":"started `atomically claiming`_ vcpu, ram and disk allocations using Placement,"},{"line_number":55,"context_line":"the role of the resize claim is mostly just to detect the same race conditions"},{"line_number":56,"context_line":"but for resources like PCI devices and NUMA topology which, at least as of the"},{"line_number":57,"context_line":"20.0.0 (Train) release, are not modeled in Placement and as such are not"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_460d123c","line":54,"range":{"start_line":54,"start_character":31,"end_line":54,"end_character":35},"updated":"2019-11-22 19:03:39.000000000","message":"vCPU, or just CPU","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbc9a53d0d28677db85049a296acb52acd057a8f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Both resize and cold migration perform a `resize claim`_ on the destination"},{"line_number":52,"context_line":"host. Historically the resize claim was meant as a safety check on the selected"},{"line_number":53,"context_line":"compute to work around race conditions in the scheduler. Since the scheduler"},{"line_number":54,"context_line":"started `atomically claiming`_ vcpu, ram and disk allocations using Placement,"},{"line_number":55,"context_line":"the role of the resize claim is mostly just to detect the same race conditions"},{"line_number":56,"context_line":"but for resources like PCI devices and NUMA topology which, at least as of the"},{"line_number":57,"context_line":"20.0.0 (Train) release, are not modeled in Placement and as such are not"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_e9c97124","line":54,"range":{"start_line":54,"start_character":37,"end_line":54,"end_character":40},"in_reply_to":"3fa7e38b_66084e2c","updated":"2019-11-22 19:58:00.000000000","message":"I\u0027ll just use the standard resource classes (VCPU, MEMORY_MB, DISK_GB).","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3e40f14da2fae2457f78797db9a38013cd82e8f6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"host. Historically the resize claim was meant as a safety check on the selected"},{"line_number":53,"context_line":"compute to work around race conditions in the scheduler. Since the scheduler"},{"line_number":54,"context_line":"started `atomically claiming`_ vcpu, ram and disk allocations using Placement,"},{"line_number":55,"context_line":"the role of the resize claim is mostly just to detect the same race conditions"},{"line_number":56,"context_line":"but for resources like PCI devices and NUMA topology which, at least as of the"},{"line_number":57,"context_line":"20.0.0 (Train) release, are not modeled in Placement and as such are not"},{"line_number":58,"context_line":"atomic."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_a907f916","line":55,"range":{"start_line":55,"start_character":29,"end_line":55,"end_character":53},"updated":"2019-11-22 19:03:39.000000000","message":"Bit awkward, how about:\n\n\"the role of the resize claim has been reduced to detecting the same conditions, but for\"","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbc9a53d0d28677db85049a296acb52acd057a8f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"host. Historically the resize claim was meant as a safety check on the selected"},{"line_number":53,"context_line":"compute to work around race conditions in the scheduler. Since the scheduler"},{"line_number":54,"context_line":"started `atomically claiming`_ vcpu, ram and disk allocations using Placement,"},{"line_number":55,"context_line":"the role of the resize claim is mostly just to detect the same race conditions"},{"line_number":56,"context_line":"but for resources like PCI devices and NUMA topology which, at least as of the"},{"line_number":57,"context_line":"20.0.0 (Train) release, are not modeled in Placement and as such are not"},{"line_number":58,"context_line":"atomic."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_c994b5ea","line":55,"range":{"start_line":55,"start_character":29,"end_line":55,"end_character":53},"in_reply_to":"3fa7e38b_a907f916","updated":"2019-11-22 19:58:00.000000000","message":"Done","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9790e35efd21f75ded30edcd0e8611d95ec3523d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"and weighers and picks a host, resource class `allocations`_ are atomically"},{"line_number":71,"context_line":"consumed in placement with the server as the consumer."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"During both resize and cold migrate operations, the allocations held by the"},{"line_number":74,"context_line":"server consumer against the source compute node resource provider are `moved`_"},{"line_number":75,"context_line":"to a `migration record`_ and the scheduler will create allocations, held by the"},{"line_number":76,"context_line":"instance consumer, on the selected destination compute node resource provider."},{"line_number":77,"context_line":"This is commonly referred to as `migration-based allocations`_ which were"},{"line_number":78,"context_line":"introduced in the 17.0.0 (Queens) release."},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_5da2cd9b","line":76,"range":{"start_line":73,"start_character":48,"end_line":76,"end_character":78},"updated":"2019-11-22 00:54:22.000000000","message":"Huh, so this is backward from the old-style claims. In that case, the migration is consuming on the destination, and the instance on the source. Here it\u0027s the other way around: the migration is the consumer on the source RP, and the instance/server is the consumer on the dest RP.","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9790e35efd21f75ded30edcd0e8611d95ec3523d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"   * - Authorization (default)"},{"line_number":99,"context_line":"     - Admin or owner (user)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"       Policy rule: ``os_compute_api:servers:resize``"},{"line_number":102,"context_line":"     - Admin only"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"       Policy rule: ``os_compute_api:os-migrate-server:migrate``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_7d9d4955","line":101,"updated":"2019-11-22 00:54:22.000000000","message":"Ah you mention the policy here","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9790e35efd21f75ded30edcd0e8611d95ec3523d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"       Policy rule: ``os_compute_api:os-migrate-server:migrate``"},{"line_number":105,"context_line":"   * - Same host"},{"line_number":106,"context_line":"     - Maybe"},{"line_number":107,"context_line":"     - Only vCenter"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Sequence Diagram"},{"line_number":110,"context_line":"~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_1da8d575","line":107,"updated":"2019-11-22 00:54:22.000000000","message":"Image change possibility here?","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"be72a7b0480b921dbd5b462e37811432ad448da2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"       Policy rule: ``os_compute_api:os-migrate-server:migrate``"},{"line_number":105,"context_line":"   * - Same host"},{"line_number":106,"context_line":"     - Maybe"},{"line_number":107,"context_line":"     - Only vCenter"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Sequence Diagram"},{"line_number":110,"context_line":"~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_9dada585","line":107,"in_reply_to":"3fa7e38b_1da8d575","updated":"2019-11-22 00:57:08.000000000","message":"No, either allow changing the image so there is no difference.","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e27dd06f4555896913c03b36e2ebbfeb46f41b9e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"       Policy rule: ``os_compute_api:os-migrate-server:migrate``"},{"line_number":105,"context_line":"   * - Same host"},{"line_number":106,"context_line":"     - Maybe"},{"line_number":107,"context_line":"     - Only vCenter"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Sequence Diagram"},{"line_number":110,"context_line":"~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_bd442174","line":107,"in_reply_to":"3fa7e38b_9dada585","updated":"2019-11-22 01:50:00.000000000","message":"*neither","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3e40f14da2fae2457f78797db9a38013cd82e8f6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Sequence Diagram"},{"line_number":110,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. todo:: Add something like the :doc:`/reference/live-migration` diagram."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":".. _resize API: https://docs.openstack.org/api-ref/compute/#resize-server-resize-action"},{"line_number":115,"context_line":".. _cold migrate API: https://docs.openstack.org/api-ref/compute/#migrate-server-migrate-action"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_a6b64688","line":112,"updated":"2019-11-22 19:03:39.000000000","message":"I first went looking for the rendered version of this in the same place as the live migration doc (For Contributors -\u003e Technical Reference Deep Dives -\u003e Live Migration), but actually this is in For Contributors -\u003e Contributor Documentation -\u003e Nova Major Subsystems subheading. Which is fine (parallels the Evacuate vs Rebuild section), but the inclusion of this TODO for a sequence diagram made it look like it was going in the same place as the other sequence diagram for live migration.","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3e40f14da2fae2457f78797db9a38013cd82e8f6","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":".. _resize API: https://docs.openstack.org/api-ref/compute/#resize-server-resize-action"},{"line_number":115,"context_line":".. _cold migrate API: https://docs.openstack.org/api-ref/compute/#migrate-server-migrate-action"},{"line_number":116,"context_line":".. _API code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/api.py#L3568"},{"line_number":117,"context_line":".. _conductor code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/conductor/manager.py#L297"},{"line_number":118,"context_line":".. _compute code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/manager.py#L4445"},{"line_number":119,"context_line":".. _microversion 2.56: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id51"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_e6651e1e","line":116,"range":{"start_line":116,"start_character":57,"end_line":116,"end_character":63},"updated":"2019-11-22 19:03:39.000000000","message":"I guess there\u0027s no way to automagically update this tag on every release, so even in U and beyond it\u0027ll still point to Train code unless we change it manually. Not that I have a better idea.","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbc9a53d0d28677db85049a296acb52acd057a8f","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":".. _resize API: https://docs.openstack.org/api-ref/compute/#resize-server-resize-action"},{"line_number":115,"context_line":".. _cold migrate API: https://docs.openstack.org/api-ref/compute/#migrate-server-migrate-action"},{"line_number":116,"context_line":".. _API code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/api.py#L3568"},{"line_number":117,"context_line":".. _conductor code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/conductor/manager.py#L297"},{"line_number":118,"context_line":".. _compute code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/manager.py#L4445"},{"line_number":119,"context_line":".. _microversion 2.56: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id51"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_a99db909","line":116,"range":{"start_line":116,"start_character":57,"end_line":116,"end_character":63},"in_reply_to":"3fa7e38b_e6651e1e","updated":"2019-11-22 19:58:00.000000000","message":"Not that I know of. And 19.0.0 is actually Stein GA but the links to the methods aren\u0027t really any different (the methods themselves involved in the process I mean).","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3e40f14da2fae2457f78797db9a38013cd82e8f6","unresolved":false,"context_lines":[{"line_number":116,"context_line":".. _API code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/api.py#L3568"},{"line_number":117,"context_line":".. _conductor code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/conductor/manager.py#L297"},{"line_number":118,"context_line":".. _compute code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/manager.py#L4445"},{"line_number":119,"context_line":".. _microversion 2.56: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id51"},{"line_number":120,"context_line":".. _resize claim: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/resource_tracker.py#L248"},{"line_number":121,"context_line":".. _atomically claiming: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/scheduler/filter_scheduler.py#L239"},{"line_number":122,"context_line":".. _moved: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/conductor/tasks/migrate.py#L28"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_062aba8f","line":119,"range":{"start_line":119,"start_character":104,"end_line":119,"end_character":106},"updated":"2019-11-22 19:03:39.000000000","message":"id51 is 2.55, this should be id52","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbc9a53d0d28677db85049a296acb52acd057a8f","unresolved":false,"context_lines":[{"line_number":116,"context_line":".. _API code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/api.py#L3568"},{"line_number":117,"context_line":".. _conductor code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/conductor/manager.py#L297"},{"line_number":118,"context_line":".. _compute code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/manager.py#L4445"},{"line_number":119,"context_line":".. _microversion 2.56: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id51"},{"line_number":120,"context_line":".. _resize claim: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/resource_tracker.py#L248"},{"line_number":121,"context_line":".. _atomically claiming: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/scheduler/filter_scheduler.py#L239"},{"line_number":122,"context_line":".. _moved: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/conductor/tasks/migrate.py#L28"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_89b31d9a","line":119,"range":{"start_line":119,"start_character":104,"end_line":119,"end_character":106},"in_reply_to":"3fa7e38b_062aba8f","updated":"2019-11-22 19:58:00.000000000","message":"Ack yeah thanks, the damn banner must have gotten in the way.","commit_id":"e404b1de2f854e4851c89d31d5849cf146bf24a1"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9156e42be219271c4844a6fe6d257cfda805be2f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"High level"},{"line_number":11,"context_line":"~~~~~~~~~~"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":":doc:`Cold migrate \u003c/admin/migration\u003e` is an operation performed by an"},{"line_number":14,"context_line":"administrator to power off and move a server from one host to a **different**"},{"line_number":15,"context_line":"host using the **same** flavor. Volumes and network interfaces are disconnected"},{"line_number":16,"context_line":"from the source host and connected on the destination host. The type of file"},{"line_number":17,"context_line":"system between the hosts and image backend determine if the server files and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_74cb1449","line":14,"range":{"start_line":13,"start_character":55,"end_line":14,"end_character":13},"updated":"2019-11-22 21:00:34.000000000","message":"by default?","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22b8d26ba7690aa6fd8d00a6770799fb5822bcd5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"High level"},{"line_number":11,"context_line":"~~~~~~~~~~"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":":doc:`Cold migrate \u003c/admin/migration\u003e` is an operation performed by an"},{"line_number":14,"context_line":"administrator to power off and move a server from one host to a **different**"},{"line_number":15,"context_line":"host using the **same** flavor. Volumes and network interfaces are disconnected"},{"line_number":16,"context_line":"from the source host and connected on the destination host. The type of file"},{"line_number":17,"context_line":"system between the hosts and image backend determine if the server files and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_ef2ad17b","line":14,"range":{"start_line":13,"start_character":55,"end_line":14,"end_character":13},"in_reply_to":"3fa7e38b_74cb1449","updated":"2019-11-22 21:22:20.000000000","message":"I mention that in the table below.","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9156e42be219271c4844a6fe6d257cfda805be2f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"disks have to be copied. If copy is necessary then root and ephemeral disks are"},{"line_number":19,"context_line":"copied and swap disks are re-created."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":":doc:`Resize \u003c/user/resize\u003e` is an operation which can be performed by a"},{"line_number":22,"context_line":"non-administrative owner of the server (the user) with a **different** flavor."},{"line_number":23,"context_line":"The new flavor can change certain aspects of the server such as the number of"},{"line_number":24,"context_line":"CPUS, RAM and disk size. Otherwise for the most part the internal details are"},{"line_number":25,"context_line":"the same as a cold migration."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_14d660f3","line":22,"range":{"start_line":21,"start_character":58,"end_line":22,"end_character":49},"updated":"2019-11-22 21:00:34.000000000","message":"by default?\n\nPerhaps a common asterisk for both of these\n\n[Later] I see (by default) in the table at the bottom, probably good enough, meh.","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22b8d26ba7690aa6fd8d00a6770799fb5822bcd5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"disks have to be copied. If copy is necessary then root and ephemeral disks are"},{"line_number":19,"context_line":"copied and swap disks are re-created."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":":doc:`Resize \u003c/user/resize\u003e` is an operation which can be performed by a"},{"line_number":22,"context_line":"non-administrative owner of the server (the user) with a **different** flavor."},{"line_number":23,"context_line":"The new flavor can change certain aspects of the server such as the number of"},{"line_number":24,"context_line":"CPUS, RAM and disk size. Otherwise for the most part the internal details are"},{"line_number":25,"context_line":"the same as a cold migration."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_8f1d5d63","line":22,"range":{"start_line":21,"start_character":58,"end_line":22,"end_character":49},"in_reply_to":"3fa7e38b_14d660f3","updated":"2019-11-22 21:22:20.000000000","message":"Done","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9156e42be219271c4844a6fe6d257cfda805be2f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Depending on how the API is configured for"},{"line_number":31,"context_line":":oslo.config:option:`allow_resize_to_same_host`, the server may be able to be"},{"line_number":32,"context_line":"resized on the current host. *All* compute drivers support *resizing* to the"},{"line_number":33,"context_line":"same host but *only* the vCenter driver supports *cold migrating* to the same"},{"line_number":34,"context_line":"host. Enabling resize to the same host is necessary for features such as"},{"line_number":35,"context_line":"strict affinity server groups where there are more than one server in the same"},{"line_number":36,"context_line":"affinity group."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_54f9387d","line":34,"range":{"start_line":33,"start_character":25,"end_line":34,"end_character":4},"updated":"2019-11-22 21:00:34.000000000","message":"Can you add a helpful \"why tf you would ever need/want to do this\" sentence like you did for same-host resize below? Cause given the explanation so far, I don\u0027t understand how same-host cold migrate would ever *not* be a no-op. I guess internally vCenter moves the VM to another node in its cluster?","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22b8d26ba7690aa6fd8d00a6770799fb5822bcd5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Depending on how the API is configured for"},{"line_number":31,"context_line":":oslo.config:option:`allow_resize_to_same_host`, the server may be able to be"},{"line_number":32,"context_line":"resized on the current host. *All* compute drivers support *resizing* to the"},{"line_number":33,"context_line":"same host but *only* the vCenter driver supports *cold migrating* to the same"},{"line_number":34,"context_line":"host. Enabling resize to the same host is necessary for features such as"},{"line_number":35,"context_line":"strict affinity server groups where there are more than one server in the same"},{"line_number":36,"context_line":"affinity group."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_2f2c6991","line":34,"range":{"start_line":33,"start_character":25,"end_line":34,"end_character":4},"in_reply_to":"3fa7e38b_54f9387d","updated":"2019-11-22 21:22:20.000000000","message":"\u003e I guess internally vCenter moves the\n \u003e VM to another node in its cluster?\n\nCorrect. The vCenter driver is just a proxy to a cluster of ESXi hosts so you\u0027re not really cold migrating to the same ESXi host, you\u0027re cold migrating within the same cluster, which is represented as a nova compute service host.\n\nIf that\u0027s helpful I could follow up with something to that effect.","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9156e42be219271c4844a6fe6d257cfda805be2f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"resized on the current host. *All* compute drivers support *resizing* to the"},{"line_number":33,"context_line":"same host but *only* the vCenter driver supports *cold migrating* to the same"},{"line_number":34,"context_line":"host. Enabling resize to the same host is necessary for features such as"},{"line_number":35,"context_line":"strict affinity server groups where there are more than one server in the same"},{"line_number":36,"context_line":"affinity group."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Starting with `microversion 2.56`_ an administrator can specify a destination"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_b433cc60","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":29},"updated":"2019-11-22 21:00:34.000000000","message":"Another obvious use case to me is simply that I want to minimize downtime while I grow my (local ephemeral) disk, right?\n\n[Later] Oh, except you can\u0027t directly specify same-host, so you only get that benefit by luck (or hackery). Hmph.","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9156e42be219271c4844a6fe6d257cfda805be2f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"resized on the current host. *All* compute drivers support *resizing* to the"},{"line_number":33,"context_line":"same host but *only* the vCenter driver supports *cold migrating* to the same"},{"line_number":34,"context_line":"host. Enabling resize to the same host is necessary for features such as"},{"line_number":35,"context_line":"strict affinity server groups where there are more than one server in the same"},{"line_number":36,"context_line":"affinity group."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Starting with `microversion 2.56`_ an administrator can specify a destination"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_34d11cf9","line":35,"range":{"start_line":35,"start_character":42,"end_line":35,"end_character":45},"updated":"2019-11-22 21:00:34.000000000","message":"is","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22b8d26ba7690aa6fd8d00a6770799fb5822bcd5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"resized on the current host. *All* compute drivers support *resizing* to the"},{"line_number":33,"context_line":"same host but *only* the vCenter driver supports *cold migrating* to the same"},{"line_number":34,"context_line":"host. Enabling resize to the same host is necessary for features such as"},{"line_number":35,"context_line":"strict affinity server groups where there are more than one server in the same"},{"line_number":36,"context_line":"affinity group."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Starting with `microversion 2.56`_ an administrator can specify a destination"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_8f523d11","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":29},"in_reply_to":"3fa7e38b_b433cc60","updated":"2019-11-22 21:22:20.000000000","message":"Yeah. Another use case is small edge sites (think a single compute host) so resizing to another host isn\u0027t an option.","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9156e42be219271c4844a6fe6d257cfda805be2f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"affinity group."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Starting with `microversion 2.56`_ an administrator can specify a destination"},{"line_number":39,"context_line":"host for the cold migrate operation. Resize does not allow specifying a"},{"line_number":40,"context_line":"destination host."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Flavor"},{"line_number":43,"context_line":"~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_5427f812","line":40,"range":{"start_line":39,"start_character":37,"end_line":40,"end_character":17},"updated":"2019-11-22 21:00:34.000000000","message":"oh, so I would have to use some kind of trickery to make sure it stays put, interesting","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22b8d26ba7690aa6fd8d00a6770799fb5822bcd5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"affinity group."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Starting with `microversion 2.56`_ an administrator can specify a destination"},{"line_number":39,"context_line":"host for the cold migrate operation. Resize does not allow specifying a"},{"line_number":40,"context_line":"destination host."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Flavor"},{"line_number":43,"context_line":"~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_4f40c535","line":40,"range":{"start_line":39,"start_character":37,"end_line":40,"end_character":17},"in_reply_to":"3fa7e38b_5427f812","updated":"2019-11-22 21:22:20.000000000","message":"Like a strict affinity server group yeah.","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9156e42be219271c4844a6fe6d257cfda805be2f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"   * - Can specify target host"},{"line_number":109,"context_line":"     - No"},{"line_number":110,"context_line":"     - Yes (microversion \u003e\u003d 2.56)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Sequence Diagram"},{"line_number":113,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_148e60d0","line":111,"updated":"2019-11-22 21:00:34.000000000","message":"Things that would be useful to add to this doc:\n- VM/task states (and InstanceActionEvents?)\n- API call sequence (like, don\u0027t both of these need a \u0027confirm\u0027/\u0027revert\u0027? Is it the same one for both?)\n\nPerhaps these are part of the seqdiag, haven\u0027t looked yet.","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22b8d26ba7690aa6fd8d00a6770799fb5822bcd5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"   * - Can specify target host"},{"line_number":109,"context_line":"     - No"},{"line_number":110,"context_line":"     - Yes (microversion \u003e\u003d 2.56)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Sequence Diagram"},{"line_number":113,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_af7cd970","line":111,"in_reply_to":"3fa7e38b_148e60d0","updated":"2019-11-22 21:22:20.000000000","message":"The latter is in the sequence diagram in the next change in the series.\n\nThe vm_states/task_states should be covered here:\n\nhttps://docs.openstack.org/nova/latest/reference/vm-states.html\n\nAs for instance actions and events, we haven\u0027t documented those in detail anywhere and the events themselves are prone to change since they are mostly just based on method names that are decorated with the @wrap_instance_event decorator. The action names are static, but the event names could change - or new events could be added to the overall flow. I\u0027m not saying that\u0027s not useful information to document, like we\u0027ve done for notifications, but it would probably be easiest if we could automate that like what gibi did with the notification samples.","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9156e42be219271c4844a6fe6d257cfda805be2f","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. _resize API: https://docs.openstack.org/api-ref/compute/#resize-server-resize-action"},{"line_number":118,"context_line":".. _cold migrate API: https://docs.openstack.org/api-ref/compute/#migrate-server-migrate-action"},{"line_number":119,"context_line":".. _API code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/api.py#L3568"},{"line_number":120,"context_line":".. _conductor code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/conductor/manager.py#L297"},{"line_number":121,"context_line":".. _compute code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/manager.py#L4445"},{"line_number":122,"context_line":".. _microversion 2.56: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id52"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_1472e012","line":119,"range":{"start_line":119,"start_character":56,"end_line":119,"end_character":63},"updated":"2019-11-22 21:00:34.000000000","message":"How come you\u0027re using stein (as opposed to train) versions for all of these?","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22b8d26ba7690aa6fd8d00a6770799fb5822bcd5","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. _resize API: https://docs.openstack.org/api-ref/compute/#resize-server-resize-action"},{"line_number":118,"context_line":".. _cold migrate API: https://docs.openstack.org/api-ref/compute/#migrate-server-migrate-action"},{"line_number":119,"context_line":".. _API code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/api.py#L3568"},{"line_number":120,"context_line":".. _conductor code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/conductor/manager.py#L297"},{"line_number":121,"context_line":".. _compute code: https://opendev.org/openstack/nova/src/tag/19.0.0/nova/compute/manager.py#L4445"},{"line_number":122,"context_line":".. _microversion 2.56: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id52"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_4f976591","line":119,"range":{"start_line":119,"start_character":56,"end_line":119,"end_character":63},"in_reply_to":"3fa7e38b_1472e012","updated":"2019-11-22 21:22:20.000000000","message":"Because I started this doc with copying the evacuate-vs-rebuild doc and that used stein links and then I just modified.\n\nThis could be updated to use Train, but the point is it\u0027s just a link to the methods in the api/conductor/compute and their names (which are later in the sequence diagram) so as long as those don\u0027t fundamentally change I don\u0027t think it really matters.","commit_id":"1e781f6f3409a7dd6f01fa41ea4f8efc18722b8d"}]}