)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5c160704ec2fd52d7156550bf8ecbfbd5c4f3a6f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: Remove MIN_{LIBVIRT,QEMU}_FILE_BACKED_VERSION"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The updated minimum required libvirt (5.0.0) and QEMU (4.0.0) for"},{"line_number":10,"context_line":"\"Ussuri\" satisfy the version requirements; this was done in Change-Id:"},{"line_number":11,"context_line":"Ia18e9be4d (22c1916b49 — libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for"},{"line_number":12,"context_line":"\"Ussuri\", 2019-11-19)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_ac2a957a","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":65},"updated":"2019-11-25 16:55:56.000000000","message":"these need to change","commit_id":"5fa4d815a0f86ed2c57ce3a5a8b143ae4c34e31f"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5c160704ec2fd52d7156550bf8ecbfbd5c4f3a6f","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"            drvr.init_host(\"dummyhost\")"},{"line_number":1245,"context_line":"            self.assertTrue(mock_check_fb_support.called)"},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"    @mock.patch.object(fakelibvirt.Connection, \u0027getLibVersion\u0027,"},{"line_number":1248,"context_line":"                       return_value\u003dversionutils.convert_version_to_int("},{"line_number":1249,"context_line":"                           libvirt_driver.MIN_LIBVIRT_FILE_BACKED_VERSION))"},{"line_number":1250,"context_line":"    @mock.patch.object(fakelibvirt.Connection, \u0027getVersion\u0027,"},{"line_number":1251,"context_line":"                       return_value\u003dversionutils.convert_version_to_int("},{"line_number":1252,"context_line":"                           libvirt_driver.MIN_QEMU_FILE_BACKED_VERSION))"},{"line_number":1253,"context_line":"    def test_min_version_file_backed_ok(self, mock_libv, mock_qemu):"},{"line_number":1254,"context_line":"        self.flags(file_backed_memory\u003d1024, group\u003d\u0027libvirt\u0027)"},{"line_number":1255,"context_line":"        self.flags(ram_allocation_ratio\u003d1.0)"},{"line_number":1256,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":1257,"context_line":"        drvr._check_file_backed_memory_support()"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"    @mock.patch.object(fakelibvirt.Connection, \u0027getLibVersion\u0027,"},{"line_number":1260,"context_line":"                       return_value\u003dversionutils.convert_version_to_int("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8c2799b6","side":"PARENT","line":1257,"range":{"start_line":1247,"start_character":0,"end_line":1257,"end_character":48},"updated":"2019-11-25 16:55:56.000000000","message":"This should stay. Just drop the version mocks but keep the flag configuration.","commit_id":"aa52e421cb5e6592881b1b3466d3277e8580f167"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"430a575f660c25b2628efb480fe54f423251c206","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"            drvr.init_host(\"dummyhost\")"},{"line_number":1245,"context_line":"            self.assertTrue(mock_check_fb_support.called)"},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"    @mock.patch.object(fakelibvirt.Connection, \u0027getLibVersion\u0027,"},{"line_number":1248,"context_line":"                       return_value\u003dversionutils.convert_version_to_int("},{"line_number":1249,"context_line":"                           libvirt_driver.MIN_LIBVIRT_FILE_BACKED_VERSION))"},{"line_number":1250,"context_line":"    @mock.patch.object(fakelibvirt.Connection, \u0027getVersion\u0027,"},{"line_number":1251,"context_line":"                       return_value\u003dversionutils.convert_version_to_int("},{"line_number":1252,"context_line":"                           libvirt_driver.MIN_QEMU_FILE_BACKED_VERSION))"},{"line_number":1253,"context_line":"    def test_min_version_file_backed_ok(self, mock_libv, mock_qemu):"},{"line_number":1254,"context_line":"        self.flags(file_backed_memory\u003d1024, group\u003d\u0027libvirt\u0027)"},{"line_number":1255,"context_line":"        self.flags(ram_allocation_ratio\u003d1.0)"},{"line_number":1256,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":1257,"context_line":"        drvr._check_file_backed_memory_support()"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"    @mock.patch.object(fakelibvirt.Connection, \u0027getLibVersion\u0027,"},{"line_number":1260,"context_line":"                       return_value\u003dversionutils.convert_version_to_int("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_93456647","side":"PARENT","line":1257,"range":{"start_line":1247,"start_character":0,"end_line":1257,"end_character":48},"in_reply_to":"3fa7e38b_8c2799b6","updated":"2019-11-26 14:01:40.000000000","message":"True; need to test the flag config.\n\nIn v2...","commit_id":"aa52e421cb5e6592881b1b3466d3277e8580f167"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"77a4d10692fe59e809901f93ddf14ab4382c2482","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"            drvr.init_host(\"dummyhost\")"},{"line_number":1244,"context_line":"            self.assertTrue(mock_check_fb_support.called)"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"    def test_min_version_file_backed_ok(self):"},{"line_number":1247,"context_line":"        self.flags(file_backed_memory\u003d1024, group\u003d\u0027libvirt\u0027)"},{"line_number":1248,"context_line":"        self.flags(ram_allocation_ratio\u003d1.0)"},{"line_number":1249,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d0afbf28","line":1246,"range":{"start_line":1246,"start_character":13,"end_line":1246,"end_character":36},"updated":"2019-12-06 17:13:39.000000000","message":"s/min_version_file_backed/_check_file_backed_memory_support/","commit_id":"720302b5d26b685d3b62ebb46610acf13c42805c"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"6fbf40cd86c3ece2d369da3175ebdefc625fb17e","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"            drvr.init_host(\"dummyhost\")"},{"line_number":1244,"context_line":"            self.assertTrue(mock_check_fb_support.called)"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"    def test_min_version_file_backed_ok(self):"},{"line_number":1247,"context_line":"        self.flags(file_backed_memory\u003d1024, group\u003d\u0027libvirt\u0027)"},{"line_number":1248,"context_line":"        self.flags(ram_allocation_ratio\u003d1.0)"},{"line_number":1249,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a95c0e1a","line":1246,"range":{"start_line":1246,"start_character":13,"end_line":1246,"end_character":36},"in_reply_to":"3fa7e38b_d0afbf28","updated":"2019-12-09 14:03:50.000000000","message":"Yes, makes sense (also below); I had it at the back of my mind, but merrily forgot.","commit_id":"720302b5d26b685d3b62ebb46610acf13c42805c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"77a4d10692fe59e809901f93ddf14ab4382c2482","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":1250,"context_line":"        drvr._check_file_backed_memory_support()"},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"    def test_min_version_file_backed_bad_ram_allocation_ratio(self):"},{"line_number":1253,"context_line":"        self.flags(file_backed_memory\u003d1024, group\u003d\"libvirt\")"},{"line_number":1254,"context_line":"        self.flags(ram_allocation_ratio\u003d1.5)"},{"line_number":1255,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_70660b2c","line":1252,"range":{"start_line":1252,"start_character":13,"end_line":1252,"end_character":36},"updated":"2019-12-06 17:13:39.000000000","message":"s/min_version_file_backed/_check_file_backed_memory_support/","commit_id":"720302b5d26b685d3b62ebb46610acf13c42805c"}]}