)]}'
{"nova/scheduler/filters/retry_filter.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"73fb596d3fc720c82f7601f9a488cac301f8fa0d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        host \u003d [host_state.host, host_state.nodename]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        passes \u003d host not in hosts"},{"line_number":41,"context_line":"        pass_msg \u003d \"passes\" if passes else \"fails\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        if not passes and ENABLE_LOGGING:"},{"line_number":44,"context_line":"            LOG.debug(_(\"Host %(host)s %(pass_msg)s.  Previously tried hosts: \""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2FiFI%3D","line":41,"updated":"2014-02-12 15:05:49.000000000","message":"Seems pass_msg is no use as we do not log message when passed.","commit_id":"489ea7524b2f958a9c6ef1acf2be71fbb38f1798"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"73fb596d3fc720c82f7601f9a488cac301f8fa0d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        passes \u003d host not in hosts"},{"line_number":41,"context_line":"        pass_msg \u003d \"passes\" if passes else \"fails\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        if not passes and ENABLE_LOGGING:"},{"line_number":44,"context_line":"            LOG.debug(_(\"Host %(host)s %(pass_msg)s.  Previously tried hosts: \""},{"line_number":45,"context_line":"                        \"%(hosts)s\") % {\u0027host\u0027: host,"},{"line_number":46,"context_line":"                                        \u0027pass_msg\u0027: pass_msg,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2FiRs%3D","line":43,"updated":"2014-02-12 15:05:49.000000000","message":"If do not want to log unhappy things, then what about update message to reflect the filter failed?","commit_id":"489ea7524b2f958a9c6ef1acf2be71fbb38f1798"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"57d2ede66139f0820839d9ac61ec64b0f0ae0fcd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        passes \u003d host not in hosts"},{"line_number":41,"context_line":"        pass_msg \u003d \"passes\" if passes else \"fails\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        if not passes and ENABLE_LOGGING:"},{"line_number":44,"context_line":"            LOG.debug(_(\"Host %(host)s %(pass_msg)s.  Previously tried hosts: \""},{"line_number":45,"context_line":"                        \"%(hosts)s\") % {\u0027host\u0027: host,"},{"line_number":46,"context_line":"                                        \u0027pass_msg\u0027: pass_msg,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2FeCs%3D","line":43,"in_reply_to":"AAAAUX%2F%2FiRs%3D","updated":"2014-02-12 23:54:01.000000000","message":"sure, makes sense, this is just a quick hack to prove the performance difference.","commit_id":"489ea7524b2f958a9c6ef1acf2be71fbb38f1798"}],"nova/servicegroup/drivers/db.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"73fb596d3fc720c82f7601f9a488cac301f8fa0d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        is_up \u003d abs(elapsed) \u003c\u003d SERVICE_DOWN_TIME"},{"line_number":77,"context_line":"        if not is_up and ENABLE_LOGGING:"},{"line_number":78,"context_line":"            # as this is performance critical code, don\u0027t log in happy path"},{"line_number":79,"context_line":"            LOG.debug(\"DB_Driver.is_up last_heartbeat \u003d %(lhb)s \""},{"line_number":80,"context_line":"                      \" elapsed \u003d %(el)s\","},{"line_number":81,"context_line":"                      {\u0027lhb\u0027: str(last_heartbeat), \u0027el\u0027: str(elapsed)})"},{"line_number":82,"context_line":"        return is_up"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2FiHI%3D","line":79,"updated":"2014-02-12 15:05:49.000000000","message":"What about update message to reflect that service is not up?","commit_id":"489ea7524b2f958a9c6ef1acf2be71fbb38f1798"}]}