)]}'
{"id":"openstack%2Fnova~696154","triplet_id":"openstack%2Fnova~stable%2Fqueens~Ieb59de10c63bb067f92ec054535766cdd722dae2","project":"openstack/nova","branch":"stable/queens","topic":"bug/1838392","hashtags":[],"change_id":"Ieb59de10c63bb067f92ec054535766cdd722dae2","subject":"compute: Take an instance.uuid lock when rebooting","status":"MERGED","created":"2019-11-26 18:16:47.000000000","updated":"2019-12-07 20:00:27.000000000","submitted":"2019-12-07 20:00:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"696154-1575748827989-7198a097","meta_rev_id":"64f11342e8c0d15aa6326a3d5eb93b549c4241d4","_number":696154,"virtual_id_number":696154,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-11-26 19:32:35.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-11-26 21:19:46.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-11-26 18:27:15.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-07 20:00:27.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-07 17:57:32.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-12-07 17:57:32.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-26 18:27:15.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2019-11-26 19:32:35.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-11-26 21:19:46.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-07 17:57:32.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-12-07 20:00:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"576c4e255dc1319c410727ec134cf440cc7d5191","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-11-26 18:16:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"89b806adee6a94d9e50fb3a43389195432832965","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-11-26 18:27:15.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/54/696154/1/check/pmem-tempest-plugin-filtered/adf1742/ : POST_FAILURE in 5m 26s","accounts_in_message":[],"_revision_number":1},{"id":"dcd97cbeb972bb9c0ba41d7dda037545b9fe19e6","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-11-26 19:32:35.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/696154/1 : FAILURE in 1h 14m 52s","accounts_in_message":[],"_revision_number":1},{"id":"5f7b419ccba77323af36027857ff8d3eebd7821b","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-11-26 21:19:46.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/54/696154/1/check/tempest-dsvm-full-xenial/8dc51fd/ : SUCCESS in 2h 27m 50s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/54/696154/1/check/tempest-dsvm-full-xenial-py3/2dc0777/ : FAILURE in 2h 39m 16s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/54/696154/1/check/grenade-dsvm-xenial/3d50e4d/ : FAILURE in 2h 55m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"58e2a0d0403888436eb0e957a87942c4a120c373","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-26 21:25:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8efe09218c3a494c9b3c4f8018b102e1 : SUCCESS in 10m 19s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/753106a8616c47c1930667fdca83af4b : SUCCESS in 12m 22s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/fa89467a71d349968a99114e8ca656d5 : SUCCESS in 15m 04s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/40c34f74d4be4a1a928507b5746c0384 : SUCCESS in 7m 03s\n- tempest-full https://zuul.opendev.org/t/openstack/build/af1bbaad44d54601b3e22d3f110b4578 : SUCCESS in 1h 28m 46s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/078c796d0ddc492e83fb3fe05015569c : SUCCESS in 51m 36s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/77bbb713ac5f40e197f9603f500d2255 : SUCCESS in 1h 10m 40s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/3a3c86e46a674b22aa49a2944d0c3129 : SUCCESS in 46m 22s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/a42a3c3b67cc4e9d8233265109e76ac3 : SUCCESS in 52m 57s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/4f951bab43724df7ad4a33b165545b35 : SUCCESS in 1h 06m 36s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/16dcf7d3f7cc4094a47d534ffee71519 : SUCCESS in 39m 47s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/76e0aed6cfed402089c941e4c3f9b1d5 : SUCCESS in 54m 27s\n- nova-next https://zuul.opendev.org/t/openstack/build/11714cc37dc64a64b23269dba23d066a : SUCCESS in 1h 29m 58s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/2caeee3d802f4a50bcca58f88e6a3f58 : SUCCESS in 2h 10m 32s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/b15600b604cf47ea97010d86f3257028 : SUCCESS in 18m 37s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/fb28ffb0659244ebad9238240fd41c55 : SUCCESS in 22m 24s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/85af54b1ce3447968e7039b3891c52e6 : SUCCESS in 1h 09m 39s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/09bd7eb2888f4cbda6f87755c9789932 : SUCCESS in 57m 39s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/32167fd184534b94a9fe75741c77f248 : SUCCESS in 1h 43m 52s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0184734bdeb7087011620562fb77d532cb1f3288","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-12-05 17:03:50.000000000","message":"Topic set to bug/1838392","accounts_in_message":[],"_revision_number":1},{"id":"edca25e4cb4a6537db53f18d4fdcf1ca6ec18222","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-12-07 17:57:32.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport from a stable core, lgtm.","accounts_in_message":[],"_revision_number":1},{"id":"dccaa90c2de0ab3c30b8cc8ccb8c0e291011a0bf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-07 18:00:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0145f297cebec8e2560ea0626bfc09ccb3c5ee5a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-07 20:00:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"64f11342e8c0d15aa6326a3d5eb93b549c4241d4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-07 20:00:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e0903af38f69488bb2652d8bc60b9fde : SUCCESS in 9m 16s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4e2d37ee468f44c590006daf6b36699d : SUCCESS in 13m 46s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/50488919804841acbbf717d98bd0a6b4 : SUCCESS in 12m 40s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/fa1c1b8077de48539a7d2abe3da370b1 : SUCCESS in 6m 13s\n- tempest-full https://zuul.opendev.org/t/openstack/build/c99f160383b94497a448e315f83b60e0 : SUCCESS in 1h 33m 43s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/81c1bf37adfa45298c8c1a5dee43cd21 : SUCCESS in 54m 11s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/07264e62f0614058a728820cd3c1b23a : SUCCESS in 1h 16m 48s\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/8ae00d8e38b54614b1429843a816a3a8 : SUCCESS in 46m 41s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/cc1f4b5fcb504ab09e68e2add6a14382 : SUCCESS in 44m 23s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/19f755f0f3da4199b62a7165f33501a6 : SUCCESS in 58m 31s\n- nova-next https://zuul.opendev.org/t/openstack/build/2ddf347c26d64fbbb48a74edfa50c3fd : SUCCESS in 1h 14m 29s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/22a68e07a76948a781998d9b8371f4c8 : SUCCESS in 1h 53m 28s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/306a329426454fc3956edb983111ae04 : SUCCESS in 26m 00s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/b7fffa0619764fc1a0597a0956a9500a : SUCCESS in 17m 26s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"16fb8ac3f4c2fe94ae83d65fbcf6f49665a0dd60","revisions":{"16fb8ac3f4c2fe94ae83d65fbcf6f49665a0dd60":{"kind":"REWORK","_number":1,"created":"2019-11-26 18:16:47.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/54/696154/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/696154/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/696154/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/696154/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/696154/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/696154/1"}}},"commit":{"parents":[{"commit":"4e9f85205697dfcc01e8cbccafa79eea45f34212","subject":"Don\u0027t delete compute node, when deleting service other than nova-compute","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4e9f85205697dfcc01e8cbccafa79eea45f34212"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2019-07-29 15:25:45.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2019-11-26 18:16:33.000000000","tz":0},"subject":"compute: Take an instance.uuid lock when rebooting","message":"compute: Take an instance.uuid lock when rebooting\n\nPreviously simultaneous requests to reboot and delete an instance could\nrace as only the latter took a lock against the uuid of the instance.\n\nWith the Libvirt driver this race could potentially result in attempts\nbeing made to reconnect previously disconnected volumes on the host.\nDepending on the volume backend being used this could then result in\nstale block devices point to unmapped volumes being left on the host\nthat in turn could cause failures later on when connecting newly mapped\nvolumes.\n\nThis change avoids this race by ensuring any request to reboot an\ninstance takes an instance.uuid lock within the compute manager,\nserialising requests to reboot and then delete the instance.\n\nCloses-Bug: #1838392\nChange-Id: Ieb59de10c63bb067f92ec054535766cdd722dae2\n(cherry picked from commit 9ad54f3dacbd372271f441baea5380f913072dde)\n(cherry picked from commit 939cd9b177db8f12952e72145a5c00a0574959eb)\n(cherry picked from commit 304d3f62a4e3bdbaab6fe7dd665174bc5b696d08)\n(cherry picked from commit 7d14b6a5170821c65e55d7b39ccf4419a81640f8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/16fb8ac3f4c2fe94ae83d65fbcf6f49665a0dd60"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/16fb8ac3f4c2fe94ae83d65fbcf6f49665a0dd60"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}