)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f7dc7a1394027417a2c37d8c90ad8d00d5443ce1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"cannot compute baseline CPU of s390x architecture"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"https://www.libvirt.org/news.html has the info"},{"line_number":18,"context_line":"v5.9.0 has Improvements part indicated the compare was added at 5.9"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"so the workaround is to avoid the check and let the migration proceed."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_03672526","line":18,"updated":"2020-01-08 00:33:37.000000000","message":"Direct link to the 5.9.0 section: https://www.libvirt.org/news.html#v5.9.0","commit_id":"011cce6adb30c50737b45ec02e161fd71ab5b3e3"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cc6d0cb7bf0521ccbb701101a1170c0c1eabd55c","unresolved":false,"context_lines":[{"line_number":8262,"context_line":"        # s390x doesn\u0027t support cpu model in host info, so compare"},{"line_number":8263,"context_line":"        # cpu info will raise an error anyway, thus have to avoid check"},{"line_number":8264,"context_line":"        # see bug 1854126 for more info"},{"line_number":8265,"context_line":"        if cpu.arch \u003d\u003d \"s390x\" or cpu.arch \u003d\u003d \"s390\":"},{"line_number":8266,"context_line":"            return"},{"line_number":8267,"context_line":""},{"line_number":8268,"context_line":"        u \u003d (\"http://libvirt.org/html/libvirt-libvirt-host.html#\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8ff66b5d","line":8265,"updated":"2019-11-29 14:59:53.000000000","message":"We need a unit test for this. Also, surely we have constants somewhere for s390 and s390x? Can you use them if we do? Don\u0027t worry about it if not","commit_id":"c9ce729fcb0ccc54bbcac05a0de324855682d309"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9caf522fbcea782d21a4d4a855fd8c25390c4f84","unresolved":false,"context_lines":[{"line_number":8260,"context_line":"        else:"},{"line_number":8261,"context_line":"            cpu \u003d self._vcpu_model_to_cpu_config(guest_cpu)"},{"line_number":8262,"context_line":""},{"line_number":8263,"context_line":"        # s390x doesn\u0027t support cpu model in host info, so compare"},{"line_number":8264,"context_line":"        # cpu info will raise an error anyway, thus have to avoid check"},{"line_number":8265,"context_line":"        # see bug 1854126 for more info"},{"line_number":8266,"context_line":"        if cpu.arch \u003d\u003d arch.S390X or cpu.arch \u003d\u003d arch.S390:"},{"line_number":8267,"context_line":"            return"},{"line_number":8268,"context_line":""},{"line_number":8269,"context_line":"        u \u003d (\"http://libvirt.org/html/libvirt-libvirt-host.html#\""},{"line_number":8270,"context_line":"             \"virCPUCompareResult\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_f38c2c36","line":8267,"range":{"start_line":8263,"start_character":0,"end_line":8267,"end_character":18},"updated":"2019-12-09 17:44:29.000000000","message":"But it does - you just need version 5.9.0, as you commented in the commit message. Could you modify this to include a version check? If we don\u0027t have the correct version and are using one of these architectures then we should skip. Otherwise, we shouldn\u0027t.","commit_id":"c30389a514400cfba74d44c05fdb6d9d75a04207"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a0ae12353eae18138ded94c2c8cfd82e4b071184","unresolved":false,"context_lines":[{"line_number":8264,"context_line":"        # cpu info will raise an error anyway, thus have to avoid check"},{"line_number":8265,"context_line":"        # see bug 1854126 for more info"},{"line_number":8266,"context_line":"        min_libvirt_version \u003d (5, 9, 0)"},{"line_number":8267,"context_line":"        if (cpu.arch \u003d\u003d arch.S390X or cpu.arch \u003d\u003d arch.S390) and"},{"line_number":8268,"context_line":"            not self._host.has_min_version(min_libvirt_version):"},{"line_number":8269,"context_line":"            LOG.debug(\"on s390x platform, the min libvirt version support \""},{"line_number":8270,"context_line":"                      \"cpu model compare is \", min_libvirt_version)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_77a32fb2","line":8267,"range":{"start_line":8267,"start_character":12,"end_line":8267,"end_character":59},"updated":"2019-12-11 02:58:22.000000000","message":"You could simplify this a bit by\n\n if cpu.arch in (arch.S390X, arch.S390) and","commit_id":"0b8bd8e6ec6088e7d0d742fae94b43695ae2a5ca"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"eab0f8944c3135f5bbc2e480af2092e31dae3ba0","unresolved":false,"context_lines":[{"line_number":8264,"context_line":"        # cpu info will raise an error anyway, thus have to avoid check"},{"line_number":8265,"context_line":"        # see bug 1854126 for more info"},{"line_number":8266,"context_line":"        min_libvirt_version \u003d (5, 9, 0)"},{"line_number":8267,"context_line":"        if (cpu.arch \u003d\u003d arch.S390X or cpu.arch \u003d\u003d arch.S390) and"},{"line_number":8268,"context_line":"            not self._host.has_min_version(min_libvirt_version):"},{"line_number":8269,"context_line":"            LOG.debug(\"on s390x platform, the min libvirt version support \""},{"line_number":8270,"context_line":"                      \"cpu model compare is \", min_libvirt_version)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_327042da","line":8267,"range":{"start_line":8267,"start_character":12,"end_line":8267,"end_character":59},"in_reply_to":"3fa7e38b_77a32fb2","updated":"2019-12-13 00:26:58.000000000","message":"Done","commit_id":"0b8bd8e6ec6088e7d0d742fae94b43695ae2a5ca"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a0ae12353eae18138ded94c2c8cfd82e4b071184","unresolved":false,"context_lines":[{"line_number":8265,"context_line":"        # see bug 1854126 for more info"},{"line_number":8266,"context_line":"        min_libvirt_version \u003d (5, 9, 0)"},{"line_number":8267,"context_line":"        if (cpu.arch \u003d\u003d arch.S390X or cpu.arch \u003d\u003d arch.S390) and"},{"line_number":8268,"context_line":"            not self._host.has_min_version(min_libvirt_version):"},{"line_number":8269,"context_line":"            LOG.debug(\"on s390x platform, the min libvirt version support \""},{"line_number":8270,"context_line":"                      \"cpu model compare is \", min_libvirt_version)"},{"line_number":8271,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_d793035b","line":8268,"updated":"2019-12-11 02:58:22.000000000","message":"And I think this line should be indented one more time to not align with L8269. Also, I think you\u0027ll need another set of parentheses around L8267-L8268 for line continuation.","commit_id":"0b8bd8e6ec6088e7d0d742fae94b43695ae2a5ca"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"eab0f8944c3135f5bbc2e480af2092e31dae3ba0","unresolved":false,"context_lines":[{"line_number":8265,"context_line":"        # see bug 1854126 for more info"},{"line_number":8266,"context_line":"        min_libvirt_version \u003d (5, 9, 0)"},{"line_number":8267,"context_line":"        if (cpu.arch \u003d\u003d arch.S390X or cpu.arch \u003d\u003d arch.S390) and"},{"line_number":8268,"context_line":"            not self._host.has_min_version(min_libvirt_version):"},{"line_number":8269,"context_line":"            LOG.debug(\"on s390x platform, the min libvirt version support \""},{"line_number":8270,"context_line":"                      \"cpu model compare is \", min_libvirt_version)"},{"line_number":8271,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_127506cc","line":8268,"in_reply_to":"3fa7e38b_d793035b","updated":"2019-12-13 00:26:58.000000000","message":"you are right, I will update it, thanks","commit_id":"0b8bd8e6ec6088e7d0d742fae94b43695ae2a5ca"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9df82fc0850877ae01f47f380741d0e9608c47ba","unresolved":false,"context_lines":[{"line_number":8264,"context_line":"        # cpu info will raise an error anyway, thus have to avoid check"},{"line_number":8265,"context_line":"        # see bug 1854126 for more info"},{"line_number":8266,"context_line":"        min_libvirt_version \u003d (5, 9, 0)"},{"line_number":8267,"context_line":"        if cpu.arch in (arch.S390X, arch.S390) and"},{"line_number":8268,"context_line":"            not self._host.has_min_version(min_libvirt_version):"},{"line_number":8269,"context_line":"                LOG.debug(\"on s390x platform, the min libvirt version \""},{"line_number":8270,"context_line":"                          \"support cpu model compare is \", min_libvirt_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_95b6c0db","line":8267,"updated":"2019-12-13 01:16:10.000000000","message":"You need to put this whole if statement inside parentheses to pass pep8 for continuing a line:\n\n if (cpu.arch in (arch.S390X, arch.S390) and\n         not self._host.has_min_version(min_libvirt_version)):","commit_id":"bcfbad5d8a2f3234f93cfc437b4c498950e6a56f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"03a96ea968e3fd457348e0bcf118553228389772","unresolved":false,"context_lines":[{"line_number":8264,"context_line":"        # cpu info will raise an error anyway, thus have to avoid check"},{"line_number":8265,"context_line":"        # see bug 1854126 for more info"},{"line_number":8266,"context_line":"        min_libvirt_version \u003d (5, 9, 0)"},{"line_number":8267,"context_line":"        if cpu.arch in (arch.S390X, arch.S390) and"},{"line_number":8268,"context_line":"            not self._host.has_min_version(min_libvirt_version):"},{"line_number":8269,"context_line":"                LOG.debug(\"on s390x platform, the min libvirt version \""},{"line_number":8270,"context_line":"                          \"support cpu model compare is \", min_libvirt_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_264fa4be","line":8267,"in_reply_to":"3fa7e38b_95b6c0db","updated":"2019-12-13 08:26:46.000000000","message":"Done","commit_id":"bcfbad5d8a2f3234f93cfc437b4c498950e6a56f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9df82fc0850877ae01f47f380741d0e9608c47ba","unresolved":false,"context_lines":[{"line_number":8265,"context_line":"        # see bug 1854126 for more info"},{"line_number":8266,"context_line":"        min_libvirt_version \u003d (5, 9, 0)"},{"line_number":8267,"context_line":"        if cpu.arch in (arch.S390X, arch.S390) and"},{"line_number":8268,"context_line":"            not self._host.has_min_version(min_libvirt_version):"},{"line_number":8269,"context_line":"                LOG.debug(\"on s390x platform, the min libvirt version \""},{"line_number":8270,"context_line":"                          \"support cpu model compare is \", min_libvirt_version)"},{"line_number":8271,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_557e081b","line":8268,"updated":"2019-12-13 01:16:10.000000000","message":"This line needs to be indented once more to pass pep8.","commit_id":"bcfbad5d8a2f3234f93cfc437b4c498950e6a56f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"03a96ea968e3fd457348e0bcf118553228389772","unresolved":false,"context_lines":[{"line_number":8265,"context_line":"        # see bug 1854126 for more info"},{"line_number":8266,"context_line":"        min_libvirt_version \u003d (5, 9, 0)"},{"line_number":8267,"context_line":"        if cpu.arch in (arch.S390X, arch.S390) and"},{"line_number":8268,"context_line":"            not self._host.has_min_version(min_libvirt_version):"},{"line_number":8269,"context_line":"                LOG.debug(\"on s390x platform, the min libvirt version \""},{"line_number":8270,"context_line":"                          \"support cpu model compare is \", min_libvirt_version)"},{"line_number":8271,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_46566060","line":8268,"in_reply_to":"3fa7e38b_557e081b","updated":"2019-12-13 08:26:46.000000000","message":"thanks, will do that","commit_id":"bcfbad5d8a2f3234f93cfc437b4c498950e6a56f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9df82fc0850877ae01f47f380741d0e9608c47ba","unresolved":false,"context_lines":[{"line_number":8268,"context_line":"            not self._host.has_min_version(min_libvirt_version):"},{"line_number":8269,"context_line":"                LOG.debug(\"on s390x platform, the min libvirt version \""},{"line_number":8270,"context_line":"                          \"support cpu model compare is \", min_libvirt_version)"},{"line_number":8271,"context_line":"                return"},{"line_number":8272,"context_line":""},{"line_number":8273,"context_line":"        u \u003d (\"http://libvirt.org/html/libvirt-libvirt-host.html#\""},{"line_number":8274,"context_line":"             \"virCPUCompareResult\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_7581c4f9","line":8271,"updated":"2019-12-13 01:16:10.000000000","message":"These 3 lines need to be unindented once to pass pep8.","commit_id":"bcfbad5d8a2f3234f93cfc437b4c498950e6a56f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"03a96ea968e3fd457348e0bcf118553228389772","unresolved":false,"context_lines":[{"line_number":8268,"context_line":"            not self._host.has_min_version(min_libvirt_version):"},{"line_number":8269,"context_line":"                LOG.debug(\"on s390x platform, the min libvirt version \""},{"line_number":8270,"context_line":"                          \"support cpu model compare is \", min_libvirt_version)"},{"line_number":8271,"context_line":"                return"},{"line_number":8272,"context_line":""},{"line_number":8273,"context_line":"        u \u003d (\"http://libvirt.org/html/libvirt-libvirt-host.html#\""},{"line_number":8274,"context_line":"             \"virCPUCompareResult\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_0654e852","line":8271,"in_reply_to":"3fa7e38b_7581c4f9","updated":"2019-12-13 08:26:46.000000000","message":"Done","commit_id":"bcfbad5d8a2f3234f93cfc437b4c498950e6a56f"}]}