)]}'
{"nova/tests/fixtures.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1955880067d700ba8f176ec684e870b7a1019687","unresolved":false,"context_lines":[{"line_number":1721,"context_line":"    def delete_port_binding(self, context, client, port_id, host):"},{"line_number":1722,"context_line":"        failure \u003d self._get_failure_response_if_port_or_binding_not_exists("},{"line_number":1723,"context_line":"            port_id, host)"},{"line_number":1724,"context_line":"        if failure:"},{"line_number":1725,"context_line":"            return failure"},{"line_number":1726,"context_line":""},{"line_number":1727,"context_line":"        del self._port_bindings[port_id][host]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_a5756799","line":1724,"updated":"2019-12-03 10:50:21.000000000","message":"Jeez I lost half a day on this mistake. FakeResponse evaluates to False if it contains a 4xx or 5xx status code. I hate this.","commit_id":"760e23037914e071615422ed71c6809002417a15"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"65bd31e11fa0caa2cb622aefdaa0061b5132db3d","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            self.stub_out("},{"line_number":245,"context_line":"                \u0027nova.network.neutronv2.api.API.get_instance_nw_info\u0027,"},{"line_number":246,"context_line":"                fake_get_nw_info)"},{"line_number":247,"context_line":"            self.stub_out("},{"line_number":248,"context_line":"                \u0027nova.network.neutronv2.api.API.migrate_instance_start\u0027,"},{"line_number":249,"context_line":"                lambda *args, **kwargs: None)"},{"line_number":250,"context_line":"            self.useFixture(fixtures.NeutronFixture(self))"},{"line_number":251,"context_line":"        else:"},{"line_number":252,"context_line":"            self.stub_out(\u0027nova.network.api.API.get_instance_nw_info\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e194d338","line":249,"range":{"start_line":247,"start_character":0,"end_line":249,"end_character":45},"updated":"2019-11-29 15:38:12.000000000","message":"Do we want a TODO here, I wonder? Or is this okay long-term? Maybe the latter, since these are supposed to be unit tests after all :)","commit_id":"772f1825d0f88e3aa718618b2c25bfb64756256b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"05ba2470aca360ccb2a74e9ab5644b4bcaceace3","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            self.stub_out("},{"line_number":245,"context_line":"                \u0027nova.network.neutronv2.api.API.get_instance_nw_info\u0027,"},{"line_number":246,"context_line":"                fake_get_nw_info)"},{"line_number":247,"context_line":"            self.stub_out("},{"line_number":248,"context_line":"                \u0027nova.network.neutronv2.api.API.migrate_instance_start\u0027,"},{"line_number":249,"context_line":"                lambda *args, **kwargs: None)"},{"line_number":250,"context_line":"            self.useFixture(fixtures.NeutronFixture(self))"},{"line_number":251,"context_line":"        else:"},{"line_number":252,"context_line":"            self.stub_out(\u0027nova.network.api.API.get_instance_nw_info\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_0cb03440","line":249,"range":{"start_line":247,"start_character":0,"end_line":249,"end_character":45},"in_reply_to":"3fa7e38b_e194d338","updated":"2019-12-02 16:19:28.000000000","message":"These are unit test. Stubbing is totally OK for me here.","commit_id":"772f1825d0f88e3aa718618b2c25bfb64756256b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84f80e21913917c997bb99fedcc95d3d004a5b9c","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                \u0027nova.network.neutronv2.api.API.get_instance_nw_info\u0027,"},{"line_number":246,"context_line":"                fake_get_nw_info)"},{"line_number":247,"context_line":"            self.stub_out("},{"line_number":248,"context_line":"                \u0027nova.network.neutronv2.api.API.migrate_instance_start\u0027,"},{"line_number":249,"context_line":"                lambda *args, **kwargs: None)"},{"line_number":250,"context_line":"            self.useFixture(fixtures.NeutronFixture(self))"},{"line_number":251,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_dcca786c","line":248,"updated":"2019-12-06 20:55:22.000000000","message":"OK this is because migrate_instance_start relies on instance.get_network_info() which we don\u0027t have stubbed, and if we did we\u0027d probably just have it return None because looking at fake_get_nw_info above these tests aren\u0027t trying to rely on the nw info cache.","commit_id":"756d24424e1b924e45b5553e24b1d558b6a3929d"}]}