)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"28ae5e8f91fc57e8d1ae919909f2ffce229c97a1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"- Selecting hosts with specific CPU model flags (libvirt only)."},{"line_number":30,"context_line":"  Theoretically your bandwidth request could have required certain CPU"},{"line_number":31,"context_line":"  flag-based traits and they would have been ignored."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: Ibb0ee191c76df0d34c83daf97f462380e2741c94"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_f1303dec","line":32,"updated":"2019-11-27 16:56:49.000000000","message":"Today qos ports requires two types of traits CUSTOM_VNIC_TYPE_XXX and CUSTOM_PHYSNET_XXX. For isolate aggregates feature I might see a slight chance that somebody wants to isolate host based on these traits. But I don\u0027t see any way that the cpu flag collection can be affected.","commit_id":"d8115d44d685c51c90e37e53c4fcd211b35c3496"}],"nova/scheduler/utils.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dc7b5f8156f617742414ff99741d298a09b697d4","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        self._translate_vpmems_request(request_spec.flavor)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.strip_zeros()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _process_requested_resources(self, request_spec):"},{"line_number":157,"context_line":"        requested_resources \u003d (request_spec.requested_resources"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_090a7b1f","line":154,"updated":"2019-11-29 11:04:18.000000000","message":"The reason of the test failure is that strip_zeros wasn\u0027t run for the request_spec.requested_resources before this change but now it runs on those groups as well. \n\nThe test that fails creates empty groups that is simply dropped by the strip_zeros() call. Then when the get_request_group is called with non existing group id a new group is created and therefore the id check fails.\n\nI suggest to add some resources to the rg1 and rg2 in the failing test case and then the id check should pass.","commit_id":"d8115d44d685c51c90e37e53c4fcd211b35c3496"}],"nova/tests/unit/scheduler/test_utils.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dc7b5f8156f617742414ff99741d298a09b697d4","unresolved":false,"context_lines":[{"line_number":675,"context_line":"                root_gb\u003d10,"},{"line_number":676,"context_line":"                ephemeral_gb\u003d5,"},{"line_number":677,"context_line":"                swap\u003d0)"},{"line_number":678,"context_line":"        rg1 \u003d objects.RequestGroup()"},{"line_number":679,"context_line":"        rg2 \u003d objects.RequestGroup()"},{"line_number":680,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dflavor,"},{"line_number":681,"context_line":"                                      requested_resources\u003d[rg1, rg2])"},{"line_number":682,"context_line":"        req \u003d utils.resources_from_request_spec("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c90b0320","line":679,"range":{"start_line":678,"start_character":1,"end_line":679,"end_character":36},"updated":"2019-11-29 11:04:18.000000000","message":"Add some resource here to avoid strip_zeros() to drop the groups from the ResourceRequest.","commit_id":"d8115d44d685c51c90e37e53c4fcd211b35c3496"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f60fd481955b4b44392b0ff8ccc96641671cce95","unresolved":false,"context_lines":[{"line_number":675,"context_line":"                root_gb\u003d10,"},{"line_number":676,"context_line":"                ephemeral_gb\u003d5,"},{"line_number":677,"context_line":"                swap\u003d0)"},{"line_number":678,"context_line":"        rg1 \u003d objects.RequestGroup()"},{"line_number":679,"context_line":"        rg2 \u003d objects.RequestGroup()"},{"line_number":680,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dflavor,"},{"line_number":681,"context_line":"                                      requested_resources\u003d[rg1, rg2])"},{"line_number":682,"context_line":"        req \u003d utils.resources_from_request_spec("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_21917c54","line":679,"range":{"start_line":678,"start_character":1,"end_line":679,"end_character":36},"in_reply_to":"3fa7e38b_c90b0320","updated":"2019-12-02 13:28:38.000000000","message":"Thanks gibi, done","commit_id":"d8115d44d685c51c90e37e53c4fcd211b35c3496"}]}