)]}'
{"id":"openstack%2Fnova~696469","triplet_id":"openstack%2Fnova~stable%2Fqueens~I1787f9717618d0837208844e8065840d30341cf7","project":"openstack/nova","branch":"stable/queens","topic":"bug/1835926","hashtags":[],"change_id":"I1787f9717618d0837208844e8065840d30341cf7","subject":"Do not update root_device_name during guest config","status":"MERGED","created":"2019-11-28 08:13:52.000000000","updated":"2019-12-12 00:34:08.000000000","submitted":"2019-12-11 17:16:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"696469-1576084591217-7edb6769","meta_rev_id":"d22967cfe8b37cb806ba3fb95a03eb788628f0d7","_number":696469,"virtual_id_number":696469,"owner":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-12-10 22:31:56.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-12-10 16:51:07.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-11 17:16:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2019-12-11 09:41:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-11 13:50:14.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-12-11 13:50:14.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-28 11:11:45.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-10 16:51:07.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2019-12-10 22:31:56.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-12-11 09:41:12.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2019-12-11 13:50:14.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-12-11 17:16:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"059fb237a721a59e25fcac70ae7c6bde344b49cd","author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"date":"2019-11-28 08:13:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"78f78595e2bb54ab3a42810e44d35d1711a46359","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-11-28 08:20:35.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/69/696469/1/check/pmem-tempest-plugin-filtered/a6b337b/ : POST_FAILURE in 5m 24s","accounts_in_message":[],"_revision_number":1},{"id":"368b9484f740c5609f0fdbf1b65e560899e493d2","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-11-28 09:27:48.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/696469/1 : FAILURE in 1h 13m 02s","accounts_in_message":[],"_revision_number":1},{"id":"f4c9d0266965cbde738c370363847637ad0e243b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-28 10:22:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/75cb07e7b31f4603bfb2ccd9c810776b : SUCCESS in 9m 53s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/705200d9b0624ce69e8e9eca62918634 : SUCCESS in 13m 46s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/58bbd5734c8f410d869bc442851a6223 : SUCCESS in 14m 41s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/caa76a1bbbf7436bba0d13695e8c0280 : SUCCESS in 7m 04s\n- tempest-full https://zuul.opendev.org/t/openstack/build/3dd9943dcd234e0fa5af236d2306553b : SUCCESS in 1h 23m 06s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/09338594ce1b4f56b176c05e5e844110 : SUCCESS in 54m 57s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b9cefc8884dc46818f06e4dfd845528a : SUCCESS in 1h 17m 28s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/cc6ecb40fcc14a5f9b1a063defd2a8f3 : SUCCESS in 49m 33s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/24b3a31189a042939e27561916cf6827 : SUCCESS in 48m 04s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/cc541b3c392542e98ddd507d1e383ee9 : SUCCESS in 59m 25s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/8bc0239c97b249d3af0c418b239b3921 : SUCCESS in 45m 41s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/6dd7ad7736884bc6ad41b922ccdb32d2 : SUCCESS in 1h 09m 15s\n- nova-next https://zuul.opendev.org/t/openstack/build/7885171fc4fe423cb268d87330690dcb : SUCCESS in 1h 16m 45s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/c8eabebcd0f84014a3efcabcb09377d1 : SUCCESS in 1h 59m 35s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/14bad28aa9794bc9a52b09652992e8e4 : SUCCESS in 20m 52s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/1c2ea480fea141b5a2370eba65625114 : SUCCESS in 23m 07s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/ad1ef9c49e3a4f0ebe15d0dd86914f1d : SUCCESS in 1h 03m 59s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/eb0c82969622428aa9a169a6373fe892 : SUCCESS in 1h 00m 36s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/3166728d36c14640bc47814f462825c7 : SUCCESS in 1h 38m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9f12fec934f510b52d53f9d2307d040e48085583","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-11-28 11:11:45.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/69/696469/1/check/tempest-dsvm-full-xenial/ec66aac/ : FAILURE in 2h 31m 01s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/69/696469/1/check/tempest-dsvm-full-xenial-py3/acd5bdd/ : FAILURE in 2h 32m 53s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/69/696469/1/check/grenade-dsvm-xenial/b98d8b8/ : FAILURE in 2h 55m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"85fdb5375824f305fe41fbed415871b2db5c16da","author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"date":"2019-12-10 15:44:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"89f2b391e4357a17872a8b4ab44d64e75108578d","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-12-10 15:46:34.000000000","message":"Patch Set 2:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"368f412f7876c4bba43851f2a87a7be101f56b2c","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2019-12-10 16:22:41.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nThe patch looks good, but there is a small issue with the commit message. Could you please update that?","accounts_in_message":[],"_revision_number":2},{"id":"b26471c38d6df07ce09861a9c0c80561b25f32b2","author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"date":"2019-12-10 16:38:53.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"8472ba4a9be0d0f2027d357ae2661c3d99454c61","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-12-10 16:40:33.000000000","message":"Patch Set 3:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"3c3ae573fea4e466a8beede9a8f4c5c1015b8520","author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"date":"2019-12-10 16:49:25.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"09d65de040c98b1f78f2b36aa6ee4fb897da824b","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-12-10 16:51:07.000000000","message":"Patch Set 4:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":4},{"id":"b900246fce72e7533cbd1737f81c3b3506af7ace","author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"date":"2019-12-10 16:54:47.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9485166cd8efa27a50d1bbedb8fe2bc1c2624af2","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-12-10 22:31:56.000000000","message":"Patch Set 4:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/696469/4 : FAILURE in 1h 09m 27s","accounts_in_message":[],"_revision_number":4},{"id":"b9bf075d43cddac1bd94549bb73f75a7b4aef555","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-10 23:40:12.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/22389e7e97884f1ea8dde53ec7fbd70a : SUCCESS in 10m 25s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/25eb7ac0a46e4084aba973a982354912 : SUCCESS in 21m 02s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/ef6022034067464285fdc6f9b9722e47 : SUCCESS in 19m 41s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/cd3eaf503798419f85fbbd1efac48c22 : SUCCESS in 6m 14s\n- tempest-full https://zuul.opendev.org/t/openstack/build/7d895795290042ed81ab9dc13a70b374 : SUCCESS in 1h 22m 11s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/5ba93d78830d42a59d66fd91037d7db0 : SUCCESS in 56m 26s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4d3c7d668ed14f2d89d5534c58fa2531 : SUCCESS in 1h 21m 17s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/6dbeecf36f314fd2bf95c9b985bc9a76 : SUCCESS in 48m 54s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/b59f80abecf84700a04c2b3f3bae5a85 : SUCCESS in 48m 31s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/72ce3958d9f04515b47c364bccbbffcd : SUCCESS in 55m 38s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/e4f38798851f48c59f0dcfc3aaa8c5b1 : SUCCESS in 45m 34s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/998632d9cbe144a286939bffe9b5f2c0 : SUCCESS in 1h 01m 26s\n- nova-next https://zuul.opendev.org/t/openstack/build/eb3693284638429ca673e1aa34c2d495 : SUCCESS in 1h 19m 41s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/4effcc51dbb84e03903305d43040b67f : SUCCESS in 1h 55m 38s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/362a5649aa9a4701ac307db6472126b8 : SUCCESS in 19m 52s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/7b3f7891ccf349f59a70e1f690fb28ef : SUCCESS in 19m 23s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/405246405287498f9f69ebf52e24aad3 : SUCCESS in 1h 08m 30s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/1eff3c07c1e34e51b026337f394efcf7 : SUCCESS in 1h 01m 17s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/26c9aa4dc6e24b0683fd52298a11e999 : SUCCESS in 1h 44m 01s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"8727238f0263377180fae75ffa7013db2b8415ec","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2019-12-11 09:41:12.000000000","message":"Patch Set 4: Code-Review+2\n\nThe backport looks good and the conflict is noted. LGTM.","accounts_in_message":[],"_revision_number":4},{"id":"86e1f55dc89a3a2e2b9f57c1ac5409c4d32c3857","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2019-12-11 09:43:12.000000000","message":"Patch Set 4:\n\nThanks Alexandre for the update!","accounts_in_message":[],"_revision_number":4},{"id":"c581be5288de75adf45172e4ceec7412fc53138e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-12-11 13:50:14.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nlgtm, conflict is noted","accounts_in_message":[],"_revision_number":4},{"id":"6b10ea4ff6102949cb7cd099f80abb2a42526101","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-11 13:54:25.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"ebda839519c3aab1aa91b89e8125cc6eceee214f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-11 17:16:30.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4f97c9bfdd42462ca39707f4a110f3e0 : SUCCESS in 9m 34s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/b9e396d6458e49b092eb1cbb042b9f65 : SUCCESS in 12m 10s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/2d37c731cce645f4b9da6262e1494686 : SUCCESS in 15m 11s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/2e66df88c7f64cbb80842940beabe0c4 : SUCCESS in 6m 44s\n- tempest-full https://zuul.opendev.org/t/openstack/build/b082e42a0f6449508a912a8780bdd392 : SUCCESS in 1h 20m 55s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/c6c7de6f4928438a9d91f0edad8f609c : SUCCESS in 53m 23s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7778979dbaaa4299bbdd8503407e2ecb : SUCCESS in 1h 22m 53s\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/dded4725659947b99effc0b34d993aa9 : SUCCESS in 44m 15s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/d2e3fdd54b644213bb8961a891848c29 : SUCCESS in 42m 47s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/86fdc7645f0749988b6021d27083ef87 : SUCCESS in 55m 48s\n- nova-next https://zuul.opendev.org/t/openstack/build/da9ab6308d254060a80b3863647a194e : SUCCESS in 1h 07m 15s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/08bf765a925043f4b61c8fc060b07c56 : SUCCESS in 1h 56m 52s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/bb91e6de83924d03aba60b0f17cbf1a2 : SUCCESS in 17m 25s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/5218d8b4b76b425caceea9d3de3e160c : SUCCESS in 19m 26s","accounts_in_message":[],"_revision_number":4},{"id":"cf5762126d7b6a85b1c94c610c42935c7ab60a29","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-11 17:16:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"2bea78d7b1f3ced9b346277f5ec8b5e468c5dddf","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-12-12 00:34:08.000000000","message":"Patch Set 4:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/69/696469/4/check/tempest-dsvm-full-xenial/20ac75a/ : SUCCESS in 2h 44m 09s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/69/696469/4/check/tempest-dsvm-full-xenial-py3/9c4dab8/ : FAILURE in 2h 33m 15s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/69/696469/4/check/grenade-dsvm-xenial/aa6ff9b/ : FAILURE in 2h 55m 37s (non-voting)","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"4f4b5bd545b189ae1ef6e22c2fe7d08e4e9b402c","revisions":{"549d4b2b987cc9bb76397734d51c5605febe2b8e":{"kind":"REWORK","_number":1,"created":"2019-11-28 08:13:52.000000000","uploader":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"ref":"refs/changes/69/696469/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/69/696469/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/69/696469/1"}}},"commit":{"parents":[{"commit":"4e9f85205697dfcc01e8cbccafa79eea45f34212","subject":"Don\u0027t delete compute node, when deleting service other than nova-compute","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4e9f85205697dfcc01e8cbccafa79eea45f34212"}]}],"author":{"name":"Alexandre Arents","email":"alexandre.arents@corp.ovh.com","date":"2019-07-09 16:13:01.000000000","tz":0},"committer":{"name":"Alexandre Arents","email":"alexandre.arents@corp.ovh.com","date":"2019-11-28 08:00:54.000000000","tz":0},"subject":"Do not update root_device_name during guest config","message":"Do not update root_device_name during guest config\n\n_get_guest_config() is currently updating instance.root_device_name\nand called in many ways like:\n\n_hard_reboot(), rescue(), spawn(), resume(), finish_migration(),\nfinish_revert_migration()\n\nIt is an issue because root_device_name is initally set during instance\nbuild and should remain the same after:\n\nmanager.py: _do_build_and_run_instance()\n             ..\n               _default_block_device_names() \u003c-here\n               ..\n               driver.spawn()\n\nThis may lead to edge case, like in rescue where this value can be mistakenly\nupdated to reflect disk bus property of rescue image (hw_disk_bus).\nFurther more, a _get* method should not modify instance object.\n\nNote that test test_get_guest_config_bug_1118829 is removed because no more\nrelevant with current code.\n\nChange-Id: I1787f9717618d0837208844e8065840d30341cf7\nCloses-Bug: #1835926\n(cherry picked from commit 5e0ed5e7fee3c4c887263a0e9fa847c2dcc5cf3b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/549d4b2b987cc9bb76397734d51c5605febe2b8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/549d4b2b987cc9bb76397734d51c5605febe2b8e"}]},"branch":"refs/heads/stable/queens"},"4e0929d7bb272f9723d34b9de835a20b0e771cdb":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2019-12-10 15:44:53.000000000","uploader":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"ref":"refs/changes/69/696469/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/69/696469/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/69/696469/2"}}},"commit":{"parents":[{"commit":"203af2b6a955ec04293843f2462aa45c7208da3d","subject":"Merge \"compute: Take an instance.uuid lock when rebooting\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/203af2b6a955ec04293843f2462aa45c7208da3d"}]}],"author":{"name":"Alexandre Arents","email":"alexandre.arents@corp.ovh.com","date":"2019-07-09 16:13:01.000000000","tz":0},"committer":{"name":"Alexandre Arents","email":"alexandre.arents@corp.ovh.com","date":"2019-12-10 15:41:24.000000000","tz":0},"subject":"Do not update root_device_name during guest config","message":"Do not update root_device_name during guest config\n\n_get_guest_config() is currently updating instance.root_device_name\nand called in many ways like:\n\n_hard_reboot(), rescue(), spawn(), resume(), finish_migration(),\nfinish_revert_migration()\n\nIt is an issue because root_device_name is initally set during instance\nbuild and should remain the same after:\n\nmanager.py: _do_build_and_run_instance()\n             ..\n               _default_block_device_names() \u003c-here\n               ..\n               driver.spawn()\n\nThis may lead to edge case, like in rescue where this value can be mistakenly\nupdated to reflect disk bus property of rescue image (hw_disk_bus).\nFurther more, a _get* method should not modify instance object.\n\nNote that test test_get_guest_config_bug_1118829 is removed because no more\nrelevant with current code.\n\nChange-Id: I1787f9717618d0837208844e8065840d30341cf7\nCloses-Bug: #1835926\n(cherry picked from commit 5e0ed5e7fee3c4c887263a0e9fa847c2dcc5cf3b)\n(cherry picked from commit 5e858d0cbd672639318543201e251ed00324a9c2)\n(cherry picked from commit 9f9f8d330a50aec188e55ab8ae921db710e6cc83)\n(cherry picked from commit c075e3a76d07b8d8ccf201756810567ddf04db60)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4e0929d7bb272f9723d34b9de835a20b0e771cdb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4e0929d7bb272f9723d34b9de835a20b0e771cdb"}]},"branch":"refs/heads/stable/queens"},"bededb7b23b423f84eb43621ed0b76c0513959e6":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2019-12-10 16:38:53.000000000","uploader":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"ref":"refs/changes/69/696469/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/69/696469/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/69/696469/3"}}},"commit":{"parents":[{"commit":"203af2b6a955ec04293843f2462aa45c7208da3d","subject":"Merge \"compute: Take an instance.uuid lock when rebooting\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/203af2b6a955ec04293843f2462aa45c7208da3d"}]}],"author":{"name":"Alexandre Arents","email":"alexandre.arents@corp.ovh.com","date":"2019-07-09 16:13:01.000000000","tz":0},"committer":{"name":"Alexandre Arents","email":"alexandre.arents@corp.ovh.com","date":"2019-12-10 16:36:33.000000000","tz":0},"subject":"Do not update root_device_name during guest config","message":"Do not update root_device_name during guest config\n\n_get_guest_config() is currently updating instance.root_device_name\nand called in many ways like:\n\n_hard_reboot(), rescue(), spawn(), resume(), finish_migration(),\nfinish_revert_migration()\n\nIt is an issue because root_device_name is initally set during instance\nbuild and should remain the same after:\n\nmanager.py: _do_build_and_run_instance()\n             ..\n               _default_block_device_names() \u003c-here\n               ..\n               driver.spawn()\n\nThis may lead to edge case, like in rescue where this value can be mistakenly\nupdated to reflect disk bus property of rescue image (hw_disk_bus).\nFurther more, a _get* method should not modify instance object.\n\nNote that test test_get_guest_config_bug_1118829 is removed because no more\nrelevant with current code.\n\nConflicts:\n    nova/virt/libvirt/driver.py\nNOTE: conflict is due to small comment removal patch:\n    I08916cf57d50f766126a99a479d79a27a1bca36f\n\nChange-Id: I1787f9717618d0837208844e8065840d30341cf7\nCloses-Bug: #1835926\n(cherry picked from commit 5e0ed5e7fee3c4c887263a0e9fa847c2dcc5cf3b)\n(cherry picked from commit 5e858d0cbd672639318543201e251ed00324a9c2)\n(cherry picked from commit 9f9f8d330a50aec188e55ab8ae921db710e6cc83)\n(cherry picked from commit c075e3a76d07b8d8ccf201756810567ddf04db60)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bededb7b23b423f84eb43621ed0b76c0513959e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bededb7b23b423f84eb43621ed0b76c0513959e6"}]},"branch":"refs/heads/stable/queens"},"4f4b5bd545b189ae1ef6e22c2fe7d08e4e9b402c":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2019-12-10 16:49:25.000000000","uploader":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"ref":"refs/changes/69/696469/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/69/696469/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/696469/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/69/696469/4"}}},"commit":{"parents":[{"commit":"203af2b6a955ec04293843f2462aa45c7208da3d","subject":"Merge \"compute: Take an instance.uuid lock when rebooting\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/203af2b6a955ec04293843f2462aa45c7208da3d"}]}],"author":{"name":"Alexandre Arents","email":"alexandre.arents@corp.ovh.com","date":"2019-07-09 16:13:01.000000000","tz":0},"committer":{"name":"Alexandre Arents","email":"alexandre.arents@corp.ovh.com","date":"2019-12-10 16:43:59.000000000","tz":0},"subject":"Do not update root_device_name during guest config","message":"Do not update root_device_name during guest config\n\n_get_guest_config() is currently updating instance.root_device_name\nand called in many ways like:\n\n_hard_reboot(), rescue(), spawn(), resume(), finish_migration(),\nfinish_revert_migration()\n\nIt is an issue because root_device_name is initally set during instance\nbuild and should remain the same after:\n\nmanager.py: _do_build_and_run_instance()\n             ..\n               _default_block_device_names() \u003c-here\n               ..\n               driver.spawn()\n\nThis may lead to edge case, like in rescue where this value can be mistakenly\nupdated to reflect disk bus property of rescue image (hw_disk_bus).\nFurther more, a _get* method should not modify instance object.\n\nNote that test test_get_guest_config_bug_1118829 is removed because no more\nrelevant with current code.\n\nConflicts:\n\tnova/virt/libvirt/driver.py\n    NOTE: conflict is due to small comment removal patch:\n        I08916cf57d50f766126a99a479d79a27a1bca36f\n\nChange-Id: I1787f9717618d0837208844e8065840d30341cf7\nCloses-Bug: #1835926\n(cherry picked from commit 5e0ed5e7fee3c4c887263a0e9fa847c2dcc5cf3b)\n(cherry picked from commit 5e858d0cbd672639318543201e251ed00324a9c2)\n(cherry picked from commit 9f9f8d330a50aec188e55ab8ae921db710e6cc83)\n(cherry picked from commit c075e3a76d07b8d8ccf201756810567ddf04db60)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4f4b5bd545b189ae1ef6e22c2fe7d08e4e9b402c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4f4b5bd545b189ae1ef6e22c2fe7d08e4e9b402c"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}