)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"95a95c4cc770ab429082c2eb8c8d81da61e3f478","unresolved":false,"context_lines":[{"line_number":10561,"context_line":"                        \"\u003cdevices\u003e{}\u003c/devices\u003e\u003c/domain\u003e\")"},{"line_number":10562,"context_line":"        disks_xml \u003d \u0027\u0027"},{"line_number":10563,"context_line":"        for dsk in disks:"},{"line_number":10564,"context_line":"            if dsk[\u0027type\u0027] !\u003d \u0027network\u0027:"},{"line_number":10565,"context_line":"                disks_xml \u003d \u0027\u0027.join([disks_xml,"},{"line_number":10566,"context_line":"                                \"\u003cdisk type\u003d\u0027{type}\u0027\u003e\""},{"line_number":10567,"context_line":"                                \"\u003cdriver name\u003d\u0027qemu\u0027 type\u003d\u0027{driver}\u0027/\u003e\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_b7f139e1","line":10564,"range":{"start_line":10564,"start_character":10,"end_line":10564,"end_character":40},"updated":"2019-11-29 18:00:23.000000000","message":"also technically unrelated but yes we shoudl be doing an equality check not an identity check or adress equallity.\n\nhttps://stackoverflow.com/a/48120163 is a good write up on this.","commit_id":"783d4cb2463b12afee513efc8f5b3b9e78fbeaa8"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4205bf6a3a68d2146d2bd77f029a653fe49e2d9","unresolved":false,"context_lines":[{"line_number":9337,"context_line":"            # being left in an ERROR state and still marked on the source."},{"line_number":9338,"context_line":"            try:"},{"line_number":9339,"context_line":"                self._disconnect_volume(context, connection_info, instance)"},{"line_number":9340,"context_line":"            except Exception as ex:"},{"line_number":9341,"context_line":"                volume_id \u003d driver_block_device.get_volume_id(connection_info)"},{"line_number":9342,"context_line":"                LOG.exception(\"Ignoring exception while attempting to \""},{"line_number":9343,"context_line":"                              \"disconnect volume %s from the source host \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_d7ee3520","side":"PARENT","line":9340,"updated":"2019-11-29 17:27:15.000000000","message":"You just can\u0027t help yourself.","commit_id":"9142a97f24e694be681fcb805d6f1e4d0197edef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98d3e99a9817d12b6e094431dddce6060b64823b","unresolved":false,"context_lines":[{"line_number":9337,"context_line":"            # being left in an ERROR state and still marked on the source."},{"line_number":9338,"context_line":"            try:"},{"line_number":9339,"context_line":"                self._disconnect_volume(context, connection_info, instance)"},{"line_number":9340,"context_line":"            except Exception as ex:"},{"line_number":9341,"context_line":"                volume_id \u003d driver_block_device.get_volume_id(connection_info)"},{"line_number":9342,"context_line":"                LOG.exception(\"Ignoring exception while attempting to \""},{"line_number":9343,"context_line":"                              \"disconnect volume %s from the source host \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_1a3394c6","side":"PARENT","line":9340,"in_reply_to":"3fa7e38b_ba3920d0","updated":"2019-11-29 19:06:24.000000000","message":"ya so the other chagne form \u0027is not\u0027 to !\u003d is definitely something i have seen warning over.\n\ni would expect this to raise an unused variable warning too so i proably was form the flake8 version you used but we would have to fix it eventurally anyway.","commit_id":"9142a97f24e694be681fcb805d6f1e4d0197edef"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f6b799a83680c330edb6840ccd50fb435adc155","unresolved":false,"context_lines":[{"line_number":9337,"context_line":"            # being left in an ERROR state and still marked on the source."},{"line_number":9338,"context_line":"            try:"},{"line_number":9339,"context_line":"                self._disconnect_volume(context, connection_info, instance)"},{"line_number":9340,"context_line":"            except Exception as ex:"},{"line_number":9341,"context_line":"                volume_id \u003d driver_block_device.get_volume_id(connection_info)"},{"line_number":9342,"context_line":"                LOG.exception(\"Ignoring exception while attempting to \""},{"line_number":9343,"context_line":"                              \"disconnect volume %s from the source host \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ba3920d0","side":"PARENT","line":9340,"in_reply_to":"3fa7e38b_d73cf593","updated":"2019-11-29 18:52:56.000000000","message":"Weirdly, this flagged up when I was rebasing with \"--exec \u0027tox -e fast8\u0027\". Thinking on it now, it\u0027s probably because of a stale environment due to [1]. There\u0027s probably a few more in the series.\n\n[1] https://review.opendev.org/#/c/695733/","commit_id":"9142a97f24e694be681fcb805d6f1e4d0197edef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"95a95c4cc770ab429082c2eb8c8d81da61e3f478","unresolved":false,"context_lines":[{"line_number":9337,"context_line":"            # being left in an ERROR state and still marked on the source."},{"line_number":9338,"context_line":"            try:"},{"line_number":9339,"context_line":"                self._disconnect_volume(context, connection_info, instance)"},{"line_number":9340,"context_line":"            except Exception as ex:"},{"line_number":9341,"context_line":"                volume_id \u003d driver_block_device.get_volume_id(connection_info)"},{"line_number":9342,"context_line":"                LOG.exception(\"Ignoring exception while attempting to \""},{"line_number":9343,"context_line":"                              \"disconnect volume %s from the source host \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_d73cf593","side":"PARENT","line":9340,"in_reply_to":"3fa7e38b_d7ee3520","updated":"2019-11-29 18:00:23.000000000","message":"oh unrelated change it so shocking that im still going to +1 :)\n\nif it was not for the fact i know stephen uses vim i would just balme it on his ide.\n\nbut ya its not harmful so meh its not worth respining","commit_id":"9142a97f24e694be681fcb805d6f1e4d0197edef"}]}