)]}'
{"nova/conf/vmware.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"81b9991904aa1a32fabc0db2a735136bd657c815","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\"\"\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"vmwareapi_vif_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027vlan_interface\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027vmnic0\u0027,"},{"line_number":34,"context_line":"               help\u003d\"\"\""},{"line_number":35,"context_line":"This option specifies the physical ethernet adapter name for VLAN"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_9e9438e9","side":"PARENT","line":32,"updated":"2019-12-03 14:27:17.000000000","message":"This wasn\u0027t deprecated but I guess if nothing is using it then there isn\u0027t much point in deprecating it unless there is some oslo tooling that breaks on set but unregistered options in a conf file. It\u0027s mentioned in the upgrade release note at least.","commit_id":"5ecfa674082920356b844e861e4ca3edfe66e98e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3380689bcea7d266c98c2b8398aec176ef0b3ff","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\"\"\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"vmwareapi_vif_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027vlan_interface\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027vmnic0\u0027,"},{"line_number":34,"context_line":"               help\u003d\"\"\""},{"line_number":35,"context_line":"This option specifies the physical ethernet adapter name for VLAN"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_0b147a4c","side":"PARENT","line":32,"in_reply_to":"3fa7e38b_9e9438e9","updated":"2019-12-04 09:58:30.000000000","message":"Yeah, we\u0027ve just straight up removed unused options in the past because it makes more sense than keeping them around when they do exactly nothing.","commit_id":"5ecfa674082920356b844e861e4ca3edfe66e98e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e0b232ea316888531e36312bd17fe86d879d1590","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\"\"\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"vmwareapi_vif_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027vlan_interface\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027vmnic0\u0027,"},{"line_number":34,"context_line":"               help\u003d\"\"\""},{"line_number":35,"context_line":"This option specifies the physical ethernet adapter name for VLAN"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_1fccbbb9","side":"PARENT","line":32,"in_reply_to":"3fa7e38b_9e9438e9","updated":"2019-12-04 21:10:14.000000000","message":"oslo (.config, at least) blithely ignores unregistered options, so no issue there.","commit_id":"5ecfa674082920356b844e861e4ca3edfe66e98e"}],"nova/virt/vmwareapi/vif.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c30a481b6cf56f9d2f16dfb2f78bf8fa6cd8083a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    return network_ref"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def get_network_ref(session, cluster, vif):"},{"line_number":105,"context_line":"    return _get_neutron_network(session, cluster, vif)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def get_vif_dict(session, cluster, vif_model, vif):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ef2b6ee7","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":54},"updated":"2019-11-28 12:14:22.000000000","message":"Could probably flatten this now","commit_id":"49d871d64a46eb03128619ad8012fa1d0d80d535"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"89de226a18533be406b831b06a430e9ce74f0ef3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    return network_ref"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def get_network_ref(session, cluster, vif):"},{"line_number":105,"context_line":"    return _get_neutron_network(session, cluster, vif)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def get_vif_dict(session, cluster, vif_model, vif):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_afd1f6ce","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":54},"in_reply_to":"3fa7e38b_ef2b6ee7","updated":"2019-11-28 12:22:49.000000000","message":"Done","commit_id":"49d871d64a46eb03128619ad8012fa1d0d80d535"}]}