)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"04b03583405faa732035e3b5479e8821806c6923","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"xenapi: Remove vestigial nova-network support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I suspect there is more to be removed here, but this is all I could spot"},{"line_number":10,"context_line":"for the moment."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifb8dc7de5d4845dd639fba71b853d38cdb851c7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_f93a2633","line":9,"updated":"2019-12-03 14:49:40.000000000","message":"It looks like if you track some of this stuff down:\n\nhttps://github.com/openstack/nova/blob/757fc03b78d542e7262343b65eacea02ce11dd04/nova/virt/xenapi/fake.py#L132\n\nyou find things like:\n\nhttps://github.com/openstack/nova/blob/757fc03b78d542e7262343b65eacea02ce11dd04/nova/tests/unit/virt/xenapi/test_xenapi.py#L294\n\nAnd I have to assume that firewall driver is nova-net only:\n\nhttps://github.com/openstack/nova/blob/757fc03b78d542e7262343b65eacea02ce11dd04/nova/virt/xenapi/firewall.py\n\nIt\u0027s not listed as an option here:\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.firewall_driver\n\nBut if we assume it\u0027s part of that group then it\u0027s nova-net only as well.\n\nWe don\u0027t have xenapi 3rd party CI (which is why we deprecated the driver in Train) and we don\u0027t have any maintainers that I know of, so I don\u0027t really know who to ask. Do you want to just remove the firewall driver in a follow up?","commit_id":"295100c3fefb32df5bf075ffcfab02a0f5e25395"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ac8ad20964cb07a91acb7499dc5871c8cb6b606","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"xenapi: Remove vestigial nova-network support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I suspect there is more to be removed here, but this is all I could spot"},{"line_number":10,"context_line":"for the moment."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifb8dc7de5d4845dd639fba71b853d38cdb851c7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_59e9fa7c","line":9,"in_reply_to":"3fa7e38b_f93a2633","updated":"2019-12-03 14:54:14.000000000","message":"Nevermind it\u0027s removed later:\n\nhttps://review.opendev.org/#/c/696514","commit_id":"295100c3fefb32df5bf075ffcfab02a0f5e25395"}],"nova/tests/unit/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"04b03583405faa732035e3b5479e8821806c6923","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        # Instance 2 will use vlan network (see db/fakes.py)"},{"line_number":1172,"context_line":"        ctxt \u003d self.context.elevated()"},{"line_number":1173,"context_line":"        inst2 \u003d self._create_instance(False, obj\u003dTrue)"},{"line_number":1174,"context_line":"        networks \u003d self.network.db.network_get_all(ctxt)"},{"line_number":1175,"context_line":"        with mock.patch(\u0027nova.objects.network.Network._from_db_object\u0027):"},{"line_number":1176,"context_line":"            for network in networks:"},{"line_number":1177,"context_line":"                self.network.set_network_host(ctxt, network)"},{"line_number":1178,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_f990e651","side":"PARENT","line":1175,"range":{"start_line":1174,"start_character":8,"end_line":1175,"end_character":72},"updated":"2019-12-03 14:49:40.000000000","message":"OK I guess this is the indication this is a nova-net test.","commit_id":"846fc0a0b72e8f3ba25741cdff49591e6f2c3e01"}]}