)]}'
{"nova/tests/unit/api/openstack/compute/test_neutron_security_groups.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3d0ee8a6ec355774f33b2307fcc540b374dc9d0a","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest, self.controller.delete,"},{"line_number":216,"context_line":"                          req, sg[\u0027id\u0027])"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def test_associate_non_running_instance(self):"},{"line_number":219,"context_line":"        # Neutron does not care if the instance is running or not. When the"},{"line_number":220,"context_line":"        # instances is detected by neutron it will push down the security"},{"line_number":221,"context_line":"        # group policy to it."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_14a6e70e","side":"PARENT","line":218,"updated":"2019-12-03 15:05:24.000000000","message":"Interestingly this isn\u0027t even in the nova-net test module.","commit_id":"c29d6dcf201658693dde92381f44195b981f2ec7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3d0ee8a6ec355774f33b2307fcc540b374dc9d0a","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                          self.manager._removeSecurityGroup,"},{"line_number":317,"context_line":"                          req, UUID_SERVER, body)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def test_disassociate_non_running_instance(self):"},{"line_number":320,"context_line":"        # Neutron does not care if the instance is running or not. When the"},{"line_number":321,"context_line":"        # instances is detected by neutron it will push down the security"},{"line_number":322,"context_line":"        # group policy to it."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_d4afefdd","side":"PARENT","line":319,"updated":"2019-12-03 15:05:24.000000000","message":"nor is this","commit_id":"c29d6dcf201658693dde92381f44195b981f2ec7"}],"nova/tests/unit/api/openstack/compute/test_security_groups.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5c64e73e1c0c1f0a6390d71bd320a43482489d78","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        expected \u003d {\u0027security_group\u0027: sg_update}"},{"line_number":533,"context_line":"        self.assertEqual(res_dict, expected)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_update_security_group_name_to_default(self):"},{"line_number":536,"context_line":"        sg \u003d security_group_template(id\u003d2, rules\u003d[], name\u003d\u0027default\u0027)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        def return_security_group(context, group_id, columns_to_join\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_6cf5facb","side":"PARENT","line":535,"range":{"start_line":535,"start_character":8,"end_line":535,"end_character":50},"updated":"2019-12-04 21:33:56.000000000","message":"This one doesn\u0027t (and didn\u0027t) have an override for neutron. Why is it okay to remove?","commit_id":"c29d6dcf201658693dde92381f44195b981f2ec7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a5e2faf66f5d5bd2ecf56607aa0540da26e99c31","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        expected \u003d {\u0027security_group\u0027: sg_update}"},{"line_number":533,"context_line":"        self.assertEqual(res_dict, expected)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_update_security_group_name_to_default(self):"},{"line_number":536,"context_line":"        sg \u003d security_group_template(id\u003d2, rules\u003d[], name\u003d\u0027default\u0027)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        def return_security_group(context, group_id, columns_to_join\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_ae9e7bb4","side":"PARENT","line":535,"range":{"start_line":535,"start_character":8,"end_line":535,"end_character":50},"in_reply_to":"3fa7e38b_14700409","updated":"2019-12-05 15:59:26.000000000","message":"Okay. That should be mentioned in the commit message, since this is the only one not fitting the pattern of \"override passes so remove it and the base\".","commit_id":"c29d6dcf201658693dde92381f44195b981f2ec7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7765a10a0ec1fed7ff053ad172a2aa7dff48c2e4","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        expected \u003d {\u0027security_group\u0027: sg_update}"},{"line_number":533,"context_line":"        self.assertEqual(res_dict, expected)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_update_security_group_name_to_default(self):"},{"line_number":536,"context_line":"        sg \u003d security_group_template(id\u003d2, rules\u003d[], name\u003d\u0027default\u0027)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        def return_security_group(context, group_id, columns_to_join\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_14700409","side":"PARENT","line":535,"range":{"start_line":535,"start_character":8,"end_line":535,"end_character":50},"in_reply_to":"3fa7e38b_6cf5facb","updated":"2019-12-05 10:46:38.000000000","message":"Naming of security groups is now the remit of neutron, therefore there is no need for a test that ensures we can\u0027t set the name of a security group to default since if that was a thing, it would be neutron that would be enforcing it. All that we actually need to test here is that errors raised by neutron are correctly handled and converted to HTTP error responses, which we do in the next test. That could do with being more generic (drop references to the default group) but this one can definitely go","commit_id":"c29d6dcf201658693dde92381f44195b981f2ec7"}]}