)]}'
{"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"322c3588e53c87f3d3e659942cba594dd018ae3c","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        def fake_get_nw_info(cls, ctxt, instance, *args, **kwargs):"},{"line_number":241,"context_line":"            return network_model.NetworkInfo()"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        self.stub_out("},{"line_number":244,"context_line":"            \u0027nova.network.neutronv2.api.API.get_instance_nw_info\u0027,"},{"line_number":245,"context_line":"            fake_get_nw_info)"},{"line_number":246,"context_line":"        self.stub_out("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_e7417c0a","line":243,"updated":"2019-12-13 21:29:38.000000000","message":"test_compute.py has always been somewhere between unit and functional tests and I wouldn\u0027t be surprised if we could just replace a lot of this kind of stuff with using the NeutronFixture and it\u0027d clean a lot of things up in here, but obviously not something to do here.","commit_id":"48e6e050441d3e64eaff0681d575479713ae35df"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b1c3356ddbf0b1caf1a078426926a334d1204080","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        def fake_get_nw_info(cls, ctxt, instance, *args, **kwargs):"},{"line_number":241,"context_line":"            return network_model.NetworkInfo()"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        self.stub_out("},{"line_number":244,"context_line":"            \u0027nova.network.neutronv2.api.API.get_instance_nw_info\u0027,"},{"line_number":245,"context_line":"            fake_get_nw_info)"},{"line_number":246,"context_line":"        self.stub_out("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_951303b8","line":243,"in_reply_to":"3fa7e38b_e7417c0a","updated":"2019-12-16 09:37:46.000000000","message":"Yeah, pretty sure I\u0027ve left some TODOs throughout the code to do just this. Later though","commit_id":"48e6e050441d3e64eaff0681d575479713ae35df"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"322c3588e53c87f3d3e659942cba594dd018ae3c","unresolved":false,"context_lines":[{"line_number":6143,"context_line":"        mock_build_run.side_effect \u003d exception.RescheduledException(reason\u003d\u0027\u0027,"},{"line_number":6144,"context_line":"                instance_uuid\u003dself.instance.uuid)"},{"line_number":6145,"context_line":""},{"line_number":6146,"context_line":"        with mock.patch.object("},{"line_number":6147,"context_line":"                self.compute.network_api,"},{"line_number":6148,"context_line":"                \u0027cleanup_instance_network_on_host\u0027) as mock_clean:"},{"line_number":6149,"context_line":"            self.compute.build_and_run_instance(self.context, self.instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_e7ddfc3f","side":"PARENT","line":6146,"updated":"2019-12-13 21:29:38.000000000","message":"You likely didn\u0027t need to remove this and instead...","commit_id":"70540d850f07c0926805dba95f1b8e5bd9f30358"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b1c3356ddbf0b1caf1a078426926a334d1204080","unresolved":false,"context_lines":[{"line_number":6143,"context_line":"        mock_build_run.side_effect \u003d exception.RescheduledException(reason\u003d\u0027\u0027,"},{"line_number":6144,"context_line":"                instance_uuid\u003dself.instance.uuid)"},{"line_number":6145,"context_line":""},{"line_number":6146,"context_line":"        with mock.patch.object("},{"line_number":6147,"context_line":"                self.compute.network_api,"},{"line_number":6148,"context_line":"                \u0027cleanup_instance_network_on_host\u0027) as mock_clean:"},{"line_number":6149,"context_line":"            self.compute.build_and_run_instance(self.context, self.instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_95c6a315","side":"PARENT","line":6146,"in_reply_to":"3fa7e38b_e7ddfc3f","updated":"2019-12-16 09:37:46.000000000","message":"I was going to argue that this was silly because I don\u0027t assert that e.g. I don\u0027t call arbitrary_function_foobar, but actually the call here still exists in the compute driver and isn\u0027t removed until later [1], so I think I should remove this call but it should happen alongside [1]. Will do that.\n\n[1] https://review.opendev.org/#/c/696516/9/nova/compute/manager.py@a2249","commit_id":"70540d850f07c0926805dba95f1b8e5bd9f30358"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"322c3588e53c87f3d3e659942cba594dd018ae3c","unresolved":false,"context_lines":[{"line_number":6166,"context_line":"                self.requested_networks, self.security_groups,"},{"line_number":6167,"context_line":"                self.block_device_mapping, self.node, self.limits,"},{"line_number":6168,"context_line":"                self.filter_properties, {})"},{"line_number":6169,"context_line":"        mock_clean.assert_called_once_with(self.context, self.instance,"},{"line_number":6170,"context_line":"                self.compute.host)"},{"line_number":6171,"context_line":"        mock_nil.assert_called_once_with(self.instance)"},{"line_number":6172,"context_line":"        mock_build.assert_called_once_with(self.context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_87ea08d7","side":"PARENT","line":6169,"range":{"start_line":6169,"start_character":19,"end_line":6169,"end_character":42},"updated":"2019-12-13 21:29:38.000000000","message":"...change this to assert_not_called.","commit_id":"70540d850f07c0926805dba95f1b8e5bd9f30358"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"322c3588e53c87f3d3e659942cba594dd018ae3c","unresolved":false,"context_lines":[{"line_number":6233,"context_line":"        mock_build_and_run.side_effect \u003d exception.RescheduledException("},{"line_number":6234,"context_line":"            reason\u003d\u0027\u0027, instance_uuid\u003dself.instance.uuid)"},{"line_number":6235,"context_line":""},{"line_number":6236,"context_line":"        with mock.patch.object("},{"line_number":6237,"context_line":"                self.compute.network_api,"},{"line_number":6238,"context_line":"                \u0027cleanup_instance_network_on_host\u0027) as mock_cleanup_network:"},{"line_number":6239,"context_line":"            self.compute._do_build_and_run_instance(self.context, instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_a7e70410","side":"PARENT","line":6236,"updated":"2019-12-13 21:29:38.000000000","message":"same","commit_id":"70540d850f07c0926805dba95f1b8e5bd9f30358"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"322c3588e53c87f3d3e659942cba594dd018ae3c","unresolved":false,"context_lines":[{"line_number":6430,"context_line":"                instance_uuid\u003dself.instance.uuid)"},{"line_number":6431,"context_line":"        mock_deallocate.return_value \u003d False"},{"line_number":6432,"context_line":""},{"line_number":6433,"context_line":"        with mock.patch.object("},{"line_number":6434,"context_line":"                self.compute.network_api,"},{"line_number":6435,"context_line":"                \u0027cleanup_instance_network_on_host\u0027) as mock_clean_inst:"},{"line_number":6436,"context_line":"            self.compute.build_and_run_instance(self.context, self.instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_47b650ff","side":"PARENT","line":6433,"updated":"2019-12-13 21:29:38.000000000","message":"same","commit_id":"70540d850f07c0926805dba95f1b8e5bd9f30358"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"322c3588e53c87f3d3e659942cba594dd018ae3c","unresolved":false,"context_lines":[{"line_number":6883,"context_line":"        mock_claim.side_effect \u003d exc"},{"line_number":6884,"context_line":"        self._do_build_instance_update(mock_save, reschedule_update\u003dTrue)"},{"line_number":6885,"context_line":""},{"line_number":6886,"context_line":"        with mock.patch.object("},{"line_number":6887,"context_line":"                self.compute.network_api,"},{"line_number":6888,"context_line":"                \u0027cleanup_instance_network_on_host\u0027) as mock_clean:"},{"line_number":6889,"context_line":"            self.compute.build_and_run_instance(self.context, self.instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_67bb4ce4","side":"PARENT","line":6886,"updated":"2019-12-13 21:29:38.000000000","message":"ditto","commit_id":"70540d850f07c0926805dba95f1b8e5bd9f30358"}],"nova/tests/unit/virt/test_virt_drivers.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d39e4143840ab2bac870bdcccc9a48ab976727bb","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        # This is needed for the live migration tests which spawn off the"},{"line_number":896,"context_line":"        # operation for monitoring."},{"line_number":897,"context_line":"        self.useFixture(nova_fixtures.SpawnIsSynchronousFixture())"},{"line_number":898,"context_line":"        # When using destroying an instance, os-vif will try to execute some"},{"line_number":899,"context_line":"        # commands which hang tests so let\u0027s just stub out the unplug call to"},{"line_number":900,"context_line":"        # os-vif since we don\u0027t care about it."},{"line_number":901,"context_line":"        self.stub_out(\u0027os_vif.unplug\u0027, lambda a, kw: None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_583446ac","line":898,"range":{"start_line":898,"start_character":15,"end_line":898,"end_character":20},"updated":"2019-12-09 10:40:24.000000000","message":"drop","commit_id":"c70bc5578759f6bf0f067f752d0033d984abc03d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1cb31c536afc5722db8db25abc6bfb6b43c4d028","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        # This is needed for the live migration tests which spawn off the"},{"line_number":896,"context_line":"        # operation for monitoring."},{"line_number":897,"context_line":"        self.useFixture(nova_fixtures.SpawnIsSynchronousFixture())"},{"line_number":898,"context_line":"        # When using destroying an instance, os-vif will try to execute some"},{"line_number":899,"context_line":"        # commands which hang tests so let\u0027s just stub out the unplug call to"},{"line_number":900,"context_line":"        # os-vif since we don\u0027t care about it."},{"line_number":901,"context_line":"        self.stub_out(\u0027os_vif.unplug\u0027, lambda a, kw: None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_9b814650","line":898,"range":{"start_line":898,"start_character":15,"end_line":898,"end_character":20},"in_reply_to":"3fa7e38b_583446ac","updated":"2019-12-10 11:05:36.000000000","message":"Done","commit_id":"c70bc5578759f6bf0f067f752d0033d984abc03d"}],"nova/tests/unit/virt/xenapi/test_vmops.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d15c35fb65821c45f03fc72517e0b5d78de90afa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa7e38b_2f4186a7","updated":"2019-11-28 12:17:23.000000000","message":"I need to move this back to https://review.opendev.org/#/c/696505/","commit_id":"c9ce1b9181d3163753e65f1996e06acd7ea9ddc2"}]}