)]}'
{"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3b8fdcf5d9e9b915aa87b2c7273bde2f9e0643e5","unresolved":false,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    def _assertXmlEqual(self, expectedXmlstr, actualXmlstr):"},{"line_number":569,"context_line":"        if not isinstance(actualXmlstr, six.string_types):"},{"line_number":570,"context_line":"            actualXmlstr \u003d etree.tostring(actualXmlstr, encoding\u003d\u0027unicode\u0027,"},{"line_number":571,"context_line":"                                          pretty_print\u003dTrue)"},{"line_number":572,"context_line":"        self.assertXmlEqual(actualXmlstr, expectedXmlstr)"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_a0b7d585","line":570,"updated":"2019-12-16 18:59:44.000000000","message":"Why is this here?","commit_id":"8ad9221fdcc4208e9e4c325260e9b07be1fd2ffe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7133a191bd07070f05b51cbd59e9379b95dc412","unresolved":false,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    def _assertXmlEqual(self, expectedXmlstr, actualXmlstr):"},{"line_number":569,"context_line":"        if not isinstance(actualXmlstr, six.string_types):"},{"line_number":570,"context_line":"            actualXmlstr \u003d etree.tostring(actualXmlstr, encoding\u003d\u0027unicode\u0027,"},{"line_number":571,"context_line":"                                          pretty_print\u003dTrue)"},{"line_number":572,"context_line":"        self.assertXmlEqual(actualXmlstr, expectedXmlstr)"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_aeb25f95","line":570,"in_reply_to":"3fa7e38b_a0b7d585","updated":"2019-12-17 10:06:48.000000000","message":"On Python 3, expectedXmlStr is unicode (the default string type) while the output of \u0027etree.tostring\u0027 is a byte string, apparently. If I don\u0027t do this and there\u0027s a mismatch between the two, testtools (or whatever provides the XML comparison helper) refuses to show a diff, instead highlighting the error. I don\u0027t know why the basic comparison does work though. In any case, you can test this by re-adding one of the filterref elements in the below tests and removing this argument.\n\nI was almost certain I\u0027d noted this in the commit message but I hadn\u0027t :(","commit_id":"8ad9221fdcc4208e9e4c325260e9b07be1fd2ffe"}]}