)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"625decf1ba8a8900bddb5b22b9b356d724cb2241","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew Booth \u003cmbooth@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-28 16:19:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix invalid vim call in vim_util.get_dynamic_properties()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Code was calling"},{"line_number":10,"context_line":"vim.CancelRetrievePropertiesEx(token\u003dobj_content.token)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BQQg%3D","line":7,"updated":"2014-01-28 17:00:33.000000000","message":"please prefix this with VMware:","commit_id":"40d6338a65ccfc39e6f8724b2aecc9236e3e121d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"625decf1ba8a8900bddb5b22b9b356d724cb2241","unresolved":false,"context_lines":[{"line_number":14,"context_line":"which requires a managed_object argument. The relevant managed object"},{"line_number":15,"context_line":"in this case is propertyCollector."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"N.B. There\u0027s no current test which exercises this code, or"},{"line_number":18,"context_line":"get_dynamic_properties() at all by the looks of it. It could obviously"},{"line_number":19,"context_line":"do with a test."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BQQI%3D","line":17,"updated":"2014-01-28 17:00:33.000000000","message":"Please add a test for this and remove the comment","commit_id":"40d6338a65ccfc39e6f8724b2aecc9236e3e121d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0e4a5ef5296f82be1dab1182fa378eb40224569e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew Booth \u003cmbooth@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-29 15:04:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix invalid vim call in vim_util.get_dynamic_properties()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Code was calling"},{"line_number":10,"context_line":"vim.CancelRetrievePropertiesEx(token\u003dobj_content.token)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2BJXs%3D","line":7,"updated":"2014-01-29 18:08:14.000000000","message":"please add VMware: prefix","commit_id":"8f43b70b385f0b9a425bf88c0f4a7691cf86ddb7"}],"nova/tests/virt/vmwareapi/test_vim_util.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"12680a63db9b1bbc8d7d3103cb37c4685d920fb2","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import collections"},{"line_number":18,"context_line":"import fixtures"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova import test"},{"line_number":22,"context_line":"from nova.virt.vmwareapi import driver"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BKf4%3D","line":19,"updated":"2014-01-29 15:12:07.000000000","message":"minor nit - but some may disagree - mock is a third party import so it should in its own section","commit_id":"8f43b70b385f0b9a425bf88c0f4a7691cf86ddb7"}],"nova/virt/vmwareapi/vim_util.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"625decf1ba8a8900bddb5b22b9b356d724cb2241","unresolved":false,"context_lines":[{"line_number":177,"context_line":"def get_dynamic_properties(vim, mobj, type, property_names):"},{"line_number":178,"context_line":"    \"\"\"Gets the specified properties of the Managed Object.\"\"\""},{"line_number":179,"context_line":"    obj_content \u003d get_object_properties(vim, None, mobj, type, property_names)"},{"line_number":180,"context_line":"    if hasattr(obj_content, \u0027token\u0027):"},{"line_number":181,"context_line":"        vim.CancelRetrievePropertiesEx("},{"line_number":182,"context_line":"            vim.get_service_content().propertyCollector,"},{"line_number":183,"context_line":"            token\u003dobj_content.token)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BQPo%3D","line":180,"updated":"2014-01-28 17:00:33.000000000","message":"consider replacing lines 181 - 183 with cancel_retrieve(vim, obj_content.token)","commit_id":"40d6338a65ccfc39e6f8724b2aecc9236e3e121d"}]}
