)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aafd63757adb23025b37791a1cf7fe32f5e68107","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make the binding:profile handling consistent in NeutronFixture"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For an unbound port real neutron return {} as binding:profile. In the"},{"line_number":10,"context_line":"NeutronFixture the binding:profile key was missing in the predefined"},{"line_number":11,"context_line":"ports. This made the tests asserting the binding:profile inconsistent."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_b4ab256f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":62},"updated":"2019-12-05 20:38:18.000000000","message":"I don\u0027t see much in the way of documentation to assert this so I\u0027m assuming it\u0027s based on observed behavior, specifically with OVS. The docs say the binding:profile parameter on a port is not optional:\n\nhttps://docs.openstack.org/api-ref/network/v2/index.html?expanded\u003dshow-port-details-detail#show-port-details\n\nBut don\u0027t mention if it would be {} or null or what.","commit_id":"55030676c1f78328ef756b35e2161e43b847cf7e"}],"nova/tests/fixtures.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aafd63757adb23025b37791a1cf7fe32f5e68107","unresolved":false,"context_lines":[{"line_number":1365,"context_line":"        \u0027tenant_id\u0027: tenant_id,"},{"line_number":1366,"context_line":"        \u0027project_id\u0027: tenant_id,"},{"line_number":1367,"context_line":"        \u0027device_id\u0027: \u0027\u0027,"},{"line_number":1368,"context_line":"        \u0027binding:profile\u0027: {},"},{"line_number":1369,"context_line":"        \u0027binding:vnic_type\u0027: \u0027normal\u0027,"},{"line_number":1370,"context_line":"        \u0027binding:vif_type\u0027: \u0027ovs\u0027,"},{"line_number":1371,"context_line":"        \u0027port_security_enabled\u0027: True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_b4f9e582","line":1368,"updated":"2019-12-05 20:38:18.000000000","message":"I want to say I wrote a functional test recently that created another network or port or something but didn\u0027t register it in the fixture, and I think we have some others that do that as well, but I can\u0027t seem to find it. Point being, would those need to be updated as well if they aren\u0027t copying and modifying one of these ports? Maybe not since this isn\u0027t causing any failures in other tests.","commit_id":"55030676c1f78328ef756b35e2161e43b847cf7e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c8fee59573762dbf2c6788b9784302e921440e30","unresolved":false,"context_lines":[{"line_number":1365,"context_line":"        \u0027tenant_id\u0027: tenant_id,"},{"line_number":1366,"context_line":"        \u0027project_id\u0027: tenant_id,"},{"line_number":1367,"context_line":"        \u0027device_id\u0027: \u0027\u0027,"},{"line_number":1368,"context_line":"        \u0027binding:profile\u0027: {},"},{"line_number":1369,"context_line":"        \u0027binding:vnic_type\u0027: \u0027normal\u0027,"},{"line_number":1370,"context_line":"        \u0027binding:vif_type\u0027: \u0027ovs\u0027,"},{"line_number":1371,"context_line":"        \u0027port_security_enabled\u0027: True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_09a9a2db","line":1368,"in_reply_to":"3fa7e38b_b4f9e582","updated":"2019-12-09 14:05:07.000000000","message":"This is what I was thinking of:\n\nhttps://review.opendev.org/#/c/694179/2/nova/tests/functional/test_external_networks.py@48\n\nIt copies the network, not the port.","commit_id":"55030676c1f78328ef756b35e2161e43b847cf7e"}]}