)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd5839ea60ed84b9524c291e7c864e3bd110a429","unresolved":false,"context_lines":[{"line_number":2389,"context_line":"        self._check_device_tagging(requested_networks, block_device_mapping)"},{"line_number":2390,"context_line":"        self._check_trusted_certs(instance)"},{"line_number":2391,"context_line":""},{"line_number":2392,"context_line":"        provider_mapping \u003d (None if not request_spec"},{"line_number":2393,"context_line":"                            else request_spec.get_request_group_mapping())"},{"line_number":2394,"context_line":"        if provider_mapping:"},{"line_number":2395,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2396,"context_line":"                context, instance, provider_mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_01e80fb1","line":2393,"range":{"start_line":2392,"start_character":0,"end_line":2393,"end_character":74},"updated":"2019-11-29 15:44:25.000000000","message":"this would probably make more sense as a normal if rather than a one-liner","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fd743ce509b8691cb709d0ce40eef45dc72d81cb","unresolved":false,"context_lines":[{"line_number":2389,"context_line":"        self._check_device_tagging(requested_networks, block_device_mapping)"},{"line_number":2390,"context_line":"        self._check_trusted_certs(instance)"},{"line_number":2391,"context_line":""},{"line_number":2392,"context_line":"        provider_mapping \u003d (None if not request_spec"},{"line_number":2393,"context_line":"                            else request_spec.get_request_group_mapping())"},{"line_number":2394,"context_line":"        if provider_mapping:"},{"line_number":2395,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2396,"context_line":"                context, instance, provider_mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6c31a859","line":2393,"range":{"start_line":2392,"start_character":0,"end_line":2393,"end_character":74},"in_reply_to":"3fa7e38b_01e80fb1","updated":"2019-12-03 09:59:30.000000000","message":"Done","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd5839ea60ed84b9524c291e7c864e3bd110a429","unresolved":false,"context_lines":[{"line_number":3411,"context_line":"        provider_mapping \u003d None"},{"line_number":3412,"context_line":"        if evacuate:"},{"line_number":3413,"context_line":"            provider_mapping \u003d (None if not request_spec"},{"line_number":3414,"context_line":"                                else request_spec.get_request_group_mapping())"},{"line_number":3415,"context_line":"            if provider_mapping:"},{"line_number":3416,"context_line":"                self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":3417,"context_line":"                    context, instance, provider_mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_61d6a3f5","line":3414,"updated":"2019-11-29 15:44:25.000000000","message":"ditto\n\nAlso, shouldn\u0027t we always have a request_spec now?","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fd743ce509b8691cb709d0ce40eef45dc72d81cb","unresolved":false,"context_lines":[{"line_number":3411,"context_line":"        provider_mapping \u003d None"},{"line_number":3412,"context_line":"        if evacuate:"},{"line_number":3413,"context_line":"            provider_mapping \u003d (None if not request_spec"},{"line_number":3414,"context_line":"                                else request_spec.get_request_group_mapping())"},{"line_number":3415,"context_line":"            if provider_mapping:"},{"line_number":3416,"context_line":"                self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":3417,"context_line":"                    context, instance, provider_mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_73fe5805","line":3414,"in_reply_to":"3fa7e38b_61d6a3f5","updated":"2019-12-03 09:59:30.000000000","message":"Done. \n\nI have to think about when we can assume that the request spec is not None. At least some test blows if I remove the conditionals.","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8f12ac88e8c512505f6a4f6a9280b15f41997653","unresolved":false,"context_lines":[{"line_number":3411,"context_line":"        provider_mapping \u003d None"},{"line_number":3412,"context_line":"        if evacuate:"},{"line_number":3413,"context_line":"            provider_mapping \u003d (None if not request_spec"},{"line_number":3414,"context_line":"                                else request_spec.get_request_group_mapping())"},{"line_number":3415,"context_line":"            if provider_mapping:"},{"line_number":3416,"context_line":"                self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":3417,"context_line":"                    context, instance, provider_mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5b56d207","line":3414,"in_reply_to":"3fa7e38b_73fe5805","updated":"2019-12-03 13:02:35.000000000","message":"I dig a bit it is not easy to say when we have a non None RequestSpec. I pass now.","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd5839ea60ed84b9524c291e7c864e3bd110a429","unresolved":false,"context_lines":[{"line_number":4572,"context_line":"            scheduler_utils.fill_provider_mapping_based_on_allocation("},{"line_number":4573,"context_line":"                context, self.reportclient, request_spec, allocations)"},{"line_number":4574,"context_line":"            provider_mappings \u003d (None if not request_spec"},{"line_number":4575,"context_line":"                                 else request_spec.get_request_group_mapping())"},{"line_number":4576,"context_line":"        else:"},{"line_number":4577,"context_line":"            # NOTE(gibi): The compute RPC is pinned to be older than 5.2"},{"line_number":4578,"context_line":"            # and therefore request_spec is not sent. We cannot calculate"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e1fb7378","line":4575,"updated":"2019-11-29 15:44:25.000000000","message":"and again","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fd743ce509b8691cb709d0ce40eef45dc72d81cb","unresolved":false,"context_lines":[{"line_number":4572,"context_line":"            scheduler_utils.fill_provider_mapping_based_on_allocation("},{"line_number":4573,"context_line":"                context, self.reportclient, request_spec, allocations)"},{"line_number":4574,"context_line":"            provider_mappings \u003d (None if not request_spec"},{"line_number":4575,"context_line":"                                 else request_spec.get_request_group_mapping())"},{"line_number":4576,"context_line":"        else:"},{"line_number":4577,"context_line":"            # NOTE(gibi): The compute RPC is pinned to be older than 5.2"},{"line_number":4578,"context_line":"            # and therefore request_spec is not sent. We cannot calculate"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ec1d98be","line":4575,"in_reply_to":"3fa7e38b_e1fb7378","updated":"2019-12-03 09:59:30.000000000","message":"Done","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"fd09e0f6dbb9bf43349bad531180c8ed6f1cea72","unresolved":false,"context_lines":[{"line_number":2434,"context_line":"                                                     scheduler_hints)"},{"line_number":2435,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image)"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":"                request_group_resource_providers_mapping \u003d \\"},{"line_number":2438,"context_line":"                    self._get_request_group_mapping(request_spec)"},{"line_number":2439,"context_line":""},{"line_number":2440,"context_line":"                with self._build_resources(context, instance,"},{"line_number":2441,"context_line":"                        requested_networks, security_groups, image_meta,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_a80e213a","side":"PARENT","line":2438,"range":{"start_line":2437,"start_character":0,"end_line":2438,"end_character":65},"updated":"2019-12-11 16:19:02.000000000","message":"ack, this was unnecessary before too, if I\u0027m reading right.","commit_id":"a6f9f38cbbff1d6777a73272300905f8ba7afb98"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"fd09e0f6dbb9bf43349bad531180c8ed6f1cea72","unresolved":false,"context_lines":[{"line_number":2405,"context_line":"        self._check_device_tagging(requested_networks, block_device_mapping)"},{"line_number":2406,"context_line":"        self._check_trusted_certs(instance)"},{"line_number":2407,"context_line":""},{"line_number":2408,"context_line":"        provider_mapping \u003d self._get_request_group_mapping(request_spec)"},{"line_number":2409,"context_line":"        if provider_mapping:"},{"line_number":2410,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2411,"context_line":"                context, instance, provider_mapping)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_682349bf","line":2408,"range":{"start_line":2408,"start_character":8,"end_line":2408,"end_character":24},"updated":"2019-12-11 16:19:02.000000000","message":"so now this is just a rename, no logic change\n\n(I think the name is better, just noting)\n\n[Later] Ditto all the other deltas in this file (except the removal of https://review.opendev.org/#/c/696541/6/nova/compute/manager.py@a2437 as noted)","commit_id":"6de27bfcb88b234c827c9ba1d647071c0dfbbb67"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"918607ad2d506b605f8d83ca8675d03f9abf0e35","unresolved":false,"context_lines":[{"line_number":2451,"context_line":"        self._check_device_tagging(requested_networks, block_device_mapping)"},{"line_number":2452,"context_line":"        self._check_trusted_certs(instance)"},{"line_number":2453,"context_line":""},{"line_number":2454,"context_line":"        request_group_resource_providers_mapping \u003d \\"},{"line_number":2455,"context_line":"            self._get_request_group_mapping(request_spec)"},{"line_number":2456,"context_line":""},{"line_number":2457,"context_line":"        if request_group_resource_providers_mapping:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_a351620f","side":"PARENT","line":2454,"updated":"2019-12-11 16:25:10.000000000","message":"This rename and such is unrelated correct?","commit_id":"2e6a029c006d1c118d3c796570b5b62c3310476c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"893fe37ab902f2a09c632c1b973dc6e5211e413d","unresolved":false,"context_lines":[{"line_number":2451,"context_line":"        self._check_device_tagging(requested_networks, block_device_mapping)"},{"line_number":2452,"context_line":"        self._check_trusted_certs(instance)"},{"line_number":2453,"context_line":""},{"line_number":2454,"context_line":"        request_group_resource_providers_mapping \u003d \\"},{"line_number":2455,"context_line":"            self._get_request_group_mapping(request_spec)"},{"line_number":2456,"context_line":""},{"line_number":2457,"context_line":"        if request_group_resource_providers_mapping:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_5402983f","side":"PARENT","line":2454,"in_reply_to":"3fa7e38b_a351620f","updated":"2019-12-12 12:31:43.000000000","message":"Done","commit_id":"2e6a029c006d1c118d3c796570b5b62c3310476c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"918607ad2d506b605f8d83ca8675d03f9abf0e35","unresolved":false,"context_lines":[{"line_number":2474,"context_line":"                                                     scheduler_hints)"},{"line_number":2475,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image)"},{"line_number":2476,"context_line":""},{"line_number":2477,"context_line":"                request_group_resource_providers_mapping \u003d \\"},{"line_number":2478,"context_line":"                    self._get_request_group_mapping(request_spec)"},{"line_number":2479,"context_line":""},{"line_number":2480,"context_line":"                with self._build_resources(context, instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_833a26c1","side":"PARENT","line":2477,"updated":"2019-12-11 16:25:10.000000000","message":"And removing this and re-using provider_mapping from above is a separate optimization, right? Which could have been done before this change.","commit_id":"2e6a029c006d1c118d3c796570b5b62c3310476c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"893fe37ab902f2a09c632c1b973dc6e5211e413d","unresolved":false,"context_lines":[{"line_number":2474,"context_line":"                                                     scheduler_hints)"},{"line_number":2475,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image)"},{"line_number":2476,"context_line":""},{"line_number":2477,"context_line":"                request_group_resource_providers_mapping \u003d \\"},{"line_number":2478,"context_line":"                    self._get_request_group_mapping(request_spec)"},{"line_number":2479,"context_line":""},{"line_number":2480,"context_line":"                with self._build_resources(context, instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_74fd5439","side":"PARENT","line":2477,"in_reply_to":"3fa7e38b_833a26c1","updated":"2019-12-12 12:31:43.000000000","message":"Done. I will do the optimization separately","commit_id":"2e6a029c006d1c118d3c796570b5b62c3310476c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"918607ad2d506b605f8d83ca8675d03f9abf0e35","unresolved":false,"context_lines":[{"line_number":3475,"context_line":"            allocations, rebuild_claim, scheduled_node, limits):"},{"line_number":3476,"context_line":"        \"\"\"Helper to avoid deep nesting in the top-level method.\"\"\""},{"line_number":3477,"context_line":""},{"line_number":3478,"context_line":"        request_group_resource_providers_mapping \u003d None"},{"line_number":3479,"context_line":"        if evacuate:"},{"line_number":3480,"context_line":"            request_group_resource_providers_mapping \u003d \\"},{"line_number":3481,"context_line":"                self._get_request_group_mapping(request_spec)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_23457244","side":"PARENT","line":3478,"updated":"2019-12-11 16:25:10.000000000","message":"same","commit_id":"2e6a029c006d1c118d3c796570b5b62c3310476c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"893fe37ab902f2a09c632c1b973dc6e5211e413d","unresolved":false,"context_lines":[{"line_number":3475,"context_line":"            allocations, rebuild_claim, scheduled_node, limits):"},{"line_number":3476,"context_line":"        \"\"\"Helper to avoid deep nesting in the top-level method.\"\"\""},{"line_number":3477,"context_line":""},{"line_number":3478,"context_line":"        request_group_resource_providers_mapping \u003d None"},{"line_number":3479,"context_line":"        if evacuate:"},{"line_number":3480,"context_line":"            request_group_resource_providers_mapping \u003d \\"},{"line_number":3481,"context_line":"                self._get_request_group_mapping(request_spec)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_b4b50c7f","side":"PARENT","line":3478,"in_reply_to":"3fa7e38b_23457244","updated":"2019-12-12 12:31:43.000000000","message":"Done","commit_id":"2e6a029c006d1c118d3c796570b5b62c3310476c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"918607ad2d506b605f8d83ca8675d03f9abf0e35","unresolved":false,"context_lines":[{"line_number":4803,"context_line":"            scheduler_utils.fill_provider_mapping_based_on_allocation("},{"line_number":4804,"context_line":"                context, self.reportclient, request_spec, allocations)"},{"line_number":4805,"context_line":"            provider_mappings \u003d self._get_request_group_mapping("},{"line_number":4806,"context_line":"                request_spec)"},{"line_number":4807,"context_line":"        else:"},{"line_number":4808,"context_line":"            # NOTE(gibi): The compute RPC is pinned to be older than 5.2"},{"line_number":4809,"context_line":"            # and therefore request_spec is not sent. We cannot calculate"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_e3743a9e","side":"PARENT","line":4806,"updated":"2019-12-11 16:25:10.000000000","message":"same, this is unrelated and bloats the change","commit_id":"2e6a029c006d1c118d3c796570b5b62c3310476c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"893fe37ab902f2a09c632c1b973dc6e5211e413d","unresolved":false,"context_lines":[{"line_number":4803,"context_line":"            scheduler_utils.fill_provider_mapping_based_on_allocation("},{"line_number":4804,"context_line":"                context, self.reportclient, request_spec, allocations)"},{"line_number":4805,"context_line":"            provider_mappings \u003d self._get_request_group_mapping("},{"line_number":4806,"context_line":"                request_spec)"},{"line_number":4807,"context_line":"        else:"},{"line_number":4808,"context_line":"            # NOTE(gibi): The compute RPC is pinned to be older than 5.2"},{"line_number":4809,"context_line":"            # and therefore request_spec is not sent. We cannot calculate"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_54b0588b","side":"PARENT","line":4806,"in_reply_to":"3fa7e38b_e3743a9e","updated":"2019-12-12 12:31:43.000000000","message":"Done","commit_id":"2e6a029c006d1c118d3c796570b5b62c3310476c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"918607ad2d506b605f8d83ca8675d03f9abf0e35","unresolved":false,"context_lines":[{"line_number":4891,"context_line":"            # the request spec would already have the new flavor in it from the"},{"line_number":4892,"context_line":"            # else block below."},{"line_number":4893,"context_line":""},{"line_number":4894,"context_line":"        request_group_resource_providers_mapping \u003d \\"},{"line_number":4895,"context_line":"            self._get_request_group_mapping(request_spec)"},{"line_number":4896,"context_line":""},{"line_number":4897,"context_line":"        if request_group_resource_providers_mapping:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_a36ac2b1","side":"PARENT","line":4894,"updated":"2019-12-11 16:25:10.000000000","message":"same","commit_id":"2e6a029c006d1c118d3c796570b5b62c3310476c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"893fe37ab902f2a09c632c1b973dc6e5211e413d","unresolved":false,"context_lines":[{"line_number":4891,"context_line":"            # the request spec would already have the new flavor in it from the"},{"line_number":4892,"context_line":"            # else block below."},{"line_number":4893,"context_line":""},{"line_number":4894,"context_line":"        request_group_resource_providers_mapping \u003d \\"},{"line_number":4895,"context_line":"            self._get_request_group_mapping(request_spec)"},{"line_number":4896,"context_line":""},{"line_number":4897,"context_line":"        if request_group_resource_providers_mapping:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_74ab141d","side":"PARENT","line":4894,"in_reply_to":"3fa7e38b_a36ac2b1","updated":"2019-12-12 12:31:43.000000000","message":"Done","commit_id":"2e6a029c006d1c118d3c796570b5b62c3310476c"}],"nova/objects/request_spec.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd5839ea60ed84b9524c291e7c864e3bd110a429","unresolved":false,"context_lines":[{"line_number":883,"context_line":"        \"\"\""},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"        if (\u0027requested_resources\u0027 in self and"},{"line_number":886,"context_line":"                self.requested_resources is not None):"},{"line_number":887,"context_line":"            return {"},{"line_number":888,"context_line":"                group.requester_id: group.provider_uuids"},{"line_number":889,"context_line":"                for group in self.requested_resources"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_61ef83b1","line":886,"range":{"start_line":886,"start_character":40,"end_line":886,"end_character":52},"updated":"2019-11-29 15:44:25.000000000","message":"nit: probably don\u0027t need this","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c5f45ed64e7f58440f9d79df22c52674e94c1b9e","unresolved":false,"context_lines":[{"line_number":883,"context_line":"        \"\"\""},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"        if (\u0027requested_resources\u0027 in self and"},{"line_number":886,"context_line":"                self.requested_resources is not None):"},{"line_number":887,"context_line":"            return {"},{"line_number":888,"context_line":"                group.requester_id: group.provider_uuids"},{"line_number":889,"context_line":"                for group in self.requested_resources"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_462b47e9","line":886,"range":{"start_line":886,"start_character":40,"end_line":886,"end_character":52},"in_reply_to":"3fa7e38b_0cb7d423","updated":"2019-12-04 10:38:34.000000000","message":"I meant you could have dropped the \u0027is not None\u0027 and relied on None being falsey","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac90b21e2b861ee6aaf1628ec9ed7ed9d354e253","unresolved":false,"context_lines":[{"line_number":883,"context_line":"        \"\"\""},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"        if (\u0027requested_resources\u0027 in self and"},{"line_number":886,"context_line":"                self.requested_resources is not None):"},{"line_number":887,"context_line":"            return {"},{"line_number":888,"context_line":"                group.requester_id: group.provider_uuids"},{"line_number":889,"context_line":"                for group in self.requested_resources"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_fbb0a1de","line":886,"range":{"start_line":886,"start_character":40,"end_line":886,"end_character":52},"in_reply_to":"3fa7e38b_462b47e9","updated":"2019-12-06 15:20:47.000000000","message":"but an empty list is also Falsey and for that we now return {}","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fd743ce509b8691cb709d0ce40eef45dc72d81cb","unresolved":false,"context_lines":[{"line_number":883,"context_line":"        \"\"\""},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"        if (\u0027requested_resources\u0027 in self and"},{"line_number":886,"context_line":"                self.requested_resources is not None):"},{"line_number":887,"context_line":"            return {"},{"line_number":888,"context_line":"                group.requester_id: group.provider_uuids"},{"line_number":889,"context_line":"                for group in self.requested_resources"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0cb7d423","line":886,"range":{"start_line":886,"start_character":40,"end_line":886,"end_character":52},"in_reply_to":"3fa7e38b_61ef83b1","updated":"2019-12-03 09:59:30.000000000","message":"requested_resource field in nullable so I need to check for it.","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd5839ea60ed84b9524c291e7c864e3bd110a429","unresolved":false,"context_lines":[{"line_number":888,"context_line":"                group.requester_id: group.provider_uuids"},{"line_number":889,"context_line":"                for group in self.requested_resources"},{"line_number":890,"context_line":"            }"},{"line_number":891,"context_line":"        else:"},{"line_number":892,"context_line":"            return None"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"@base.NovaObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c1f2f79b","line":892,"range":{"start_line":891,"start_character":0,"end_line":892,"end_character":23},"updated":"2019-11-29 15:44:25.000000000","message":"nit: don\u0027t need this","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fd743ce509b8691cb709d0ce40eef45dc72d81cb","unresolved":false,"context_lines":[{"line_number":888,"context_line":"                group.requester_id: group.provider_uuids"},{"line_number":889,"context_line":"                for group in self.requested_resources"},{"line_number":890,"context_line":"            }"},{"line_number":891,"context_line":"        else:"},{"line_number":892,"context_line":"            return None"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"@base.NovaObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6c5688d1","line":892,"range":{"start_line":891,"start_character":0,"end_line":892,"end_character":23},"in_reply_to":"3fa7e38b_c1f2f79b","updated":"2019-12-03 09:59:30.000000000","message":"Done","commit_id":"4fbbe31d0966b8fa36873cb8f05b476bc3765f78"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"918607ad2d506b605f8d83ca8675d03f9abf0e35","unresolved":false,"context_lines":[{"line_number":12746,"context_line":"            limits \u003d {}"},{"line_number":12747,"context_line":""},{"line_number":12748,"context_line":"        @mock.patch("},{"line_number":12749,"context_line":"            \u0027nova.objects.RequestSpec.get_request_group_mapping\u0027,"},{"line_number":12750,"context_line":"            return_value\u003dmock.sentinel.mapping)"},{"line_number":12751,"context_line":"        @mock.patch("},{"line_number":12752,"context_line":"            \u0027nova.compute.manager.ComputeManager\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_039dd6b9","line":12749,"updated":"2019-12-11 16:25:10.000000000","message":"Why does this need to change?","commit_id":"1997ffdc09ed9029a82c4dad60254cdf4dc77f39"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"893fe37ab902f2a09c632c1b973dc6e5211e413d","unresolved":false,"context_lines":[{"line_number":12746,"context_line":"            limits \u003d {}"},{"line_number":12747,"context_line":""},{"line_number":12748,"context_line":"        @mock.patch("},{"line_number":12749,"context_line":"            \u0027nova.objects.RequestSpec.get_request_group_mapping\u0027,"},{"line_number":12750,"context_line":"            return_value\u003dmock.sentinel.mapping)"},{"line_number":12751,"context_line":"        @mock.patch("},{"line_number":12752,"context_line":"            \u0027nova.compute.manager.ComputeManager\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_344fdc8c","line":12749,"in_reply_to":"3fa7e38b_039dd6b9","updated":"2019-12-12 12:31:43.000000000","message":"There was a patch set when the whole compute manager method was moved (not just the internals refactored) so at that point this test needed to be changed. Not any more. So I reverted this change.","commit_id":"1997ffdc09ed9029a82c4dad60254cdf4dc77f39"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"918607ad2d506b605f8d83ca8675d03f9abf0e35","unresolved":false,"context_lines":[{"line_number":12770,"context_line":"                image_ref, injected_files, \u0027newpass\u0027, {}, bdms, recreate\u003dTrue,"},{"line_number":12771,"context_line":"                on_shared_storage\u003don_shared_storage, migration\u003dmigration,"},{"line_number":12772,"context_line":"                preserve_ephemeral\u003dFalse, scheduled_node\u003dnode, limits\u003dlimits,"},{"line_number":12773,"context_line":"                request_spec\u003dobjects.RequestSpec())"},{"line_number":12774,"context_line":"            if vm_states_is_stopped:"},{"line_number":12775,"context_line":"                mock_notify_rebuild.assert_has_calls(["},{"line_number":12776,"context_line":"                    mock.call(ctxt, self.inst, self.inst.host, phase\u003d\u0027start\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_63adaae8","line":12773,"updated":"2019-12-11 16:25:10.000000000","message":"or this? If you didn\u0027t change the above it would handle None and you wouldn\u0027t need this.","commit_id":"1997ffdc09ed9029a82c4dad60254cdf4dc77f39"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"893fe37ab902f2a09c632c1b973dc6e5211e413d","unresolved":false,"context_lines":[{"line_number":12770,"context_line":"                image_ref, injected_files, \u0027newpass\u0027, {}, bdms, recreate\u003dTrue,"},{"line_number":12771,"context_line":"                on_shared_storage\u003don_shared_storage, migration\u003dmigration,"},{"line_number":12772,"context_line":"                preserve_ephemeral\u003dFalse, scheduled_node\u003dnode, limits\u003dlimits,"},{"line_number":12773,"context_line":"                request_spec\u003dobjects.RequestSpec())"},{"line_number":12774,"context_line":"            if vm_states_is_stopped:"},{"line_number":12775,"context_line":"                mock_notify_rebuild.assert_has_calls(["},{"line_number":12776,"context_line":"                    mock.call(ctxt, self.inst, self.inst.host, phase\u003d\u0027start\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_f432a40e","line":12773,"in_reply_to":"3fa7e38b_63adaae8","updated":"2019-12-12 12:31:43.000000000","message":"Same as above, done","commit_id":"1997ffdc09ed9029a82c4dad60254cdf4dc77f39"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"918607ad2d506b605f8d83ca8675d03f9abf0e35","unresolved":false,"context_lines":[{"line_number":9954,"context_line":""},{"line_number":9955,"context_line":"    @mock.patch(\u0027nova.compute.rpcapi.ComputeAPI.resize_instance\u0027)"},{"line_number":9956,"context_line":"    @mock.patch(\u0027nova.compute.resource_tracker.ResourceTracker.resize_claim\u0027)"},{"line_number":9957,"context_line":"    @mock.patch(\u0027nova.objects.RequestSpec.get_request_group_mapping\u0027)"},{"line_number":9958,"context_line":"    @mock.patch.object(objects.Instance, \u0027save\u0027)"},{"line_number":9959,"context_line":"    def test_prep_resize_handles_legacy_request_spec("},{"line_number":9960,"context_line":"            self, mock_save, mock_get_mapping, mock_claim, mock_resize):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_43874e5c","line":9957,"updated":"2019-12-11 16:25:10.000000000","message":"I don\u0027t see why this needs to change.","commit_id":"1997ffdc09ed9029a82c4dad60254cdf4dc77f39"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"893fe37ab902f2a09c632c1b973dc6e5211e413d","unresolved":false,"context_lines":[{"line_number":9954,"context_line":""},{"line_number":9955,"context_line":"    @mock.patch(\u0027nova.compute.rpcapi.ComputeAPI.resize_instance\u0027)"},{"line_number":9956,"context_line":"    @mock.patch(\u0027nova.compute.resource_tracker.ResourceTracker.resize_claim\u0027)"},{"line_number":9957,"context_line":"    @mock.patch(\u0027nova.objects.RequestSpec.get_request_group_mapping\u0027)"},{"line_number":9958,"context_line":"    @mock.patch.object(objects.Instance, \u0027save\u0027)"},{"line_number":9959,"context_line":"    def test_prep_resize_handles_legacy_request_spec("},{"line_number":9960,"context_line":"            self, mock_save, mock_get_mapping, mock_claim, mock_resize):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_943570f8","line":9957,"in_reply_to":"3fa7e38b_43874e5c","updated":"2019-12-12 12:31:43.000000000","message":"Same as in the other unit test file. Reverted.","commit_id":"1997ffdc09ed9029a82c4dad60254cdf4dc77f39"}]}