)]}'
{"id":"openstack%2Fnova~697","triplet_id":"openstack%2Fnova~master~I7c0ea900225024e69a0265c430724930ce7b892d","project":"openstack/nova","branch":"master","topic":"bug/837687","hashtags":[],"change_id":"I7c0ea900225024e69a0265c430724930ce7b892d","subject":"Deallocate ip if build fails.","status":"MERGED","created":"2011-09-27 21:04:42.000000000","updated":"2011-09-30 17:14:24.000000000","submitted":"2011-09-30 17:14:23.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f156bd31238431c2e2e030724da997d663c362e0","_number":697,"virtual_id_number":697,"owner":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":1,"date":"2011-09-30 17:14:23.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":2,"date":"2011-09-30 16:55:21.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"date":"2011-09-30 16:55:25.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2011-09-30 16:08:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"date":"2011-09-30 15:34:31.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-09-28 17:58:12.000000000","updated_by":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"reviewer":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"state":"REVIEWER"},{"updated":"2011-09-30 16:08:10.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2011-09-30 16:55:21.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2011-09-30 17:14:23.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"cb2f2025abedff8b53752471dcff976618a9ade9","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2011-09-27 22:00:21.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"397d73e6491d9458daaa0c53db3dfcb2d6994719","author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"date":"2011-09-28 17:58:12.000000000","message":"Patch Set 1: Looks good to me, approved\n\nlooks good to me. Should solve the problem just fine. Also, just to note, deallocate_for_instance() does more than just update whhichever fixed ip(s) that the instance had allocated. It also takes care of disassociating floating ips and deleting vifs as well.","accounts_in_message":[],"_revision_number":1},{"id":"f95ddd708dd80f305fa04b6e2205d5b549871100","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-09-28 17:58:19.000000000","message":"Patch Set 1:\n\nBuild Started https://jenkins.openstack.org/job/nova-pep8/1417/ (1/3)","accounts_in_message":[],"_revision_number":1},{"id":"21fd46c043ef719708ec39215ebd8112092d14f0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-09-28 17:58:20.000000000","message":"Patch Set 1:\n\nBuild Started https://jenkins.openstack.org/job/nova-merge/45/ (2/3)","accounts_in_message":[],"_revision_number":1},{"id":"b2d64ca11f5c5195c055990f421304c253f9af2d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-09-28 17:58:52.000000000","message":"Patch Set 1:\n\nBuild Started https://jenkins.openstack.org/job/nova/121562/ (3/3)","accounts_in_message":[],"_revision_number":1},{"id":"ab8a805014ec2300d53ce1ca9b12eef198cb13ad","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-09-28 18:08:08.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nBuild Unstable \n \nhttps://jenkins.openstack.org/job/nova-pep8/1417/ : UNSTABLE \nhttps://jenkins.openstack.org/job/nova-merge/45/ : SUCCESS \nhttps://jenkins.openstack.org/job/nova/121562/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"540d965a44e21aea7b942f25e2788f9129f787b3","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-09-30 06:00:40.000000000","message":"Patch Set 1:\n\nI found a workaround, because we use a 3 arg raise in nova/exception.py and that one is fine.  It appears if you change:\n\nraise type_, value, traceback\n\nto this:\n\nexc_info \u003d (type_, value, traceback)\nraise exc_info[0], exc_info[1], exc_info[2]\n\npep8 will pass with the above.  I\u0027m guessing the brackets make it pass.  This is definitely a pep8 bug.","accounts_in_message":[],"_revision_number":1},{"id":"61be479daf94b9bee89cfae9046cd72eba33da50","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-09-30 06:11:40.000000000","message":"Patch Set 1:\n\nNow that I actually looked at your diff, you can simply:  exc_info \u003d sys.exc_info() in place of breaking it out..\n\nAnd when you re-raise, use exc_info[0], ....\n\nThat\u0027ll be pretty clean.... and pass pep8.","accounts_in_message":[],"_revision_number":1},{"id":"40397317c8c2cfd4399f9681ee120360d412d8fd","author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"date":"2011-09-30 15:34:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f7eb86d23ac66c31094dad0e6244f978c0810bc8","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-09-30 16:08:10.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nlgtm.","accounts_in_message":[],"_revision_number":2},{"id":"0586c63e6bdbdf3e5cfd00c2b42b65729235327c","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2011-09-30 16:55:21.000000000","message":"Patch Set 2: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"7611266b7e4805c9d020706cafe67536829c2d80","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-09-30 16:55:25.000000000","message":"Patch Set 2:\n\nBuild Started https://jenkins.openstack.org/job/nova-pep8/1430/ (1/3)","accounts_in_message":[],"_revision_number":2},{"id":"04c79b1ae6f18afda36cacd460f80458b15a7cd7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-09-30 16:56:09.000000000","message":"Patch Set 2:\n\nBuild Started https://jenkins.openstack.org/job/nova-merge/58/ (2/3)","accounts_in_message":[],"_revision_number":2},{"id":"7778e5c1c8af3d2a1f66f85c0f98809670b7eb9e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-09-30 17:04:41.000000000","message":"Patch Set 2:\n\nBuild Started https://jenkins.openstack.org/job/nova/121575/ (3/3)","accounts_in_message":[],"_revision_number":2},{"id":"584419f7306bf6b75bf5aff80e76db5d3e400803","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-09-30 17:14:23.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/nova-pep8/1430/ : SUCCESS \nhttps://jenkins.openstack.org/job/nova-merge/58/ : SUCCESS \nhttps://jenkins.openstack.org/job/nova/121575/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"c54aaccf14e87dcde794af5fd59086cade77d9c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-09-30 17:14:24.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f225ea4f2ffcf0343722aa370dd615ee0effe305","revisions":{"422ec3599b3e0baaa05e1907dbe446ce8dbf41ac":{"kind":"REWORK","_number":1,"created":"2011-09-27 21:04:42.000000000","uploader":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"ref":"refs/changes/97/697/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/97/697/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/97/697/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/97/697/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/97/697/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/97/697/1"}}},"commit":{"parents":[{"commit":"a2646129bc9dbd9dec57bdde7f510e0ea7bbddea","subject":"Merge \"compute_api create*() and schedulers refactoring\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a2646129bc9dbd9dec57bdde7f510e0ea7bbddea"}]}],"author":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2011-09-27 21:05:31.000000000","tz":0},"committer":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2011-09-27 21:05:45.000000000","tz":0},"subject":"Deallocate ip if build fails.","message":"Deallocate ip if build fails.\n\nFixes LP837687\n\nChange-Id: I7c0ea900225024e69a0265c430724930ce7b892d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/422ec3599b3e0baaa05e1907dbe446ce8dbf41ac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/422ec3599b3e0baaa05e1907dbe446ce8dbf41ac"}]},"branch":"refs/heads/master"},"f225ea4f2ffcf0343722aa370dd615ee0effe305":{"kind":"REWORK","_number":2,"created":"2011-09-30 15:34:31.000000000","uploader":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"ref":"refs/changes/97/697/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/97/697/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/97/697/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/97/697/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/97/697/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/97/697/2"}}},"commit":{"parents":[{"commit":"a2646129bc9dbd9dec57bdde7f510e0ea7bbddea","subject":"Merge \"compute_api create*() and schedulers refactoring\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a2646129bc9dbd9dec57bdde7f510e0ea7bbddea"}]}],"author":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2011-09-27 21:05:31.000000000","tz":0},"committer":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2011-09-30 15:33:15.000000000","tz":-300},"subject":"Deallocate ip if build fails.","message":"Deallocate ip if build fails.\n\nFixes LP837687\n\nChange-Id: I7c0ea900225024e69a0265c430724930ce7b892d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f225ea4f2ffcf0343722aa370dd615ee0effe305"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f225ea4f2ffcf0343722aa370dd615ee0effe305"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}