)]}'
{"nova/quota.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4523817a51749ab176557a66561b152ea1a35c83","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            # an entry for the resource in the default class, it uses the"},{"line_number":73,"context_line":"            # config option."},{"line_number":74,"context_line":"            quotas[resource.name] \u003d default_quotas.get(resource.name,"},{"line_number":75,"context_line":"                                                       resource.default)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return quotas"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_6c694ff5","line":75,"updated":"2020-01-22 21:49:14.000000000","message":"Note to self: at first this logic alarmed me because I wondered, if we remove the config options for the deprecated quotas, how will they be handled if they\u0027ve never been set via the quota-sets API if there\u0027s no config option to fall back on? (continued)","commit_id":"5d93f088f43fc404b248abdf777d6b5257c2488b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4523817a51749ab176557a66561b152ea1a35c83","unresolved":false,"context_lines":[{"line_number":786,"context_line":"    @property"},{"line_number":787,"context_line":"    def default(self):"},{"line_number":788,"context_line":"        \"\"\"Return the default value of the quota.\"\"\""},{"line_number":789,"context_line":"        return CONF.quota[self.flag] if self.flag else -1"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"class AbsoluteResource(BaseResource):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_ec4d3f93","line":789,"updated":"2020-01-22 21:49:14.000000000","message":"(continued) Then I found this logic, which falls back on unlimited if there\u0027s no config flag set. (continued)","commit_id":"5d93f088f43fc404b248abdf777d6b5257c2488b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c9ec49277b42166cce2e570fe67b4d85972a61cb","unresolved":false,"context_lines":[{"line_number":1312,"context_line":"        CountableResource("},{"line_number":1313,"context_line":"            \u0027server_group_members\u0027, _server_group_count_members_by_user,"},{"line_number":1314,"context_line":"            \u0027server_group_members\u0027),"},{"line_number":1315,"context_line":"        # Deprecated nova-network quotas, retained to avoid changing API"},{"line_number":1316,"context_line":"        # responses"},{"line_number":1317,"context_line":"        AbsoluteResource(\u0027fixed_ips\u0027),"},{"line_number":1318,"context_line":"        AbsoluteResource(\u0027floating_ips\u0027),"},{"line_number":1319,"context_line":"        AbsoluteResource(\u0027security_groups\u0027),"},{"line_number":1320,"context_line":"        AbsoluteResource(\u0027security_group_rules\u0027),"},{"line_number":1321,"context_line":"    ],"},{"line_number":1322,"context_line":")"},{"line_number":1323,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_ca963cef","line":1320,"range":{"start_line":1315,"start_character":0,"end_line":1320,"end_character":49},"updated":"2020-01-21 18:54:01.000000000","message":"we should update api-ref also as they are not countable and ignored \n- https://docs.openstack.org/api-ref/compute/?expanded\u003dshow-a-quota-detail","commit_id":"5d93f088f43fc404b248abdf777d6b5257c2488b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4523817a51749ab176557a66561b152ea1a35c83","unresolved":false,"context_lines":[{"line_number":1312,"context_line":"        CountableResource("},{"line_number":1313,"context_line":"            \u0027server_group_members\u0027, _server_group_count_members_by_user,"},{"line_number":1314,"context_line":"            \u0027server_group_members\u0027),"},{"line_number":1315,"context_line":"        # Deprecated nova-network quotas, retained to avoid changing API"},{"line_number":1316,"context_line":"        # responses"},{"line_number":1317,"context_line":"        AbsoluteResource(\u0027fixed_ips\u0027),"},{"line_number":1318,"context_line":"        AbsoluteResource(\u0027floating_ips\u0027),"},{"line_number":1319,"context_line":"        AbsoluteResource(\u0027security_groups\u0027),"},{"line_number":1320,"context_line":"        AbsoluteResource(\u0027security_group_rules\u0027),"},{"line_number":1321,"context_line":"    ],"},{"line_number":1322,"context_line":")"},{"line_number":1323,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_6c370fff","line":1320,"range":{"start_line":1315,"start_character":0,"end_line":1320,"end_character":49},"in_reply_to":"3fa7e38b_ca963cef","updated":"2020-01-22 21:49:14.000000000","message":"(continued) Then, I see that these are indeed not setting the \u0027flag\u0027 kwarg and thus will fall back on unlimited for not having a config option at all. So, this all works out.","commit_id":"5d93f088f43fc404b248abdf777d6b5257c2488b"}]}
