)]}'
{"nova/api/openstack/compute/floating_ip_pools.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5c79a40039e15943f533ac74ebd125bab0d6ce60","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def _translate_floating_ip_view(pool):"},{"line_number":23,"context_line":"    return {"},{"line_number":24,"context_line":"        \u0027name\u0027: pool[\u0027name\u0027] or pool[\u0027id\u0027],"},{"line_number":25,"context_line":"    }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa7e38b_e56c89d0","line":24,"range":{"start_line":24,"start_character":29,"end_line":24,"end_character":43},"updated":"2020-01-21 19:08:56.000000000","message":"this need to be updated in api-ref too\n- https://github.com/openstack/nova/blob/8e779d9221994889a9cfbd1043e9ce2a428a4cd8/api-ref/source/parameters.yaml#L3214","commit_id":"95d71b9628d15f3606eb03585f446134f18e1c2c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"913b0acd086508d2e0c78996d6f6354b008c174a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def _translate_floating_ip_view(pool):"},{"line_number":23,"context_line":"    return {"},{"line_number":24,"context_line":"        \u0027name\u0027: pool[\u0027name\u0027] or pool[\u0027id\u0027],"},{"line_number":25,"context_line":"    }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_bd6cc59e","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":43},"updated":"2020-02-03 14:53:06.000000000","message":"this seams like an unrelated change but i guess its fine","commit_id":"6b44628695301ee446d019c21a44e34cedfac970"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"913b0acd086508d2e0c78996d6f6354b008c174a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \"\"\"Return a list of pools.\"\"\""},{"line_number":46,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":47,"context_line":"        context.can(fip_policies.BASE_POLICY_NAME)"},{"line_number":48,"context_line":"        pools \u003d self.network_api.get_floating_ip_pools(context)"},{"line_number":49,"context_line":"        return _translate_floating_ip_pools_view(pools)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_bddfe537","line":48,"range":{"start_line":48,"start_character":7,"end_line":48,"end_character":63},"updated":"2020-02-03 14:53:06.000000000","message":"for the above change to work it means that this function is now returning different data then before","commit_id":"6b44628695301ee446d019c21a44e34cedfac970"}],"nova/api/openstack/compute/floating_ips.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0449c2a397ebc1805f89228a0d88e26f1c39b3f2","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _translate_floating_ip_view(floating_ip):"},{"line_number":39,"context_line":"    instance_id \u003d None"},{"line_number":40,"context_line":"    if floating_ip[\u0027port_details\u0027]:"},{"line_number":41,"context_line":"        instance_id \u003d floating_ip[\u0027port_details\u0027][\u0027device_id\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    return {"},{"line_number":44,"context_line":"        \u0027floating_ip\u0027: {"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_e0f6025f","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":62},"updated":"2020-02-04 14:33:55.000000000","message":"Looks like this is not correct. From [1]\n\n\u003cmaciejjozefczyk\u003e Huston, we have a problem. This recently merged change breaks ovn gates: https://review.opendev.org/#/c/697153/. We\u0027re looking for a solution.\n\u003cmaciejjozefczyk\u003e cc slaweq ralonsoh\n\u003chaleyb\u003e maciejjozefczyk: revert? :)\n\u003cralonsoh\u003e maciejjozefczyk, haleyb I think I can talk to stephenfin\n\u003cralonsoh\u003e stephenfin, https://review.opendev.org/#/c/697153/16/nova/api/openstack/compute/floating_ips.py\n\u003cralonsoh\u003e stephenfin, more exactly in https://review.opendev.org/#/c/697153/16/nova/api/openstack/compute/floating_ips.py@40\n\u003cralonsoh\u003e floating IP not always have \"port_details\"\n\u003cralonsoh\u003e this is an extension\n\u003cmaciejjozefczyk\u003e ralonsoh, ack\n\u003cralonsoh\u003e in this case, you should check that floating_ip.get(\u0027port_details\u0027)\n\u003chaleyb\u003e ralonsoh: i was just joking, i\u0027m only halfway through my coffee\n\u003cralonsoh\u003e stephenfin, this is from maciejjozefczyk logs\n\u003cralonsoh\u003e http://paste.openstack.org/show/789108/\n\u003cralonsoh\u003e and the error in the CI\n\u003cralonsoh\u003e https://0ebef4bf8afa09d1c4c9-5e4b426cf1ca8d9cb4613ee1042e28ab.ssl.cf5.rackcdn.com/704530/4/check/neutron-ovn-tempest-ovs-release/c0a29b4/testr_results.html\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-neutron/%23openstack-neutron.2020-02-04.log.html#t2020-02-04T14:09:16","commit_id":"6b44628695301ee446d019c21a44e34cedfac970"}],"nova/network/neutron.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a2c3032ebae1e74079036320eed66883ae950513","unresolved":false,"context_lines":[{"line_number":2597,"context_line":"            fip[\u0027network_details\u0027] \u003d client.show_network("},{"line_number":2598,"context_line":"                network_uuid)[\u0027network\u0027]"},{"line_number":2599,"context_line":"        except neutron_client_exc.NetworkNotFoundClient:"},{"line_number":2600,"context_line":"            raise exception.NetworkNotFound(network_id\u003dnetwork_uuid)"},{"line_number":2601,"context_line":""},{"line_number":2602,"context_line":"        return fip"},{"line_number":2603,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa7e38b_1c3597a7","line":2600,"range":{"start_line":2600,"start_character":0,"end_line":2600,"end_character":68},"updated":"2020-01-20 15:30:02.000000000","message":"Does this creates a new case when the REST API returns an error?","commit_id":"95d71b9628d15f3606eb03585f446134f18e1c2c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6aa92b953283a10d1c8102ee5f7688510b391e21","unresolved":false,"context_lines":[{"line_number":2597,"context_line":"            fip[\u0027network_details\u0027] \u003d client.show_network("},{"line_number":2598,"context_line":"                network_uuid)[\u0027network\u0027]"},{"line_number":2599,"context_line":"        except neutron_client_exc.NetworkNotFoundClient:"},{"line_number":2600,"context_line":"            raise exception.NetworkNotFound(network_id\u003dnetwork_uuid)"},{"line_number":2601,"context_line":""},{"line_number":2602,"context_line":"        return fip"},{"line_number":2603,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa7e38b_9cef47b1","line":2600,"range":{"start_line":2600,"start_character":0,"end_line":2600,"end_character":68},"in_reply_to":"3fa7e38b_1c3597a7","updated":"2020-01-20 15:36:36.000000000","message":"Yes and no. This is a new exception type that we don\u0027t appear to be handling. However, there was no exception handling on the previous calls (\u0027NetworkNotFoundClient\u0027 raised from \u0027_setup_net_dict\u0027) so this is no worse than before. I could handle this and add tests in a follow-up if you like?","commit_id":"95d71b9628d15f3606eb03585f446134f18e1c2c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e39b537955fa79471f7651c1f637a20e5ec6e4f6","unresolved":false,"context_lines":[{"line_number":2597,"context_line":"            fip[\u0027network_details\u0027] \u003d client.show_network("},{"line_number":2598,"context_line":"                network_uuid)[\u0027network\u0027]"},{"line_number":2599,"context_line":"        except neutron_client_exc.NetworkNotFoundClient:"},{"line_number":2600,"context_line":"            raise exception.NetworkNotFound(network_id\u003dnetwork_uuid)"},{"line_number":2601,"context_line":""},{"line_number":2602,"context_line":"        return fip"},{"line_number":2603,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa7e38b_bc080380","line":2600,"range":{"start_line":2600,"start_character":0,"end_line":2600,"end_character":68},"in_reply_to":"3fa7e38b_9cef47b1","updated":"2020-01-20 15:39:59.000000000","message":"I missed that a similarly unhandled exception could be raised from _setup_net_dict. Then this is not make the situation worse. Thanks.","commit_id":"95d71b9628d15f3606eb03585f446134f18e1c2c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"913b0acd086508d2e0c78996d6f6354b008c174a","unresolved":false,"context_lines":[{"line_number":2626,"context_line":"        \"\"\"Return floating IP pool names.\"\"\""},{"line_number":2627,"context_line":"        client \u003d get_client(context)"},{"line_number":2628,"context_line":"        pools \u003d self._get_floating_ip_pools(client)"},{"line_number":2629,"context_line":"        return [n[\u0027name\u0027] or n[\u0027id\u0027] for n in pools]"},{"line_number":2630,"context_line":""},{"line_number":2631,"context_line":"    def _make_floating_ip_obj(self, context, fip, pool_dict, port_dict):"},{"line_number":2632,"context_line":"        pool \u003d pool_dict[fip[\u0027floating_network_id\u0027]]"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_fd979de9","side":"PARENT","line":2629,"range":{"start_line":2629,"start_character":13,"end_line":2629,"end_character":52},"updated":"2020-02-03 14:53:06.000000000","message":"this is where the  pool[\u0027name\u0027] or pool[\u0027id\u0027],\n\nfiltering used to happen. i agree that actully returnning the pools makes more sense given the name.","commit_id":"e10c6125f8327f1fa7650c21115a3076e6c5f706"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"913b0acd086508d2e0c78996d6f6354b008c174a","unresolved":false,"context_lines":[{"line_number":2604,"context_line":"    def get_floating_ip_pools(self, context):"},{"line_number":2605,"context_line":"        \"\"\"Return floating IP pools a.k.a. external networks.\"\"\""},{"line_number":2606,"context_line":"        client \u003d get_client(context)"},{"line_number":2607,"context_line":"        data \u003d client.list_networks(**{constants.NET_EXTERNAL: True})"},{"line_number":2608,"context_line":"        return data[\u0027networks\u0027]"},{"line_number":2609,"context_line":""},{"line_number":2610,"context_line":"    def get_floating_ip_by_address(self, context, address):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_3d24551a","line":2607,"range":{"start_line":2607,"start_character":36,"end_line":2607,"end_character":68},"updated":"2020-02-03 14:53:06.000000000","message":"that is an iteresting way to do that... but i see you are doining it since router:external cant normally be a kwarg","commit_id":"6b44628695301ee446d019c21a44e34cedfac970"}]}