)]}'
{"nova/db/sqlalchemy/models.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"64f572b1ee004644a3fe42a507727083dc095647","unresolved":false,"context_lines":[{"line_number":691,"context_line":""},{"line_number":692,"context_line":"# TODO(stephenfin): Remove this in the V release or later, once we\u0027re sure we"},{"line_number":693,"context_line":"# won\u0027t want it back (it\u0027s for nova-network, so we won\u0027t)"},{"line_number":694,"context_line":"class SecurityGroupIngressRule(BASE, NovaBase, models.SoftDeleteMixin):"},{"line_number":695,"context_line":"    \"\"\"Represents a rule in a security group.\"\"\""},{"line_number":696,"context_line":"    __tablename__ \u003d \u0027security_group_rules\u0027"},{"line_number":697,"context_line":"    __table_args__ \u003d ()"}],"source_content_type":"text/x-python","patch_set":30,"id":"1fa4df85_243a7098","line":694,"updated":"2020-03-06 10:34:09.000000000","message":"Part of me expected to see these just get deleted.","commit_id":"998475f5bdb1fa1473716d93a60999c66f88dc68"}],"nova/objects/network.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0f86d880f8fe876a44d4bcfb731d3b5e2d45a0da","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(berrange): Remove NovaObjectDictCompat"},{"line_number":25,"context_line":"# TODO(stephenfin): Move this to os-vif, which is the only use of this now"},{"line_number":26,"context_line":"@obj_base.NovaObjectRegistry.register"},{"line_number":27,"context_line":"class Network(obj_base.NovaObject, obj_base.NovaObjectDictCompat):"},{"line_number":28,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_138d4f34","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":74},"updated":"2020-01-23 11:50:59.000000000","message":"we do not use the netwrok object in os-vif we have our own so this should not be moved to os-vif\ni contains a lot of irrelevent crap that are not properties of the netwok in neutron and are not needed for os-vif\n\nthis is our exisiting network object \nhttps://github.com/openstack/os-vif/blob/master/os_vif/objects/network.py#L22-L53\n\n\nwhich has some fields in it that are only exist for nova network like multi_host that we shoudl be able to remove.\n\ni have not fully review this patch but i dont expect there to be a need to move any of these object to os-vif","commit_id":"f1c23fec203c4dd13121638794f318b1cbf037f9"}],"nova/tests/unit/objects/test_network.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f347363d09d0aa4cb6a551b678df50dc39688aee","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        get_nets.assert_called_once_with(self.context, 123, associate\u003dTrue)"},{"line_number":213,"context_line":"        self._compare(networks[0], fake_network)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def test_compat_version_1_1(self):"},{"line_number":216,"context_line":"        network \u003d network_obj.Network._from_db_object(self.context,"},{"line_number":217,"context_line":"                                                      network_obj.Network(),"},{"line_number":218,"context_line":"                                                      fake_network)"},{"line_number":219,"context_line":"        primitive \u003d network.obj_to_primitive(target_version\u003d\u00271.1\u0027)"},{"line_number":220,"context_line":"        self.assertNotIn(\u0027mtu\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":221,"context_line":"        self.assertNotIn(\u0027enable_dhcp\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":222,"context_line":"        self.assertNotIn(\u0027dhcp_server\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":223,"context_line":"        self.assertNotIn(\u0027share_address\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        primitive \u003d network.obj_to_primitive(target_version\u003d\u00271.2\u0027)"},{"line_number":226,"context_line":"        self.assertIn(\u0027mtu\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":227,"context_line":"        self.assertIn(\u0027enable_dhcp\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":228,"context_line":"        self.assertIn(\u0027dhcp_server\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":229,"context_line":"        self.assertIn(\u0027share_address\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class TestNetworkObject(test_objects._LocalTest,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_13df8f38","side":"PARENT","line":229,"range":{"start_line":215,"start_character":0,"end_line":229,"end_character":69},"updated":"2020-01-23 11:47:47.000000000","message":"Whoops, should have kept this","commit_id":"4ea5217270680d59f01509625198b435dbacc619"}]}