)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cb62074e1799672e59de11ff4b18b6fd4a8957d5","unresolved":false,"context_lines":[{"line_number":981,"context_line":"        :return: The custom owner trait or None."},{"line_number":982,"context_line":"        \"\"\""},{"line_number":983,"context_line":"        owner \u003d getattr(node, \u0027owner\u0027, None)"},{"line_number":984,"context_line":"        return \u0027CUSTOM_OWNER_%s\u0027 % owner if owner else None"},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"    def get_available_resource(self, nodename):"},{"line_number":987,"context_line":"        \"\"\"Retrieve resource information."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3f81774e","line":984,"range":{"start_line":984,"start_character":16,"end_line":984,"end_character":29},"updated":"2019-12-03 21:45:31.000000000","message":"Consider using os_traits.normalize_name here. Swhat it\u0027s for.\n\n(Is the node.owner field restricted to the same characters as a custom trait? Does that impact the ability to correlate it?)","commit_id":"502736a0ba94c287def46118a2e207a61c6cde8f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d68649b08f5c23f2765c0d6e01f14484e2792f0a","unresolved":false,"context_lines":[{"line_number":981,"context_line":"        :return: The custom owner trait or None."},{"line_number":982,"context_line":"        \"\"\""},{"line_number":983,"context_line":"        owner \u003d getattr(node, \u0027owner\u0027, None)"},{"line_number":984,"context_line":"        return \u0027CUSTOM_OWNER_%s\u0027 % owner if owner else None"},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"    def get_available_resource(self, nodename):"},{"line_number":987,"context_line":"        \"\"\"Retrieve resource information."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9fb74b22","line":984,"range":{"start_line":984,"start_character":16,"end_line":984,"end_character":29},"in_reply_to":"3fa7e38b_3f81774e","updated":"2019-12-03 21:52:05.000000000","message":"Hmm, I didn\u0027t think about that but if the owner is a project ID then it will have dashes rather than underscores and probably lower-case rather than upper-case letters so that\u0027s not going to fly.\n\nAnyway this traits approach to the filtering problem likely won\u0027t work because of mixed hypervisor deployments:\n\nhttps://review.opendev.org/#/c/697187/1/nova/scheduler/request_filter.py@246","commit_id":"502736a0ba94c287def46118a2e207a61c6cde8f"}]}