)]}'
{"id":"openstack%2Fnova~697398","triplet_id":"openstack%2Fnova~stable%2Fqueens~Ic2b82146d28be64b363b0b8e2e8d180b515bc0a0","project":"openstack/nova","branch":"stable/queens","topic":"bug/1780799","hashtags":[],"change_id":"Ic2b82146d28be64b363b0b8e2e8d180b515bc0a0","subject":"delete consumers which no longer have allocations","status":"ABANDONED","created":"2019-12-05 01:51:03.000000000","updated":"2022-11-11 18:24:43.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"195bc184074e563b69633410b83cd8772a987825","_number":697398,"virtual_id_number":697398,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2019-12-05 03:49:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"date":"2019-12-05 01:57:31.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"date":"2019-12-05 12:39:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"date":"2019-12-05 02:00:49.000000000","_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"date":"2019-12-05 02:54:18.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2020-01-20 14:00:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-12-30 22:44:04.000000000","_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"date":"2019-12-05 01:51:03.000000000","_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-05 01:51:03.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2019-12-05 01:57:31.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2019-12-05 02:54:18.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-12-05 03:49:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-05 12:39:47.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-30 22:44:04.000000000","updated_by":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"reviewer":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"state":"REVIEWER"},{"updated":"2020-01-20 14:00:33.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"}],"messages":[{"id":"534501db66fdda658607808612da5d3227f0547c","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-12-05 01:51:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3f1c9856fb0069d7fc0de511a4b08eb6eb7eb390","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-12-05 01:57:31.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/98/697398/1/check/pmem-tempest-plugin-filtered/fb06f22/ : POST_FAILURE in 5m 13s","accounts_in_message":[],"_revision_number":1},{"id":"6b3bc1d394c5cdac4506637a21eaf726870d6630","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-12-05 02:00:49.000000000","message":"Patch Set 1:\n\nI\u0027m proposing this because we need it downstream. We\u0027re running OSP13 (Queens) for some internal infrastructure and the operators of the deployment recently noticed over 4M rows in the consumers table. Cleanup of consumer records was added in Rocky, so in Queens there\u0027s currently no way to clean up the consumers table (which maps to instances, essentially) other than manual sql queries.\n\nI went ahead and tried this backport, at first it looked really bad but once I found the old locations in Queens for the relevant code, it wasn\u0027t too terrible. What do you think?","accounts_in_message":[],"_revision_number":1},{"id":"82444db42ae23f9519db1917ba4a4351ffcaae1d","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-12-05 02:54:18.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/697398/1 : FAILURE in 1h 02m 08s","accounts_in_message":[],"_revision_number":1},{"id":"1b4b042e0397efed2a903ff4e68f6092dcab93b6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-05 03:49:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a0449760554442eaab26567de6ffcd01 : SUCCESS in 10m 42s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/af123911b3044c8ca297f78daee00d40 : SUCCESS in 12m 14s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/63e1819bf7ab47f0a2d40c8a00d145cb : SUCCESS in 12m 30s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/78e38f6cf3f144b7868d1d2996c183aa : SUCCESS in 6m 05s\n- tempest-full https://zuul.opendev.org/t/openstack/build/dc2a43f1d6c54fcbafc8e4a0f5993c53 : SUCCESS in 1h 31m 15s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/3f64459a7f8740ad932e3400dadcc67d : SUCCESS in 1h 01m 34s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/80d3a6b960964848b77ea85a5c3bb0e9 : SUCCESS in 1h 24m 27s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/8508d40c15b641afa18927466badf4cd : SUCCESS in 46m 06s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/fc5fc0b67269416bb9777107c94d5a71 : SUCCESS in 47m 37s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/a8b0605665ab4e6fa93a2d42b1cabc70 : SUCCESS in 1h 05m 58s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/a378c87ecee944e9b28ce143e88772cc : SUCCESS in 46m 24s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/08a534348d7943faa5e2b95ef88b827b : SUCCESS in 53m 24s\n- nova-next https://zuul.opendev.org/t/openstack/build/1ca9410b64164fbabff156812faf43c4 : SUCCESS in 1h 33m 07s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/394bcd43e3d84fab942ae572ffec4dd1 : SUCCESS in 1h 53m 16s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/707b98666a51427283c744202e6992b6 : SUCCESS in 19m 31s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/cfa05f767e234397bad2e76cee4d7490 : SUCCESS in 18m 17s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/970b62dd3e464c4c8fde637469626c1b : SUCCESS in 1h 05m 13s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/c90b94d81c254ffca7ae62a2118d7def : SUCCESS in 1h 06m 42s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/05396267b5ac41ffb0d1c31efe69c2b9 : SUCCESS in 1h 32m 28s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b76e269da3c09e5428d9676e746be77b7df1f0de","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-12-05 12:39:47.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/98/697398/1/check/tempest-dsvm-full-xenial/0156f10/ : SUCCESS in 2h 28m 31s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/98/697398/1/check/tempest-dsvm-full-xenial-py3/2650942/ : FAILURE in 2h 34m 04s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/98/697398/1/check/grenade-dsvm-xenial/2a49d87/ : FAILURE in 2h 56m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"379ca46f9538ff841c638e9abb8d3aea163cc767","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-01-20 14:00:33.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM, I\u0027ve already reviewed this heavily modified backport downstream and this unchanged upstream version still looks valid to me.","accounts_in_message":[],"_revision_number":1},{"id":"195bc184074e563b69633410b83cd8772a987825","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2022-11-11 18:24:43.000000000","message":"Abandoned\n\nThis branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"06d36fb35190366404fd2def4b9791388e158a1a","revisions":{"06d36fb35190366404fd2def4b9791388e158a1a":{"kind":"REWORK","_number":1,"created":"2019-12-05 01:51:03.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/98/697398/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/98/697398/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/697398/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/697398/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/697398/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/98/697398/1"}}},"commit":{"parents":[{"commit":"4fcb7816bc88fd513debe70b95aa60bff74e37fb","subject":"Fix false ERROR message at compute restart","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4fcb7816bc88fd513debe70b95aa60bff74e37fb"}]}],"author":{"name":"Jay Pipes","email":"jaypipes@gmail.com","date":"2019-12-04 19:13:17.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2019-12-05 01:49:18.000000000","tz":0},"subject":"delete consumers which no longer have allocations","message":"delete consumers which no longer have allocations\n\nWe made the decision [1] to delete consumer records when those consumers\nno longer had any allocations referring to them (as opposed to keeping\nthose consumer records around and incrementing the consumer generation\nfor them).\n\nThis patch adds a small check within the larger\nAllocationList.create_all() and AllocationList.delete_all() DB\ntransactions that deletes consumer records when no allocation records\nremain that reference that consumer. This patch does not, however,\nattempt to clean up any \"orphaned\" consumer records that may have been\ncreated in previous calls to PUT|POST /allocations that removed the last\nremaining allocations for a consumer.\n\n[1] https://goo.gl/DpAGbW\n\nCloses-bug: #1780799\n\nConflicts:\n  nova/api/openstack/placement/objects/consumer.py\n  nova/api/openstack/placement/objects/resource_provider.py\n  nova/tests/functional/api/openstack/placement/db/test_consumer.py\n\nNOTE(melwitt): This is a heavily hand-modified backport as the\nconsumer.py and test_consumer.py files do not exist in Queens. Changes\nare applied to resource_provider.py and test_resource_provider.py\ninstead as these are the appropriate locations for this functionality in\nQueens. Other than differences to use the appropriate Queens methods\nwhere the Rocky versions did not exist, the main difference from the\noriginal change is that the seen_consumers logic needed to be changed to\nadd a seen_consumer before the \u0027if alloc.used \u003d\u003d 0\u0027 loop continuation in\norder for detection and deletion of consumers without allocations to\nwork.\n\nChange-Id: Ic2b82146d28be64b363b0b8e2e8d180b515bc0a0\n(cherry picked from commit f0f680b492c82f4f5c4163b0534dacc315b6dce5)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/06d36fb35190366404fd2def4b9791388e158a1a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/06d36fb35190366404fd2def4b9791388e158a1a"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}