)]}'
{"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"39635b27eb1a6e3cce34d283c38c2014bb517036","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                      disk\u003d10, ephemeral\u003d10, swap\u003d0, rxtx_factor\u003d1.0,"},{"line_number":215,"context_line":"                      is_public\u003dTrue):"},{"line_number":216,"context_line":"        \"\"\"Build a request for the flavor create API."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        :param id: An ID for the flavor."},{"line_number":219,"context_line":"        :param name: A name for the flavor."},{"line_number":220,"context_line":"        :param memory_mb: The flavor memory."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9ef40a89","line":217,"updated":"2019-12-05 18:48:14.000000000","message":"While I appreciate a good docstring, the only useful thing about these param descriptions is the DEPRECATED tag on rxtx_factor. Otherwise\n\n :param $x: The flavor $x.\n\njust takes up vertical space.\n\nBut I can see where omitting them would tickle programmer OCD (and PyCharm) so meh.","commit_id":"44aff98fc0ce89feb0b0f47c280fb9620cc7de34"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"52fe314e9e5abe735154a60f5402bd911b7f6bce","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                      disk\u003d10, ephemeral\u003d10, swap\u003d0, rxtx_factor\u003d1.0,"},{"line_number":215,"context_line":"                      is_public\u003dTrue):"},{"line_number":216,"context_line":"        \"\"\"Build a request for the flavor create API."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        :param id: An ID for the flavor."},{"line_number":219,"context_line":"        :param name: A name for the flavor."},{"line_number":220,"context_line":"        :param memory_mb: The flavor memory."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7ba27141","line":217,"in_reply_to":"3fa7e38b_9ef40a89","updated":"2019-12-06 15:42:56.000000000","message":"Thought the exact same, but only once I had them typed out and at that point the sunk cost fallacy kicked in","commit_id":"44aff98fc0ce89feb0b0f47c280fb9620cc7de34"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cdebfc128ed240a2a1faf2b75fe6a101feb4a334","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        return api.post_aggregate(body)[\u0027id\u0027]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _build_flavor(self, id\u003dNone, name\u003dNone, memory_mb\u003d2048, vcpu\u003d2,"},{"line_number":215,"context_line":"                      disk\u003d10, ephemeral\u003d10, swap\u003d0, rxtx_factor\u003d1.0,"},{"line_number":216,"context_line":"                      is_public\u003dTrue):"},{"line_number":217,"context_line":"        \"\"\"Build a request for the flavor create API."},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_43d0aef4","line":215,"range":{"start_line":215,"start_character":22,"end_line":215,"end_character":51},"updated":"2019-12-11 16:42:25.000000000","message":"ah, the test fails are because we\u0027re now using this...","commit_id":"14204177ad4116691c5af66ca74cbd96334316e0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cdebfc128ed240a2a1faf2b75fe6a101feb4a334","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        }"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _create_flavor(self, id\u003dNone, name\u003dNone, memory_mb\u003d2048, vcpu\u003d2,"},{"line_number":252,"context_line":"                       disk\u003d10, ephemeral\u003d10, swap\u003d0, rxtx_factor\u003d1.0,"},{"line_number":253,"context_line":"                       is_public\u003dTrue, extra_spec\u003dNone):"},{"line_number":254,"context_line":"        \"\"\"Build and submit a request to the flavor create API."},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e3043a80","line":252,"range":{"start_line":252,"start_character":23,"end_line":252,"end_character":52},"updated":"2019-12-11 16:42:25.000000000","message":"...and/or this...","commit_id":"14204177ad4116691c5af66ca74cbd96334316e0"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cdebfc128ed240a2a1faf2b75fe6a101feb4a334","unresolved":false,"context_lines":[{"line_number":3838,"context_line":"                \u0027name\u0027: \u0027special\u0027,"},{"line_number":3839,"context_line":"                \u0027ram\u0027: 512,"},{"line_number":3840,"context_line":"                \u0027vcpus\u0027: 1,"},{"line_number":3841,"context_line":"                \u0027disk\u0027: 10,"},{"line_number":3842,"context_line":"                \u0027OS-FLV-EXT-DATA:ephemeral\u0027: 20,"},{"line_number":3843,"context_line":"                \u0027swap\u0027: 5 * 1024,"},{"line_number":3844,"context_line":"                \u0027rxtx_factor\u0027: 1.0,"},{"line_number":3845,"context_line":"                \u0027os-flavor-access:is_public\u0027: True,"},{"line_number":3846,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_83f3069f","side":"PARENT","line":3843,"range":{"start_line":3841,"start_character":16,"end_line":3843,"end_character":33},"updated":"2019-12-11 16:42:25.000000000","message":"...in tests that used to use this.","commit_id":"248edbaba6ac1fe3d623c9db3b20ebfc9c0c2fbe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da7d595038640e78e986c1d66af363516a932074","unresolved":false,"context_lines":[{"line_number":3838,"context_line":"                \u0027name\u0027: \u0027special\u0027,"},{"line_number":3839,"context_line":"                \u0027ram\u0027: 512,"},{"line_number":3840,"context_line":"                \u0027vcpus\u0027: 1,"},{"line_number":3841,"context_line":"                \u0027disk\u0027: 10,"},{"line_number":3842,"context_line":"                \u0027OS-FLV-EXT-DATA:ephemeral\u0027: 20,"},{"line_number":3843,"context_line":"                \u0027swap\u0027: 5 * 1024,"},{"line_number":3844,"context_line":"                \u0027rxtx_factor\u0027: 1.0,"},{"line_number":3845,"context_line":"                \u0027os-flavor-access:is_public\u0027: True,"},{"line_number":3846,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_06439ab1","side":"PARENT","line":3843,"range":{"start_line":3841,"start_character":16,"end_line":3843,"end_character":33},"in_reply_to":"3fa7e38b_83f3069f","updated":"2019-12-12 09:44:37.000000000","message":"Done","commit_id":"248edbaba6ac1fe3d623c9db3b20ebfc9c0c2fbe"}]}