)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1ec7887e0a051ad5ca25582c9e82750f2b7d795","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"functional: Add \u0027_create_server\u0027 helper"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a *very* common pattern. Centralize it. No users yet, but we\u0027ll"},{"line_number":10,"context_line":"add those later."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I84c58de90dad6d86271767363aef90ddac0f1730"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_7e74aed0","line":10,"range":{"start_line":9,"start_character":48,"end_line":10,"end_character":16},"updated":"2019-12-05 18:58:56.000000000","message":"I\u0027ll probably ask to squash those into this patch.","commit_id":"bb2ef92c546b3ee4c5e7097d96b3a1b83f41bf82"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c8cdfc2380a7fa8120175d8b40020ec1bb0e50f2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"functional: Add \u0027_create_server\u0027 helper"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a *very* common pattern. Centralize it. Only a few users are"},{"line_number":10,"context_line":"added for now, but we can migrate more later (it\u0027s rather tedious work)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I84c58de90dad6d86271767363aef90ddac0f1730"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_4ff57e51","line":10,"range":{"start_line":10,"start_character":46,"end_line":10,"end_character":70},"updated":"2020-01-21 17:56:23.000000000","message":"indeed.\n\nWould it be less tedious to add TODOs?","commit_id":"5b36d8c054571542e6a00f11f9db2b69e2b0017f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"81a18add1e9f49909df6be24e89b945880cbf658","unresolved":false,"context_lines":[{"line_number":7,"context_line":"functional: Add \u0027_create_server\u0027 helper"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a *very* common pattern. Centralize it. Only a few users are"},{"line_number":10,"context_line":"added for now, but we can migrate more later (it\u0027s rather tedious work)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I84c58de90dad6d86271767363aef90ddac0f1730"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_30fdf36c","line":10,"range":{"start_line":10,"start_character":46,"end_line":10,"end_character":70},"in_reply_to":"3fa7e38b_4ff57e51","updated":"2020-01-22 10:44:21.000000000","message":"Probably not. The tedious part if finding the places to replace and assessing whether they can be replaced. Just a copy-paste job after that","commit_id":"5b36d8c054571542e6a00f11f9db2b69e2b0017f"}],"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e5a6ff2458fa8f6e1e5e288333b9a591ded9e194","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return server"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def _create_server(self, name\u003dNone, image_uuid\u003dNone, flavor_id\u003dNone,"},{"line_number":325,"context_line":"                       networks\u003dNone, az\u003dNone, host\u003dNone,"},{"line_number":326,"context_line":"                       expected_state\u003d\u0027ACTIVE\u0027, api\u003dNone):"},{"line_number":327,"context_line":"        \"\"\"Build and submit a request to the server create API."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        :param name: A name for the server."}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_2e6feb61","line":326,"range":{"start_line":324,"start_character":0,"end_line":326,"end_character":58},"updated":"2020-01-21 13:06:53.000000000","message":"It feels like a good candidate to introduce keyword only args [1] to enforce readability on the caller side\n\n[1] https://www.python.org/dev/peps/pep-3102/","commit_id":"5b36d8c054571542e6a00f11f9db2b69e2b0017f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c8cdfc2380a7fa8120175d8b40020ec1bb0e50f2","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return server"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def _create_server(self, name\u003dNone, image_uuid\u003dNone, flavor_id\u003dNone,"},{"line_number":325,"context_line":"                       networks\u003dNone, az\u003dNone, host\u003dNone,"},{"line_number":326,"context_line":"                       expected_state\u003d\u0027ACTIVE\u0027, api\u003dNone):"},{"line_number":327,"context_line":"        \"\"\"Build and submit a request to the server create API."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        :param name: A name for the server."}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_2f636243","line":326,"range":{"start_line":324,"start_character":0,"end_line":326,"end_character":58},"in_reply_to":"3fa7e38b_2e6feb61","updated":"2020-01-21 17:56:23.000000000","message":"Neat","commit_id":"5b36d8c054571542e6a00f11f9db2b69e2b0017f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"81a18add1e9f49909df6be24e89b945880cbf658","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return server"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def _create_server(self, name\u003dNone, image_uuid\u003dNone, flavor_id\u003dNone,"},{"line_number":325,"context_line":"                       networks\u003dNone, az\u003dNone, host\u003dNone,"},{"line_number":326,"context_line":"                       expected_state\u003d\u0027ACTIVE\u0027, api\u003dNone):"},{"line_number":327,"context_line":"        \"\"\"Build and submit a request to the server create API."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        :param name: A name for the server."}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_d0f57f85","line":326,"range":{"start_line":324,"start_character":0,"end_line":326,"end_character":58},"in_reply_to":"3fa7e38b_2f636243","updated":"2020-01-22 10:44:21.000000000","message":"Good call. I\u0027ll do this next time I need to touch these (this was drafted before we dropped Python 2.7 so I couldn\u0027t do it then)","commit_id":"5b36d8c054571542e6a00f11f9db2b69e2b0017f"}],"nova/tests/functional/libvirt/test_vpmem.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e5a6ff2458fa8f6e1e5e288333b9a591ded9e194","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"},{"line_number":130,"context_line":"            flavor_id\u003dflavor_id,"},{"line_number":131,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":132,"context_line":"            az\u003d\u0027nova:%s\u0027 % hostname,"},{"line_number":133,"context_line":"            expected_state\u003dexpected_state)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _delete_server(self, server):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_6e3ac335","line":132,"updated":"2020-01-21 13:06:53.000000000","message":"we could use:\n\n  host\u003dhostname\n\nas well","commit_id":"5b36d8c054571542e6a00f11f9db2b69e2b0017f"}],"nova/tests/functional/test_availability_zones.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e5a6ff2458fa8f6e1e5e288333b9a591ded9e194","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _create_server(self, name):"},{"line_number":75,"context_line":"        # Create a server, it doesn\u0027t matter which host it ends up in."},{"line_number":76,"context_line":"        server \u003d super(TestAvailabilityZoneScheduling, self)._create_server("},{"line_number":77,"context_line":"            flavor_id\u003dself.flavor1,"},{"line_number":78,"context_line":"            networks\u003d\u0027none\u0027,)"},{"line_number":79,"context_line":"        original_host \u003d server[\u0027OS-EXT-SRV-ATTR:host\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_ce7f37dc","line":76,"range":{"start_line":76,"start_character":17,"end_line":76,"end_character":60},"updated":"2020-01-21 13:06:53.000000000","message":"super() does not work here due to multiple inheritance?","commit_id":"5b36d8c054571542e6a00f11f9db2b69e2b0017f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"81a18add1e9f49909df6be24e89b945880cbf658","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _create_server(self, name):"},{"line_number":75,"context_line":"        # Create a server, it doesn\u0027t matter which host it ends up in."},{"line_number":76,"context_line":"        server \u003d super(TestAvailabilityZoneScheduling, self)._create_server("},{"line_number":77,"context_line":"            flavor_id\u003dself.flavor1,"},{"line_number":78,"context_line":"            networks\u003d\u0027none\u0027,)"},{"line_number":79,"context_line":"        original_host \u003d server[\u0027OS-EXT-SRV-ATTR:host\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_b0e803a7","line":76,"range":{"start_line":76,"start_character":17,"end_line":76,"end_character":60},"in_reply_to":"3fa7e38b_ce7f37dc","updated":"2020-01-22 10:44:21.000000000","message":"Nope, this was just written before the demise of Python 2.7 :)","commit_id":"5b36d8c054571542e6a00f11f9db2b69e2b0017f"}]}