)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"a5df7b56b5db5e248aa0b65e2cb2728447ffd3b7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Nova is still alive and it should not time out the operation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It is not required to send an accurate progress -- just an update"},{"line_number":14,"context_line":"for the snapshot id being processed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change is backward compatible with Havana Cinder."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUX%2F%2F1Gs%3D","line":14,"updated":"2014-02-10 14:57:58.000000000","message":"These two paragraphs describe the solution to an unspecified problem. Commit message guidelines say we shouldn\u0027t rely on the bug to inform people of the problem scenario. Could you add a couple of sentences describing the problem this is fixing.","commit_id":"c8eb3432f7e91c4f16bc0f643a606876a7a685c5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f62914c545e17ba42f1e0ab75b3f2293fdc324e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Nova is still alive and it should not time out the operation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It is not required to send an accurate progress -- just an update"},{"line_number":14,"context_line":"for the snapshot id being processed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change is backward compatible with Havana Cinder."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUX%2F%2F0UY%3D","line":14,"in_reply_to":"AAAAUX%2F%2F1Gs%3D","updated":"2014-02-10 16:30:48.000000000","message":"Sure, thanks.","commit_id":"c8eb3432f7e91c4f16bc0f643a606876a7a685c5"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"55d3cf4185c5113d7fb39a64f0c9614e0915184b","unresolved":false,"context_lines":[{"line_number":1876,"context_line":"                if now - last_update_sent \u003e update_snapshot_interval:"},{"line_number":1877,"context_line":"                    # Send update to Cinder indicating we are still running"},{"line_number":1878,"context_line":"                    self._volume_snapshot_update_status("},{"line_number":1879,"context_line":"                        context, snapshot_id, \u0027deleting\u0027, complete\u003dFalse)"},{"line_number":1880,"context_line":"        else:"},{"line_number":1881,"context_line":"            # commit with blockCommit()"},{"line_number":1882,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BDkE%3D","line":1879,"updated":"2014-01-30 16:11:55.000000000","message":"Need to update the last_update_sent time here. :-)","commit_id":"c43c4576b9c816b41538f4a182c72c65b43dba2b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"55d3cf4185c5113d7fb39a64f0c9614e0915184b","unresolved":false,"context_lines":[{"line_number":1902,"context_line":"                if now - last_update_sent \u003e update_snapshot_interval:"},{"line_number":1903,"context_line":"                    # Send update to Cinder indicating we are still running"},{"line_number":1904,"context_line":"                    self._volume_snapshot_update_status("},{"line_number":1905,"context_line":"                        context, snapshot_id, \u0027deleting\u0027, complete\u003dFalse)"},{"line_number":1906,"context_line":""},{"line_number":1907,"context_line":"    def volume_snapshot_delete(self, context, instance, volume_id, snapshot_id,"},{"line_number":1908,"context_line":"                               delete_info\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BDkM%3D","line":1905,"updated":"2014-01-30 16:11:55.000000000","message":"Need to update the last_update_sent time here.  :-)","commit_id":"c43c4576b9c816b41538f4a182c72c65b43dba2b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"3b19f2143da9007923c899489a35c04e1021fb86","unresolved":false,"context_lines":[{"line_number":1842,"context_line":"                  {\u0027dev\u0027: my_dev, \u0027disk\u0027: active_disk})"},{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"        update_snapshot_interval \u003d 90"},{"line_number":1845,"context_line":""},{"line_number":1846,"context_line":"        if delete_info[\u0027merge_target_file\u0027] is None:"},{"line_number":1847,"context_line":"            # pull via blockRebase()"},{"line_number":1848,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2Fsgs%3D","line":1845,"updated":"2014-02-25 08:12:04.000000000","message":"should this be a conf variable?","commit_id":"e713dad625e1b34c43b832b884453a1a7d31bc90"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"75ca57511476581f2244b56adde64fc80312c08f","unresolved":false,"context_lines":[{"line_number":1842,"context_line":"                  {\u0027dev\u0027: my_dev, \u0027disk\u0027: active_disk})"},{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"        update_snapshot_interval \u003d 90"},{"line_number":1845,"context_line":""},{"line_number":1846,"context_line":"        if delete_info[\u0027merge_target_file\u0027] is None:"},{"line_number":1847,"context_line":"            # pull via blockRebase()"},{"line_number":1848,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2FofA%3D","line":1845,"in_reply_to":"AAAAU3%2F%2Fokc%3D","updated":"2014-02-25 15:09:00.000000000","message":"then a comment might indicate the reason ,it might be helpful later for code reader I think","commit_id":"e713dad625e1b34c43b832b884453a1a7d31bc90"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"78a75a621790b8f4e8420eebf70e224bb8dc988d","unresolved":false,"context_lines":[{"line_number":1842,"context_line":"                  {\u0027dev\u0027: my_dev, \u0027disk\u0027: active_disk})"},{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"        update_snapshot_interval \u003d 90"},{"line_number":1845,"context_line":""},{"line_number":1846,"context_line":"        if delete_info[\u0027merge_target_file\u0027] is None:"},{"line_number":1847,"context_line":"            # pull via blockRebase()"},{"line_number":1848,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2Fokc%3D","line":1845,"in_reply_to":"AAAAU3%2F%2Fsgs%3D","updated":"2014-02-25 14:58:42.000000000","message":"I don\u0027t see a reason for it to be -- it just needs to be small enough to ensure that it happens before Cinder\u0027s timeout.","commit_id":"e713dad625e1b34c43b832b884453a1a7d31bc90"}]}