)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"683355bfb666bcf43ed3ce454940d3a64fc64251","unresolved":false,"context_lines":[{"line_number":721,"context_line":"                                elevated, self.report_client, spec_obj,"},{"line_number":722,"context_line":"                                instance.uuid, alloc_req,"},{"line_number":723,"context_line":"                                host.allocation_request_version)"},{"line_number":724,"context_line":"                            if request_spec and host_available:"},{"line_number":725,"context_line":"                                # NOTE(gibi): redo the request group - resource"},{"line_number":726,"context_line":"                                # provider mapping as the above claim call"},{"line_number":727,"context_line":"                                # moves the allocation of the instance to"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_addbd0e7","line":724,"range":{"start_line":724,"start_character":31,"end_line":724,"end_character":43},"updated":"2019-12-06 16:32:15.000000000","message":"This could be removed from the condition now.","commit_id":"e7891b23bd0ec63340b2ac3d2bb41ab6cb12d369"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"683355bfb666bcf43ed3ce454940d3a64fc64251","unresolved":false,"context_lines":[{"line_number":796,"context_line":"            # legacy part of the spec. Re-populate the requested_resources"},{"line_number":797,"context_line":"            # field based on the original request spec object passed to this"},{"line_number":798,"context_line":"            # function."},{"line_number":799,"context_line":"            if request_spec:"},{"line_number":800,"context_line":"                local_reqspec.requested_resources \u003d ("},{"line_number":801,"context_line":"                    request_spec.requested_resources)"},{"line_number":802,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cd016c3b","line":799,"range":{"start_line":799,"start_character":15,"end_line":799,"end_character":27},"updated":"2019-12-06 16:32:15.000000000","message":"and this","commit_id":"e7891b23bd0ec63340b2ac3d2bb41ab6cb12d369"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5ff183dcfb75f07ee96ba195a5c64229a4637608","unresolved":false,"context_lines":[{"line_number":617,"context_line":"            flavor \u003d objects.Flavor.get_by_id(context, flavor[\u0027id\u0027])"},{"line_number":618,"context_line":"            filter_properties \u003d dict(filter_properties, instance_type\u003dflavor)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        # Older computes will not send a request_spec during reschedules so we"},{"line_number":621,"context_line":"        # need to check and build our own if one is not provided."},{"line_number":622,"context_line":"        if request_spec is None:"},{"line_number":623,"context_line":"            request_spec \u003d scheduler_utils.build_request_spec("}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_305bb386","line":620,"range":{"start_line":620,"start_character":41,"end_line":620,"end_character":53},"updated":"2019-12-06 17:28:16.000000000","message":"RequestSpec","commit_id":"e757c67e52ce462881bd0ba7699ec00aa19ef42c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5ff183dcfb75f07ee96ba195a5c64229a4637608","unresolved":false,"context_lines":[{"line_number":648,"context_line":"            scheduler_utils.populate_retry("},{"line_number":649,"context_line":"                filter_properties, instances[0].uuid)"},{"line_number":650,"context_line":"            instance_uuids \u003d [instance.uuid for instance in instances]"},{"line_number":651,"context_line":"            spec_obj \u003d objects.RequestSpec.from_primitives("},{"line_number":652,"context_line":"                    context, legacy_request_spec, filter_properties)"},{"line_number":653,"context_line":"            LOG.debug(\"Rescheduling: %s\", is_reschedule)"},{"line_number":654,"context_line":"            if is_reschedule:"},{"line_number":655,"context_line":"                # Make sure that we have a host, as we may have exhausted all"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_50ee6f8b","line":652,"range":{"start_line":651,"start_character":12,"end_line":652,"end_character":68},"updated":"2019-12-06 17:28:16.000000000","message":"Why can\u0027t this be removed, and `request_spec` substituted in its place wherever it\u0027s used below?\n\n(You\u0027re going to tell me something about how this RequestSpec.from_primitives isn\u0027t an exact reversal of the request_spec.to_legacy_request_spec_dict() from L635?)","commit_id":"e757c67e52ce462881bd0ba7699ec00aa19ef42c"}]}
