)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0fd8c7296c994ea9cd7e2cda1181b6025e948af5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"WIP:"},{"line_number":28,"context_line":"- Bug"},{"line_number":29,"context_line":"- Docs (api-ref should have 404 removed)"},{"line_number":30,"context_line":"- Test"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: Ibad1b51e2cf50d00102295039b6e82bc00bec058"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_f01662a7","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":39},"updated":"2019-12-09 17:14:56.000000000","message":"This is a bit tricky since older releases will still return 404. Maybe the API ref should just have a note that says older releases may incorrectly return 404 and link to the bug?","commit_id":"bdf8a9076632c680839bdae0d328b336f33661ba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e617228c8e3cca6d4e78ac815e20cdddb77282fc","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"WIP:"},{"line_number":28,"context_line":"- Bug"},{"line_number":29,"context_line":"- Docs (api-ref should have 404 removed)"},{"line_number":30,"context_line":"- Test"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: Ibad1b51e2cf50d00102295039b6e82bc00bec058"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_93e058cd","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":39},"in_reply_to":"3fa7e38b_f01662a7","updated":"2019-12-09 17:52:33.000000000","message":"Done","commit_id":"bdf8a9076632c680839bdae0d328b336f33661ba"}],"api-ref/source/os-server-external-events.inc":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"418c0673680952470cb6bf32f5f925a1b74afa82","unresolved":false,"context_lines":[{"line_number":36,"context_line":"event will explain further what went wrong."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403),"},{"line_number":39,"context_line":"itemNotFound(404)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Request"},{"line_number":42,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa7e38b_d017a653","side":"PARENT","line":39,"updated":"2019-12-09 17:28:43.000000000","message":"The API reference is built from master and the 404 is returned on older releases. Even if we backport the fix we\u0027ll still return 404 on any old EOL branch we can\u0027t update. So if we outright remove this, we should probably have a note or something that says older releases may incorrectly return a 404 and link to the bug?","commit_id":"e937c5c6c47658e695b1e934b3d6e660dc6514ed"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e617228c8e3cca6d4e78ac815e20cdddb77282fc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"event will explain further what went wrong."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403),"},{"line_number":39,"context_line":"itemNotFound(404)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Request"},{"line_number":42,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa7e38b_73cb5c49","side":"PARENT","line":39,"in_reply_to":"3fa7e38b_d017a653","updated":"2019-12-09 17:52:33.000000000","message":"Done","commit_id":"e937c5c6c47658e695b1e934b3d6e660dc6514ed"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"418c0673680952470cb6bf32f5f925a1b74afa82","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Normal response codes: 200, 207"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"A 200 will be returned if all events succeeded, 207 will be returned"},{"line_number":35,"context_line":"if some or all events could not be processed. The ``code`` attribute for the"},{"line_number":36,"context_line":"event will explain further what went wrong."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403)"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa7e38b_d02ec6a9","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":14},"updated":"2019-12-09 17:28:43.000000000","message":"if some or all is redundant - just say \"if any\"?","commit_id":"7c9f138e05ee2d3af3d786929a23f19b2ce56fc2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e617228c8e3cca6d4e78ac815e20cdddb77282fc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Normal response codes: 200, 207"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"A 200 will be returned if all events succeeded, 207 will be returned"},{"line_number":35,"context_line":"if some or all events could not be processed. The ``code`` attribute for the"},{"line_number":36,"context_line":"event will explain further what went wrong."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403)"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa7e38b_93f93883","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":14},"in_reply_to":"3fa7e38b_d02ec6a9","updated":"2019-12-09 17:52:33.000000000","message":"This again.\n\n\"Some or all\" is redundant in math and programming, not in English where \"some\" implies \"not all\".\n\nDone.","commit_id":"7c9f138e05ee2d3af3d786929a23f19b2ce56fc2"}],"nova/api/openstack/compute/server_external_events.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d3d9cf0a141048fc118051dab5ee11373d31336d","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return instances"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @wsgi.expected_errors((403, 404))"},{"line_number":69,"context_line":"    @wsgi.response(200)"},{"line_number":70,"context_line":"    @validation.schema(server_external_events.create, \u00272.0\u0027, \u00272.50\u0027)"},{"line_number":71,"context_line":"    @validation.schema(server_external_events.create_v251, \u00272.51\u0027, \u00272.75\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_50017638","line":68,"range":{"start_line":68,"start_character":32,"end_line":68,"end_character":35},"updated":"2019-12-09 17:21:51.000000000","message":"you can remove this too now with a note in api-ref as matt stated.","commit_id":"bdf8a9076632c680839bdae0d328b336f33661ba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e617228c8e3cca6d4e78ac815e20cdddb77282fc","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return instances"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @wsgi.expected_errors((403, 404))"},{"line_number":69,"context_line":"    @wsgi.response(200)"},{"line_number":70,"context_line":"    @validation.schema(server_external_events.create, \u00272.0\u0027, \u00272.50\u0027)"},{"line_number":71,"context_line":"    @validation.schema(server_external_events.create_v251, \u00272.51\u0027, \u00272.75\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f3df4c09","line":68,"range":{"start_line":68,"start_character":32,"end_line":68,"end_character":35},"in_reply_to":"3fa7e38b_50017638","updated":"2019-12-09 17:52:33.000000000","message":"Done","commit_id":"bdf8a9076632c680839bdae0d328b336f33661ba"}]}
