)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"898bacad3c1d0f42ebf8b04495dc875e93fa97cb","unresolved":false,"context_lines":[{"line_number":714,"context_line":"                return None"},{"line_number":715,"context_line":"            print(_(\u0027--transport-url not provided in the command line, \u0027"},{"line_number":716,"context_line":"                    \u0027using the value [DEFAULT]/transport_url from the \u0027"},{"line_number":717,"context_line":"                    \u0027configuration file\u0027))"},{"line_number":718,"context_line":"            transport_url \u003d CONF.transport_url"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6f80c5f7","line":717,"updated":"2020-02-04 11:17:51.000000000","message":"you can even add the value of the CONF.transport_url to help spotting if unexpected information is going to be used","commit_id":"a70d0ac8fd77d1b3c991c3ccd342d9a5efde307b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c0e6694bce016e0e89fb262fff04a19fa15306e4","unresolved":false,"context_lines":[{"line_number":714,"context_line":"                return None"},{"line_number":715,"context_line":"            print(_(\u0027--transport-url not provided in the command line, \u0027"},{"line_number":716,"context_line":"                    \u0027using the value [DEFAULT]/transport_url from the \u0027"},{"line_number":717,"context_line":"                    \u0027configuration file\u0027))"},{"line_number":718,"context_line":"            transport_url \u003d CONF.transport_url"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_84ecf491","line":717,"in_reply_to":"3fa7e38b_36445d1a","updated":"2020-02-05 08:41:41.000000000","message":"hm that sounds like a good first principle. Thanks for the explanation.","commit_id":"a70d0ac8fd77d1b3c991c3ccd342d9a5efde307b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"eb3e712c3ee02eadaa1ded8f395d85e27422cbb4","unresolved":false,"context_lines":[{"line_number":714,"context_line":"                return None"},{"line_number":715,"context_line":"            print(_(\u0027--transport-url not provided in the command line, \u0027"},{"line_number":716,"context_line":"                    \u0027using the value [DEFAULT]/transport_url from the \u0027"},{"line_number":717,"context_line":"                    \u0027configuration file\u0027))"},{"line_number":718,"context_line":"            transport_url \u003d CONF.transport_url"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_36445d1a","line":717,"in_reply_to":"3fa7e38b_6f80c5f7","updated":"2020-02-04 18:06:50.000000000","message":"As this will include passwords I\u0027d like to avoid this just in case","commit_id":"a70d0ac8fd77d1b3c991c3ccd342d9a5efde307b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"898bacad3c1d0f42ebf8b04495dc875e93fa97cb","unresolved":false,"context_lines":[{"line_number":740,"context_line":"            print(_(\u0027--database_connection not provided in the command line, \u0027"},{"line_number":741,"context_line":"                    \u0027using the value [database]/connection from the \u0027"},{"line_number":742,"context_line":"                    \u0027configuration file\u0027))"},{"line_number":743,"context_line":"            return CONF.database.connection"},{"line_number":744,"context_line":"        return database_connection"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"    def _non_unique_transport_url_database_connection_checker(self, ctxt,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ef6b5551","line":743,"updated":"2020-02-04 11:17:51.000000000","message":"ditto","commit_id":"a70d0ac8fd77d1b3c991c3ccd342d9a5efde307b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"eb3e712c3ee02eadaa1ded8f395d85e27422cbb4","unresolved":false,"context_lines":[{"line_number":740,"context_line":"            print(_(\u0027--database_connection not provided in the command line, \u0027"},{"line_number":741,"context_line":"                    \u0027using the value [database]/connection from the \u0027"},{"line_number":742,"context_line":"                    \u0027configuration file\u0027))"},{"line_number":743,"context_line":"            return CONF.database.connection"},{"line_number":744,"context_line":"        return database_connection"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"    def _non_unique_transport_url_database_connection_checker(self, ctxt,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b6592d01","line":743,"in_reply_to":"3fa7e38b_ef6b5551","updated":"2020-02-04 18:06:50.000000000","message":"ditto :)","commit_id":"a70d0ac8fd77d1b3c991c3ccd342d9a5efde307b"}],"nova/tests/unit/cmd/test_manage.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"898bacad3c1d0f42ebf8b04495dc875e93fa97cb","unresolved":false,"context_lines":[{"line_number":967,"context_line":"        retval \u003d self.commands.map_cell_and_hosts()"},{"line_number":968,"context_line":"        self.assertEqual(1, retval)"},{"line_number":969,"context_line":"        output \u003d self.output.getvalue().strip()"},{"line_number":970,"context_line":"        expected \u003d (u\u0027Must specify --transport-url if [DEFAULT]/transport_url \u0027"},{"line_number":971,"context_line":"                     \u0027is not set in the configuration file.\u0027)"},{"line_number":972,"context_line":"        self.assertEqual(expected, output)"},{"line_number":973,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_efe7d5d6","line":970,"range":{"start_line":970,"start_character":20,"end_line":970,"end_character":21},"updated":"2020-02-04 11:17:51.000000000","message":"this feels wrong. We only support py3 now where the string is unicode by default","commit_id":"a70d0ac8fd77d1b3c991c3ccd342d9a5efde307b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"eb3e712c3ee02eadaa1ded8f395d85e27422cbb4","unresolved":false,"context_lines":[{"line_number":967,"context_line":"        retval \u003d self.commands.map_cell_and_hosts()"},{"line_number":968,"context_line":"        self.assertEqual(1, retval)"},{"line_number":969,"context_line":"        output \u003d self.output.getvalue().strip()"},{"line_number":970,"context_line":"        expected \u003d (u\u0027Must specify --transport-url if [DEFAULT]/transport_url \u0027"},{"line_number":971,"context_line":"                     \u0027is not set in the configuration file.\u0027)"},{"line_number":972,"context_line":"        self.assertEqual(expected, output)"},{"line_number":973,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7653b5df","line":970,"range":{"start_line":970,"start_character":20,"end_line":970,"end_character":21},"in_reply_to":"3fa7e38b_efe7d5d6","updated":"2020-02-04 18:06:50.000000000","message":"yeah indeed, will switch it back, was doing it for older release","commit_id":"a70d0ac8fd77d1b3c991c3ccd342d9a5efde307b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3ee5a273f1e5754c0faa26bf3e7467bc94cd4c08","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            db_sync_calls \u003d ["},{"line_number":643,"context_line":"                mock.call(4, context\u003dcell_ctxt),"},{"line_number":644,"context_line":"                mock.call(4)"},{"line_number":645,"context_line":"            ]"},{"line_number":646,"context_line":"            mock_db_sync.assert_has_calls(db_sync_calls)"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    @mock.patch.object(objects.CellMapping, \u0027get_by_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_24b18092","line":645,"updated":"2020-02-05 08:48:33.000000000","message":"useless change","commit_id":"9f655998924a1854215432aa910f309ac7dc4308"}]}