)]}'
{"lower-constraints.txt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85f8af89025da86a83e6d2a1318211ca66c4ec37","unresolved":false,"context_lines":[{"line_number":68,"context_line":"os-client-config\u003d\u003d1.29.0"},{"line_number":69,"context_line":"os-resource-classes\u003d\u003d0.4.0"},{"line_number":70,"context_line":"os-service-types\u003d\u003d1.7.0"},{"line_number":71,"context_line":"os-traits\u003d\u003d2.0.0"},{"line_number":72,"context_line":"os-vif\u003d\u003d1.14.0"},{"line_number":73,"context_line":"os-win\u003d\u003d3.0.0"},{"line_number":74,"context_line":"os-xenapi\u003d\u003d0.3.3"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_a024380f","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":16},"updated":"2020-01-02 14:57:36.000000000","message":"yep so this is needed as the ploop trait was added in https://github.com/openstack/os-traits/commit/c7468b0bad407c7fdb293a49e9c6c9ec16274a96\nwhich was first released in 2.0.0\n\nas this is already released we also dont need a depends on in the commit so +1","commit_id":"8a2c3951a3f0dc9b44c6c6f1e095caa6bc80057d"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"4140aec4238e5a2107e518acfd908af3270211e1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"os-client-config\u003d\u003d1.29.0"},{"line_number":69,"context_line":"os-resource-classes\u003d\u003d0.4.0"},{"line_number":70,"context_line":"os-service-types\u003d\u003d1.7.0"},{"line_number":71,"context_line":"os-traits\u003d\u003d2.0.0"},{"line_number":72,"context_line":"os-vif\u003d\u003d1.14.0"},{"line_number":73,"context_line":"os-win\u003d\u003d3.0.0"},{"line_number":74,"context_line":"os-xenapi\u003d\u003d0.3.3"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_1cfed069","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":16},"in_reply_to":"3fa7e38b_a024380f","updated":"2020-01-03 06:55:08.000000000","message":"Done","commit_id":"8a2c3951a3f0dc9b44c6c6f1e095caa6bc80057d"}],"nova/virt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"813cc9c7a4c1299ce164872af4607d3438d5391d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    \"supports_image_type_vhd\": os_traits.COMPUTE_IMAGE_TYPE_VHD,"},{"line_number":123,"context_line":"    \"supports_image_type_vhdx\": os_traits.COMPUTE_IMAGE_TYPE_VHDX,"},{"line_number":124,"context_line":"    \"supports_image_type_vmdk\": os_traits.COMPUTE_IMAGE_TYPE_VMDK,"},{"line_number":125,"context_line":"    # Image type support flags, added in os-traits 2.0.0"},{"line_number":126,"context_line":"    \"supports_image_type_aki\": os_traits.COMPUTE_IMAGE_TYPE_PLOOP,"},{"line_number":127,"context_line":"}"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9b5dc6ed","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":56},"updated":"2019-12-10 11:08:51.000000000","message":"Can you drop this (it\u0027s not really relevant)","commit_id":"a09eff8adf10552917f50d5bc01ea31e852c8181"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"d85cd827c722f0fcd35512c0adbd0e64670001c5","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    \"supports_image_type_vhd\": os_traits.COMPUTE_IMAGE_TYPE_VHD,"},{"line_number":123,"context_line":"    \"supports_image_type_vhdx\": os_traits.COMPUTE_IMAGE_TYPE_VHDX,"},{"line_number":124,"context_line":"    \"supports_image_type_vmdk\": os_traits.COMPUTE_IMAGE_TYPE_VMDK,"},{"line_number":125,"context_line":"    # Image type support flags, added in os-traits 2.0.0"},{"line_number":126,"context_line":"    \"supports_image_type_aki\": os_traits.COMPUTE_IMAGE_TYPE_PLOOP,"},{"line_number":127,"context_line":"}"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_dc99f51d","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":56},"in_reply_to":"3fa7e38b_9b5dc6ed","updated":"2019-12-11 01:06:56.000000000","message":"I don\u0027t think. Because COMPUTE_IMAGE_TYPE_PLOOP fix release at os-traits 2.0.0. Am I missing something?","commit_id":"a09eff8adf10552917f50d5bc01ea31e852c8181"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e7b1f04cab2fe70a61232b599cf00f1826cd25a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    \"supports_image_type_vhd\": os_traits.COMPUTE_IMAGE_TYPE_VHD,"},{"line_number":123,"context_line":"    \"supports_image_type_vhdx\": os_traits.COMPUTE_IMAGE_TYPE_VHDX,"},{"line_number":124,"context_line":"    \"supports_image_type_vmdk\": os_traits.COMPUTE_IMAGE_TYPE_VMDK,"},{"line_number":125,"context_line":"    # Image type support flags, added in os-traits 2.0.0"},{"line_number":126,"context_line":"    \"supports_image_type_aki\": os_traits.COMPUTE_IMAGE_TYPE_PLOOP,"},{"line_number":127,"context_line":"}"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ce384dee","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":56},"in_reply_to":"3fa7e38b_dc99f51d","updated":"2019-12-11 10:11:22.000000000","message":"I\u0027m not saying the comment isn\u0027t true. I\u0027m saying it just isn\u0027t that helpful. We bump dependencies the whole time.","commit_id":"a09eff8adf10552917f50d5bc01ea31e852c8181"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85f8af89025da86a83e6d2a1318211ca66c4ec37","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            # formats. If we are configured for those backends, then we"},{"line_number":340,"context_line":"            # should not expose the corresponding support traits."},{"line_number":341,"context_line":"            \"supports_image_type_qcow2\": not requires_raw_image,"},{"line_number":342,"context_line":"            \"supports_image_type_ploop\": True,"},{"line_number":343,"context_line":"            \"supports_pcpus\": True,"},{"line_number":344,"context_line":"        }"},{"line_number":345,"context_line":"        super(LibvirtDriver, self).__init__(virtapi)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_40646449","line":342,"range":{"start_line":342,"start_character":12,"end_line":342,"end_character":46},"updated":"2020-01-02 14:57:36.000000000","message":"this is not always correct. it only support ploop if you are using specific virt_types. in this case Virtuozzo. we should instead do \n\n\"supports_image_type_ploop\": CONF.libvirt.virt_type \u003d\u003d \u0027virtuozzo\u0027\n\nright?\n\nunless we support ploop with qemu/kvm?\n\nqemu might be able to support the ploop format but i dont know if nova can use ploop with qemu/kvm and i pretty sure we dont test it so i would hesitate before reporting it for all libvirt hosts.","commit_id":"8a2c3951a3f0dc9b44c6c6f1e095caa6bc80057d"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"4140aec4238e5a2107e518acfd908af3270211e1","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            # formats. If we are configured for those backends, then we"},{"line_number":340,"context_line":"            # should not expose the corresponding support traits."},{"line_number":341,"context_line":"            \"supports_image_type_qcow2\": not requires_raw_image,"},{"line_number":342,"context_line":"            \"supports_image_type_ploop\": True,"},{"line_number":343,"context_line":"            \"supports_pcpus\": True,"},{"line_number":344,"context_line":"        }"},{"line_number":345,"context_line":"        super(LibvirtDriver, self).__init__(virtapi)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_dcf3589e","line":342,"range":{"start_line":342,"start_character":12,"end_line":342,"end_character":46},"in_reply_to":"3fa7e38b_40646449","updated":"2020-01-03 06:55:08.000000000","message":"Done","commit_id":"8a2c3951a3f0dc9b44c6c6f1e095caa6bc80057d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4c89d44cf3a670b23ec4278c9424a46b5574ee9","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        raw_only \u003d (\u0027rbd\u0027, \u0027lvm\u0027)"},{"line_number":311,"context_line":"        requires_raw_image \u003d (CONF.libvirt.images_type in raw_only and"},{"line_number":312,"context_line":"                              not CONF.force_raw_images)"},{"line_number":313,"context_line":"        requires_ploop_image \u003d \\"},{"line_number":314,"context_line":"                True if CONF.libvirt.virt_type \u003d\u003d \u0027parallels\u0027 else False"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        self.capabilities \u003d {"},{"line_number":317,"context_line":"            \"has_imagecache\": True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_d3cfb751","line":314,"range":{"start_line":313,"start_character":31,"end_line":314,"end_character":72},"updated":"2020-01-06 11:00:34.000000000","message":"You don\u0027t need the \u0027True if COND else False\u0027. Just do \u0027COND\u0027, i.e.\n\n    requires_ploop_image \u003d CONF.libvirt.virt_type \u003d\u003d \u0027parallels\u0027","commit_id":"42adbaa088dc4604328790ffabb07e3d370f83a1"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"af174f1fc16ce4335373cfbf754111b65771507d","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        raw_only \u003d (\u0027rbd\u0027, \u0027lvm\u0027)"},{"line_number":311,"context_line":"        requires_raw_image \u003d (CONF.libvirt.images_type in raw_only and"},{"line_number":312,"context_line":"                              not CONF.force_raw_images)"},{"line_number":313,"context_line":"        requires_ploop_image \u003d \\"},{"line_number":314,"context_line":"                True if CONF.libvirt.virt_type \u003d\u003d \u0027parallels\u0027 else False"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        self.capabilities \u003d {"},{"line_number":317,"context_line":"            \"has_imagecache\": True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_ee79ac2f","line":314,"range":{"start_line":313,"start_character":31,"end_line":314,"end_character":72},"in_reply_to":"3fa7e38b_d3cfb751","updated":"2020-01-06 12:46:47.000000000","message":"Done","commit_id":"42adbaa088dc4604328790ffabb07e3d370f83a1"}]}