)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7e950ededbe34ba810b5ae33b700508a1be1d51e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-12-10 13:33:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error out with an UnboundException when in"},{"line_number":8,"context_line":"build_and_run_instance"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I873b2e8f5c39260850cb68147c560b549f8147d1"},{"line_number":11,"context_line":"Closes-Bug: 1854848"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_d7ce9c2a","line":8,"updated":"2019-12-11 13:41:11.000000000","message":"you can\u0027t change line for the title","commit_id":"89a366923b0fd12f3f5d206f69610273b6948fb3"}],"nova/compute/manager.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7e950ededbe34ba810b5ae33b700508a1be1d51e","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"            # to do anything with this instance while we wait."},{"line_number":2072,"context_line":"            with self._build_semaphore:"},{"line_number":2073,"context_line":"                try:"},{"line_number":2074,"context_line":"                    result \u003d self._do_build_and_run_instance(*args, **kwargs)"},{"line_number":2075,"context_line":"                except eventlet.timeout.Timeout:"},{"line_number":2076,"context_line":"                    # This should really only happen if for some reason"},{"line_number":2077,"context_line":"                    # eventlet throws a a event.timeout.Timeout during a build"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_775ec845","line":2074,"range":{"start_line":2074,"start_character":29,"end_line":2074,"end_character":77},"updated":"2019-12-11 13:41:11.000000000","message":"It means we didn\u0027t catch this exception in this method. That won\u0027t trigger any cleanup. So I\u0027m thinking we should catch exception in this method, and cleanup the instance.","commit_id":"89a366923b0fd12f3f5d206f69610273b6948fb3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7e950ededbe34ba810b5ae33b700508a1be1d51e","unresolved":false,"context_lines":[{"line_number":2258,"context_line":"                    injected_files, requested_networks, security_groups,"},{"line_number":2259,"context_line":"                    block_device_mapping, request_spec\u003drequest_spec,"},{"line_number":2260,"context_line":"                    host_lists\u003d[host_list])"},{"line_number":2261,"context_line":"            return build_results.RESCHEDULED"},{"line_number":2262,"context_line":"        except (exception.InstanceNotFound,"},{"line_number":2263,"context_line":"                exception.UnexpectedDeletingTaskStateError):"},{"line_number":2264,"context_line":"            msg \u003d \u0027Instance disappeared during build.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d738dced","line":2261,"range":{"start_line":2261,"start_character":12,"end_line":2261,"end_character":44},"updated":"2019-12-11 13:41:11.000000000","message":"so that should be a case we reschedule I think.","commit_id":"89a366923b0fd12f3f5d206f69610273b6948fb3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7e950ededbe34ba810b5ae33b700508a1be1d51e","unresolved":false,"context_lines":[{"line_number":2282,"context_line":"            self._nil_out_instance_obj_host_and_node(instance)"},{"line_number":2283,"context_line":"            self._set_instance_obj_error_state(context, instance,"},{"line_number":2284,"context_line":"                                               clean_task_state\u003dTrue)"},{"line_number":2285,"context_line":"            return build_results.FAILED"},{"line_number":2286,"context_line":""},{"line_number":2287,"context_line":"    def deallocate_sriov_ports_on_reschedule(self, instance):"},{"line_number":2288,"context_line":"        \"\"\"Determine if networks are needed to be deallocated before reschedule"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5724ecc2","line":2285,"updated":"2019-12-11 13:41:11.000000000","message":"if not going to reschedule, I think we should cleanup at least. But I prefer to do the reschedule","commit_id":"89a366923b0fd12f3f5d206f69610273b6948fb3"}]}