)]}'
{"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d5abcc544aed8f343c99b0229244f9e357a898c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3fa7e38b_8a2e7d59","updated":"2020-02-18 09:18:40.000000000","message":"A unit test case is missing where the resources returned by _build_resources() returns a non empty list of accel_info (or a sentinel if you chose to mock it) and we assert that such info is passed forward to the driver. Current test cases would pass even if the compute manager always pass accel_info\u003d[] to the driver.","commit_id":"8fdf0b7b90681b384919c0878f8b314b6b9edebd"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"4b07eafa7c9678c56a3e577df0b50bcfbe20f201","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1fa4df85_866c4c9d","in_reply_to":"3fa7e38b_8a2e7d59","updated":"2020-02-23 08:29:08.000000000","message":"Done","commit_id":"8fdf0b7b90681b384919c0878f8b314b6b9edebd"}],"nova/virt/driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d5abcc544aed8f343c99b0229244f9e357a898c8","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        :param network_info: instance network information"},{"line_number":375,"context_line":"        :param block_device_info: Information about block devices to be"},{"line_number":376,"context_line":"                                  attached to the instance."},{"line_number":377,"context_line":"        :param arqs: Accelerator requests for this instance."},{"line_number":378,"context_line":"        :param power_on: True if the instance should be powered on, False"},{"line_number":379,"context_line":"                         otherwise"},{"line_number":380,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"3fa7e38b_2adbc94c","line":377,"updated":"2020-02-18 09:18:40.000000000","message":"As far as I understand this is a list of dicts but honestly I don\u0027t know what is the format of that dict. Where the form of that structure is defined? Is it something that is defined by the Cyborg API? Can you refer to that here?","commit_id":"8fdf0b7b90681b384919c0878f8b314b6b9edebd"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"4b07eafa7c9678c56a3e577df0b50bcfbe20f201","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        :param network_info: instance network information"},{"line_number":375,"context_line":"        :param block_device_info: Information about block devices to be"},{"line_number":376,"context_line":"                                  attached to the instance."},{"line_number":377,"context_line":"        :param arqs: Accelerator requests for this instance."},{"line_number":378,"context_line":"        :param power_on: True if the instance should be powered on, False"},{"line_number":379,"context_line":"                         otherwise"},{"line_number":380,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"3fa7e38b_0c3cb42b","line":377,"in_reply_to":"3fa7e38b_2adbc94c","updated":"2020-02-23 08:29:08.000000000","message":"Done","commit_id":"8fdf0b7b90681b384919c0878f8b314b6b9edebd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18e93723c94c82131bb7a0c4443c1355f9f13dc1","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                                  attached to the instance."},{"line_number":377,"context_line":"        :param power_on: True if the instance should be powered on, False"},{"line_number":378,"context_line":"                         otherwise"},{"line_number":379,"context_line":"        :param arqs: List of bound accelerator requests for this instance."},{"line_number":380,"context_line":"            ["},{"line_number":381,"context_line":"             {\u0027uuid\u0027: $arq_uuid,"},{"line_number":382,"context_line":"              \u0027device_profile_name\u0027: $dp_name,"}],"source_content_type":"text/x-python","patch_set":20,"id":"df33271e_fdcb2c6f","line":379,"range":{"start_line":379,"start_character":15,"end_line":379,"end_character":19},"updated":"2020-03-23 19:02:20.000000000","message":"nit: accel_info","commit_id":"1ff60fa52d698716b03225a3863dec1219c34640"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ba49f7f08a752278f414def7806160a719cd0710","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"        :param network_info: Instance network information."},{"line_number":1159,"context_line":"        :param block_device_info: Instance block device"},{"line_number":1160,"context_line":"            information."},{"line_number":1161,"context_line":"        :param arqs: Accelerator requests for this instance."},{"line_number":1162,"context_line":"        :param power_on: True if the instance should be powered on, False"},{"line_number":1163,"context_line":"                         otherwise"},{"line_number":1164,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"df33271e_a33fd0d4","line":1161,"range":{"start_line":1161,"start_character":15,"end_line":1161,"end_character":19},"updated":"2020-03-23 10:03:21.000000000","message":"isn\u0027t it accel_info?","commit_id":"1ff60fa52d698716b03225a3863dec1219c34640"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18e93723c94c82131bb7a0c4443c1355f9f13dc1","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"        :param network_info: Instance network information."},{"line_number":1159,"context_line":"        :param block_device_info: Instance block device"},{"line_number":1160,"context_line":"            information."},{"line_number":1161,"context_line":"        :param arqs: Accelerator requests for this instance."},{"line_number":1162,"context_line":"        :param power_on: True if the instance should be powered on, False"},{"line_number":1163,"context_line":"                         otherwise"},{"line_number":1164,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"df33271e_bdafe492","line":1161,"range":{"start_line":1161,"start_character":15,"end_line":1161,"end_character":19},"in_reply_to":"df33271e_a33fd0d4","updated":"2020-03-23 19:02:20.000000000","message":"yep","commit_id":"1ff60fa52d698716b03225a3863dec1219c34640"}]}