)]}'
{"doc/notification_samples/common_payloads/ImageMetaPropsPayload.json":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"16ad316832109948d6400989704afd6046807d27","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"hw_architecture\": \"x86_64\""},{"line_number":5,"context_line":"    },"},{"line_number":6,"context_line":"    \"nova_object.name\": \"ImageMetaPropsPayload\","},{"line_number":7,"context_line":"    \"nova_object.version\": \"1.3\""},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"3fa7e38b_92f1eb6c","line":7,"range":{"start_line":7,"start_character":3,"end_line":7,"end_character":32},"updated":"2019-12-13 16:09:21.000000000","message":"ya i forgot this +1","commit_id":"7dce6153622019c4f7343c49064765e4dc846ac8"}],"nova/notifications/objects/image.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"59af6b4bdb45c4e723e852d5889fcf43b3787cae","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        \u0027hw_rng_model\u0027: fields.RNGModelField(),"},{"line_number":227,"context_line":"        \u0027hw_serial_port_count\u0027: fields.IntegerField(),"},{"line_number":228,"context_line":"        \u0027hw_scsi_model\u0027: fields.SCSIModelField(),"},{"line_number":229,"context_line":"        \u0027hw_time_hpet\u0027: fields.FlexibleBooleanField(),"},{"line_number":230,"context_line":"        \u0027hw_video_model\u0027: fields.VideoModelField(),"},{"line_number":231,"context_line":"        \u0027hw_video_ram\u0027: fields.IntegerField(),"},{"line_number":232,"context_line":"        \u0027hw_vif_model\u0027: fields.VIFModelField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9a6360dd","line":229,"range":{"start_line":229,"start_character":9,"end_line":229,"end_character":21},"updated":"2019-12-12 01:56:08.000000000","message":"i forgot to put this in the schema\nwhich implies there are also no test to prevent that\nso ill fix this and add one in the morning","commit_id":"2c401725038c31dcc005f55490224473bd788389"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d181407ee5d2e71f36c96d7a8988e88e86b865ce","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    # Version 1.0: Initial version"},{"line_number":108,"context_line":"    # Version 1.1: Added \u0027gop\u0027, \u0027virtio\u0027 and  \u0027none\u0027 to hw_video_model field"},{"line_number":109,"context_line":"    # Version 1.2: Added hw_pci_numa_affinity_policy field"},{"line_number":110,"context_line":"    # Version 1.3: Added hw_mem_encryption, hw_pmu and hw_time_hpet  fields"},{"line_number":111,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f6f70159","line":110,"range":{"start_line":110,"start_character":67,"end_line":110,"end_character":68},"updated":"2019-12-12 20:43:14.000000000","message":"nit: extra space.","commit_id":"47fe379961bd7e7c636799a04805d3c22b8e462c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d181407ee5d2e71f36c96d7a8988e88e86b865ce","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    # Version 1.3: Added hw_mem_encryption, hw_pmu and hw_time_hpet  fields"},{"line_number":111,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    SCHEMA \u003d {"},{"line_number":114,"context_line":"        \u0027hw_architecture\u0027: (\u0027image_meta_props\u0027, \u0027hw_architecture\u0027),"},{"line_number":115,"context_line":"        \u0027hw_auto_disk_config\u0027: (\u0027image_meta_props\u0027, \u0027hw_auto_disk_config\u0027),"},{"line_number":116,"context_line":"        \u0027hw_boot_menu\u0027: (\u0027image_meta_props\u0027, \u0027hw_boot_menu\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_568295a6","line":113,"range":{"start_line":113,"start_character":4,"end_line":113,"end_character":10},"updated":"2019-12-12 20:43:14.000000000","message":"Ye gods, this seems so mechanical, isn\u0027t there a way we can generate it?","commit_id":"47fe379961bd7e7c636799a04805d3c22b8e462c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7086c0b1654dfb78de5d1abefd559b57b5d294ee","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    # Version 1.3: Added hw_mem_encryption, hw_pmu and hw_time_hpet  fields"},{"line_number":111,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    SCHEMA \u003d {"},{"line_number":114,"context_line":"        \u0027hw_architecture\u0027: (\u0027image_meta_props\u0027, \u0027hw_architecture\u0027),"},{"line_number":115,"context_line":"        \u0027hw_auto_disk_config\u0027: (\u0027image_meta_props\u0027, \u0027hw_auto_disk_config\u0027),"},{"line_number":116,"context_line":"        \u0027hw_boot_menu\u0027: (\u0027image_meta_props\u0027, \u0027hw_boot_menu\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2c68ecb7","line":113,"range":{"start_line":113,"start_character":4,"end_line":113,"end_character":10},"in_reply_to":"3fa7e38b_568295a6","updated":"2019-12-12 22:00:04.000000000","message":"yes that was what i was thinking too as i was updating it","commit_id":"47fe379961bd7e7c636799a04805d3c22b8e462c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d181407ee5d2e71f36c96d7a8988e88e86b865ce","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        \u0027hw_firmware_type\u0027: (\u0027image_meta_props\u0027, \u0027hw_firmware_type\u0027),"},{"line_number":132,"context_line":"        \u0027hw_ipxe_boot\u0027: (\u0027image_meta_props\u0027, \u0027hw_ipxe_boot\u0027),"},{"line_number":133,"context_line":"        \u0027hw_machine_type\u0027: (\u0027image_meta_props\u0027, \u0027hw_machine_type\u0027),"},{"line_number":134,"context_line":"        \u0027hw_mem_encryption\u0027: (\u0027image_meta_pros\u0027, \u0027hw_mem_encryption\u0027),"},{"line_number":135,"context_line":"        \u0027hw_mem_page_size\u0027: (\u0027image_meta_props\u0027, \u0027hw_mem_page_size\u0027),"},{"line_number":136,"context_line":"        \u0027hw_numa_nodes\u0027: (\u0027image_meta_props\u0027, \u0027hw_numa_nodes\u0027),"},{"line_number":137,"context_line":"        \u0027hw_numa_cpus\u0027: (\u0027image_meta_props\u0027, \u0027hw_numa_cpus\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d69685ef","line":134,"range":{"start_line":134,"start_character":42,"end_line":134,"end_character":46},"updated":"2019-12-12 20:43:14.000000000","message":"props\n\n...which means we don\u0027t have a test for that...","commit_id":"47fe379961bd7e7c636799a04805d3c22b8e462c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7086c0b1654dfb78de5d1abefd559b57b5d294ee","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        \u0027hw_firmware_type\u0027: (\u0027image_meta_props\u0027, \u0027hw_firmware_type\u0027),"},{"line_number":132,"context_line":"        \u0027hw_ipxe_boot\u0027: (\u0027image_meta_props\u0027, \u0027hw_ipxe_boot\u0027),"},{"line_number":133,"context_line":"        \u0027hw_machine_type\u0027: (\u0027image_meta_props\u0027, \u0027hw_machine_type\u0027),"},{"line_number":134,"context_line":"        \u0027hw_mem_encryption\u0027: (\u0027image_meta_pros\u0027, \u0027hw_mem_encryption\u0027),"},{"line_number":135,"context_line":"        \u0027hw_mem_page_size\u0027: (\u0027image_meta_props\u0027, \u0027hw_mem_page_size\u0027),"},{"line_number":136,"context_line":"        \u0027hw_numa_nodes\u0027: (\u0027image_meta_props\u0027, \u0027hw_numa_nodes\u0027),"},{"line_number":137,"context_line":"        \u0027hw_numa_cpus\u0027: (\u0027image_meta_props\u0027, \u0027hw_numa_cpus\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_4c63e8dd","line":134,"range":{"start_line":134,"start_character":42,"end_line":134,"end_character":46},"in_reply_to":"3fa7e38b_d69685ef","updated":"2019-12-12 22:00:04.000000000","message":"i might add a test for that too.","commit_id":"47fe379961bd7e7c636799a04805d3c22b8e462c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d181407ee5d2e71f36c96d7a8988e88e86b865ce","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        \u0027hw_rng_model\u0027: (\u0027image_meta_props\u0027, \u0027hw_rng_model\u0027),"},{"line_number":147,"context_line":"        \u0027hw_serial_port_count\u0027: (\u0027image_meta_props\u0027, \u0027hw_serial_port_count\u0027),"},{"line_number":148,"context_line":"        \u0027hw_scsi_model\u0027: (\u0027image_meta_props\u0027, \u0027hw_scsi_model\u0027),"},{"line_number":149,"context_line":"        \u0027hw_time_hpet\u0027: (\u0027image_meta_props\u0027, \u0027hw_time_hpet\u0027),"},{"line_number":150,"context_line":"        \u0027hw_video_model\u0027: (\u0027image_meta_props\u0027, \u0027hw_video_model\u0027),"},{"line_number":151,"context_line":"        \u0027hw_video_ram\u0027: (\u0027image_meta_props\u0027, \u0027hw_video_ram\u0027),"},{"line_number":152,"context_line":"        \u0027hw_vif_model\u0027: (\u0027image_meta_props\u0027, \u0027hw_vif_model\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_360cb940","line":149,"range":{"start_line":149,"start_character":9,"end_line":149,"end_character":21},"updated":"2019-12-12 20:43:14.000000000","message":"need to update the hash for this too.","commit_id":"47fe379961bd7e7c636799a04805d3c22b8e462c"}],"nova/tests/unit/notifications/objects/test_notification.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f45bf96429999d83e1266cc83a87a5453715bda1","unresolved":false,"context_lines":[{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        self.assertNotEqual(old_hash, new_hash)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    def test_image_metadata_payload(self):"},{"line_number":483,"context_line":"        self.assertEqual("},{"line_number":484,"context_line":"            ImageMetaPropsPayload.fields.keys(),"},{"line_number":485,"context_line":"            objects.image_meta.ImageMetaProps.fields.keys())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9aa840d9","line":482,"range":{"start_line":482,"start_character":4,"end_line":482,"end_character":42},"updated":"2019-12-12 01:57:31.000000000","message":"i might move this into its own class","commit_id":"2c401725038c31dcc005f55490224473bd788389"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b8405093ed037268c30f12c823086f5519cf7d73","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            ImageMetaPropsPayload.fields.keys(),"},{"line_number":494,"context_line":"            objects.image_meta.ImageMetaProps.fields.keys())"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def test_schema_field_sync(self):"},{"line_number":497,"context_line":"        \"\"\"Assert the fields of the ImageMetaPropsPayload object are"},{"line_number":498,"context_line":"        in sync with schema definition."},{"line_number":499,"context_line":"        \"\"\""},{"line_number":500,"context_line":"        self.assertEqual("},{"line_number":501,"context_line":"            ImageMetaPropsPayload.fields.keys(),"},{"line_number":502,"context_line":"            ImageMetaPropsPayload.SCHEMA.keys())"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    def test_schema(self):"},{"line_number":505,"context_line":"        \"\"\"Assert the schema is generated correctly\"\"\""},{"line_number":506,"context_line":"        for key, value in ImageMetaPropsPayload.SCHEMA.items():"},{"line_number":507,"context_line":"            self.assertEqual((\u0027image_meta_props\u0027, key), value)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"def get_extra_data(obj_class):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_720c7aea","line":507,"range":{"start_line":496,"start_character":0,"end_line":507,"end_character":62},"updated":"2019-12-12 23:27:49.000000000","message":"nts: can remove these in the next patch","commit_id":"40d6a8b6f309bb472efad6c0cf4c4a512b830993"}]}
