)]}'
{"nova/notifications/objects/image.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ad924a7ca61227612deeeaa6e559eb55d3380a33","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    # Version 1.1: Added \u0027gop\u0027, \u0027virtio\u0027 and  \u0027none\u0027 to hw_video_model field"},{"line_number":110,"context_line":"    # Version 1.2: Added hw_pci_numa_affinity_policy field"},{"line_number":111,"context_line":"    # Version 1.3: Added hw_mem_encryption, hw_pmu and hw_time_hpet  fields"},{"line_number":112,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    SCHEMA \u003d {"},{"line_number":115,"context_line":"        k: (\u0027image_meta_props\u0027, k) for k in image_meta.ImageMetaProps.fields}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2c3a2ccc","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":19},"updated":"2019-12-12 21:47:06.000000000","message":"as noted on irc with this change everytime we update\nimage_meta.ImageMetaProps the filed of this object will be updated. this will cause the hash to change but not the version we need to add a comment here to specificity say that the new filed should be listed as above and that the version should be bumped.","commit_id":"8338e13f2756f47d9d9c5293207d71259457ca84"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b1e450150e9ba313aa1fe9e5cd49d9c853adc71b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    # Version 1.1: Added \u0027gop\u0027, \u0027virtio\u0027 and  \u0027none\u0027 to hw_video_model field"},{"line_number":110,"context_line":"    # Version 1.2: Added hw_pci_numa_affinity_policy field"},{"line_number":111,"context_line":"    # Version 1.3: Added hw_mem_encryption, hw_pmu and hw_time_hpet  fields"},{"line_number":112,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    SCHEMA \u003d {"},{"line_number":115,"context_line":"        k: (\u0027image_meta_props\u0027, k) for k in image_meta.ImageMetaProps.fields}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_4fdaf049","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":19},"in_reply_to":"3fa7e38b_2c3a2ccc","updated":"2019-12-13 14:59:54.000000000","message":"Done","commit_id":"8338e13f2756f47d9d9c5293207d71259457ca84"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d1ac7b508ad261dec90caafca7b231d2cd59f374","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    # NOTE(efried): It\u0027s possible this could just be:"},{"line_number":118,"context_line":"    #      fields \u003d image_meta.ImageMetaProps.fields"},{"line_number":119,"context_line":"    #  But it is not clear that OVO can tolerate the same *instance* of a type"},{"line_number":120,"context_line":"    #  class being used in more than one place."},{"line_number":121,"context_line":"    fields \u003d {"},{"line_number":122,"context_line":"        k: v.__class__() for k, v in image_meta.ImageMetaProps.fields.items()}"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d1de8f0e","line":120,"range":{"start_line":119,"start_character":11,"end_line":120,"end_character":47},"updated":"2019-12-12 21:07:41.000000000","message":"http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-12-12.log.html#t2019-12-12T20:59:38","commit_id":"8338e13f2756f47d9d9c5293207d71259457ca84"}],"nova/tests/unit/notifications/objects/test_notification.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d1ac7b508ad261dec90caafca7b231d2cd59f374","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    \u0027FlavorNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":385,"context_line":"    \u0027FlavorPayload\u0027: \u00271.4-2e7011b8b4e59167fe8b7a0a81f0d452\u0027,"},{"line_number":386,"context_line":"    \u0027ImageMetaPayload\u0027: \u00271.0-0e65beeacb3393beed564a57bc2bc989\u0027,"},{"line_number":387,"context_line":"    \u0027ImageMetaPropsPayload\u0027: \u00271.3-9c200c895932163a4e14e6bb385fa1e0\u0027,"},{"line_number":388,"context_line":"    \u0027InstanceActionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":389,"context_line":"    \u0027InstanceActionPayload\u0027: \u00271.8-4fa3da9cbf0761f1f700ae578f36dc2f\u0027,"},{"line_number":390,"context_line":"    \u0027InstanceActionRebuildNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_11bbc7bd","line":387,"updated":"2019-12-12 21:07:41.000000000","message":"this delta because there\u0027s a typo in the previous patch (\u0027image_meta_pros\u0027); it\u0027ll go away in the rebase once that\u0027s fixed.","commit_id":"8338e13f2756f47d9d9c5293207d71259457ca84"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ad924a7ca61227612deeeaa6e559eb55d3380a33","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    \u0027FlavorNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":385,"context_line":"    \u0027FlavorPayload\u0027: \u00271.4-2e7011b8b4e59167fe8b7a0a81f0d452\u0027,"},{"line_number":386,"context_line":"    \u0027ImageMetaPayload\u0027: \u00271.0-0e65beeacb3393beed564a57bc2bc989\u0027,"},{"line_number":387,"context_line":"    \u0027ImageMetaPropsPayload\u0027: \u00271.3-9c200c895932163a4e14e6bb385fa1e0\u0027,"},{"line_number":388,"context_line":"    \u0027InstanceActionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":389,"context_line":"    \u0027InstanceActionPayload\u0027: \u00271.8-4fa3da9cbf0761f1f700ae578f36dc2f\u0027,"},{"line_number":390,"context_line":"    \u0027InstanceActionRebuildNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ec44144a","line":387,"in_reply_to":"3fa7e38b_11bbc7bd","updated":"2019-12-12 21:47:06.000000000","message":"following on from my other comment.\n\nwe also might want to add a comment here stating that if the hash changes for this object that instead of updating hash alone the version should also be bumped and a comment added in the ImageMetaPropsPayload class.","commit_id":"8338e13f2756f47d9d9c5293207d71259457ca84"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b1e450150e9ba313aa1fe9e5cd49d9c853adc71b","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    \u0027FlavorNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":385,"context_line":"    \u0027FlavorPayload\u0027: \u00271.4-2e7011b8b4e59167fe8b7a0a81f0d452\u0027,"},{"line_number":386,"context_line":"    \u0027ImageMetaPayload\u0027: \u00271.0-0e65beeacb3393beed564a57bc2bc989\u0027,"},{"line_number":387,"context_line":"    \u0027ImageMetaPropsPayload\u0027: \u00271.3-9c200c895932163a4e14e6bb385fa1e0\u0027,"},{"line_number":388,"context_line":"    \u0027InstanceActionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":389,"context_line":"    \u0027InstanceActionPayload\u0027: \u00271.8-4fa3da9cbf0761f1f700ae578f36dc2f\u0027,"},{"line_number":390,"context_line":"    \u0027InstanceActionRebuildNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0fe078f7","line":387,"in_reply_to":"3fa7e38b_ec44144a","updated":"2019-12-13 14:59:54.000000000","message":"Done","commit_id":"8338e13f2756f47d9d9c5293207d71259457ca84"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b1e450150e9ba313aa1fe9e5cd49d9c853adc71b","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        self.assertNotEqual(old_hash, new_hash)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"class TestImageMetaPropsPayloadNotifications(test.NoDBTestCase):"},{"line_number":484,"context_line":"    def setUp(self):"},{"line_number":485,"context_line":"        super().setUp()"},{"line_number":486,"context_line":"        base.NovaObjectRegistry.register_notification_objects()"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    def test_object_field_sync(self):"},{"line_number":489,"context_line":"        \"\"\"Assert the fields of the ImageMetaPropsPayload object are"},{"line_number":490,"context_line":"        in sync with the fields of the ImageMetaProps object."},{"line_number":491,"context_line":"        \"\"\""},{"line_number":492,"context_line":"        self.assertEqual("},{"line_number":493,"context_line":"            ImageMetaPropsPayload.fields.keys(),"},{"line_number":494,"context_line":"            objects.image_meta.ImageMetaProps.fields.keys())"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def test_schema_field_sync(self):"},{"line_number":497,"context_line":"        \"\"\"Assert the fields of the ImageMetaPropsPayload object are"},{"line_number":498,"context_line":"        in sync with schema definition."},{"line_number":499,"context_line":"        \"\"\""},{"line_number":500,"context_line":"        self.assertEqual("},{"line_number":501,"context_line":"            ImageMetaPropsPayload.fields.keys(),"},{"line_number":502,"context_line":"            ImageMetaPropsPayload.SCHEMA.keys())"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"def get_extra_data(obj_class):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d2fc4eb7","line":502,"range":{"start_line":483,"start_character":0,"end_line":502,"end_character":48},"updated":"2019-12-13 14:59:54.000000000","message":"this is no longer useful","commit_id":"8338e13f2756f47d9d9c5293207d71259457ca84"}]}