)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fbab7d65221ed1fdd02dbff27172691748a40dab","unresolved":false,"context_lines":[{"line_number":3676,"context_line":"    def confirm_resize(self, context, instance, migration\u003dNone):"},{"line_number":3677,"context_line":"        \"\"\"Confirms a migration/resize and deletes the \u0027old\u0027 instance."},{"line_number":3678,"context_line":""},{"line_number":3679,"context_line":"        :param context: nova auth RequestContext"},{"line_number":3680,"context_line":"        :param instance: Instance object to confirm the resize"},{"line_number":3681,"context_line":"        :param migration: Migration object; provided if called from the"},{"line_number":3682,"context_line":"            _poll_unconfirmed_resizes periodic task on the dest compute."}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_31c6d54c","line":3679,"updated":"2019-12-16 22:02:09.000000000","message":"Should probably just bump this to the next change in the series that needed to modify it.","commit_id":"f66fa4c218e9eb3abfce83b74bf3c2bf2aeae28d"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a3e944b80137f1846120783ce3ecbd434094904f","unresolved":false,"context_lines":[{"line_number":8861,"context_line":"                # anything failed and we need to update the migration status."},{"line_number":8862,"context_line":"                self.compute_api.confirm_resize(context, instance,"},{"line_number":8863,"context_line":"                                                migration\u003dmigration,"},{"line_number":8864,"context_line":"                                                sync\u003dTrue)"},{"line_number":8865,"context_line":"            except Exception as e:"},{"line_number":8866,"context_line":"                LOG.info(\"Error auto-confirming resize: %s. \""},{"line_number":8867,"context_line":"                         \"Will retry later.\", e, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0ab29f97","line":8864,"updated":"2019-12-13 22:54:27.000000000","message":"I needed this to make the test go otherwise I would have had to stub out the confirm_resize RPC method to fail but I wasn\u0027t sure how realistic that would be. Besides, this is likely useful anyway if we want to react to a failure here in the task. It really depends on what and where the fix is going to be. Maybe the fix is that the API checks the status of the source compute and if it\u0027s down (via the service group API) then it just fails before ever modifying the status on the migration record, in which case we don\u0027t need this sync change.","commit_id":"a7bbc9d619e880b3c6ca778d07dc4a9b992df387"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f78c57821eacdc59023681709d45f02090c3b916","unresolved":false,"context_lines":[{"line_number":9092,"context_line":"            try:"},{"line_number":9093,"context_line":"                # Make the API perform a synchronous RPC call so we can know if"},{"line_number":9094,"context_line":"                # anything failed and we need to update the migration status."},{"line_number":9095,"context_line":"                # NOTE(mriedem): I needed the sync kwarg to make the test go"},{"line_number":9096,"context_line":"                # otherwise I would have had to stub out the confirm_resize RPC"},{"line_number":9097,"context_line":"                # method to fail but I wasn\u0027t sure how realistic that would be."},{"line_number":9098,"context_line":"                # Besides, this is likely useful anyway if we want to react to"},{"line_number":9099,"context_line":"                # a failure here in the task. It really depends on what and"},{"line_number":9100,"context_line":"                # where the fix is going to be. Maybe the fix is that the API"},{"line_number":9101,"context_line":"                # checks the status of the source compute and if it\u0027s down"},{"line_number":9102,"context_line":"                # (via the service group API) then it just fails before ever"},{"line_number":9103,"context_line":"                # modifying the status on the migration record, in which case"},{"line_number":9104,"context_line":"                # we don\u0027t need this sync change."},{"line_number":9105,"context_line":"                self.compute_api.confirm_resize(context, instance,"},{"line_number":9106,"context_line":"                                                migration\u003dmigration,"},{"line_number":9107,"context_line":"                                                sync\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_917d496f","line":9104,"range":{"start_line":9095,"start_character":16,"end_line":9104,"end_character":49},"updated":"2019-12-16 21:27:17.000000000","message":"We can use the CastAsCall fixture in the test to simulate this and remove the need for the sync kwarg.","commit_id":"682e50c8b0196276ff7676314d94026e2d92c2b5"}]}