)]}'
{"nova/compute/utils.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"f022065ca6124834dd132a71bc2f538cd99775ce","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"    handle and not re-raise on InstanceActionNotFound."},{"line_number":1372,"context_line":"    \"\"\""},{"line_number":1373,"context_line":""},{"line_number":1374,"context_line":"    def __init__(self, context, event_name, host, *instance_uuids,"},{"line_number":1375,"context_line":"                 graceful_exit\u003dFalse):"},{"line_number":1376,"context_line":"        self.context \u003d context"},{"line_number":1377,"context_line":"        self.event_name \u003d event_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_2254bb55","line":1374,"range":{"start_line":1374,"start_character":50,"end_line":1374,"end_character":65},"updated":"2020-01-06 05:40:44.000000000","message":"variable args shouldn\u0027t be the last argument? not sure why it\u0027s being allowed in python3, seems it\u0027s being assumed while calling parameter names will be passed.","commit_id":"24bf2aaa7441430a84b475efca9f4777dc243452"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"5de8e46c56110ff53d9fce24637fb4bbe64b6166","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"    handle and not re-raise on InstanceActionNotFound."},{"line_number":1372,"context_line":"    \"\"\""},{"line_number":1373,"context_line":""},{"line_number":1374,"context_line":"    def __init__(self, context, event_name, host, *instance_uuids,"},{"line_number":1375,"context_line":"                 graceful_exit\u003dFalse):"},{"line_number":1376,"context_line":"        self.context \u003d context"},{"line_number":1377,"context_line":"        self.event_name \u003d event_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_62ecf391","line":1374,"range":{"start_line":1374,"start_character":50,"end_line":1374,"end_character":65},"in_reply_to":"3fa7e38b_2254bb55","updated":"2020-01-06 05:42:51.000000000","message":"Ok, python3 has added keyword-only arguments, which is not compatible with python2. https://python-3-for-scientists.readthedocs.io/en/latest/python3_advanced.html#keyword-only-arguments","commit_id":"24bf2aaa7441430a84b475efca9f4777dc243452"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ad1af04d6a2f64d1469cc844b50ed6776478d19","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"                # should re-raise based on the graceful_exit attribute."},{"line_number":1399,"context_line":"                with excutils.save_and_reraise_exception("},{"line_number":1400,"context_line":"                        reraise\u003dnot self.graceful_exit):"},{"line_number":1401,"context_line":"                    if self.graceful_exit:"},{"line_number":1402,"context_line":"                        return True"},{"line_number":1403,"context_line":"        return False"},{"line_number":1404,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_cc5ba320","line":1401,"updated":"2020-01-03 20:06:43.000000000","message":"I could be wrong, but I think this is mostly a pointless conditional and that we could just make the body of the \"with\" be just \"return true\". If we\u0027re going to reraise, we\u0027re not going to return anyway, otherwise we want to return true right?\n\nIt\u0027s just a nit, but I had to think about this a bit, about whether or not we can fall out of here and return False, etc.","commit_id":"24bf2aaa7441430a84b475efca9f4777dc243452"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"09d50213c415207fcbd8236042b38ac98aa4af26","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"                # should re-raise based on the graceful_exit attribute."},{"line_number":1399,"context_line":"                with excutils.save_and_reraise_exception("},{"line_number":1400,"context_line":"                        reraise\u003dnot self.graceful_exit):"},{"line_number":1401,"context_line":"                    if self.graceful_exit:"},{"line_number":1402,"context_line":"                        return True"},{"line_number":1403,"context_line":"        return False"},{"line_number":1404,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_72960440","line":1401,"in_reply_to":"3fa7e38b_cc5ba320","updated":"2020-01-04 14:32:07.000000000","message":"I think that technically this __exit__ always returning False is incorrect. When I wrote this I read the docs and __exit__ should only return False if there was an error exiting the context I think, otherwise you\u0027re supposed to return something Truthy. So in this case, if graceful_exit is True, reraise is going to be False and we\u0027ll return True to indicate we\u0027re exiting normally. Having said that, it doesn\u0027t seem that this returning False all the time otherwise has any side effect that I can determine.","commit_id":"24bf2aaa7441430a84b475efca9f4777dc243452"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ad1af04d6a2f64d1469cc844b50ed6776478d19","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"        \"compute\" or \"conductor\" to indicate the origin of the event."},{"line_number":1414,"context_line":"    :param graceful_exit: True if the decorator should gracefully handle"},{"line_number":1415,"context_line":"        InstanceActionNotFound errors, False otherwise. This should rarely be"},{"line_number":1416,"context_line":"        True."},{"line_number":1417,"context_line":"    \"\"\""},{"line_number":1418,"context_line":"    @utils.expects_func_args(\u0027instance\u0027)"},{"line_number":1419,"context_line":"    def helper(function):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ac9c27bf","line":1416,"updated":"2020-01-03 20:06:43.000000000","message":"I wonder if it\u0027d be worth actually calling out when and why this would ever be true. It\u0027s easy to read this and think \"oh but _I_ am special too, so I should set this.\" In reality, this should only ever be set if we\u0027re moving the instance to a new cell and thus all this stuff is gone (right?), which wouldn\u0027t be the case if the user (soft-)deleted the instance in the middle of an operation.","commit_id":"24bf2aaa7441430a84b475efca9f4777dc243452"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"09d50213c415207fcbd8236042b38ac98aa4af26","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"        \"compute\" or \"conductor\" to indicate the origin of the event."},{"line_number":1414,"context_line":"    :param graceful_exit: True if the decorator should gracefully handle"},{"line_number":1415,"context_line":"        InstanceActionNotFound errors, False otherwise. This should rarely be"},{"line_number":1416,"context_line":"        True."},{"line_number":1417,"context_line":"    \"\"\""},{"line_number":1418,"context_line":"    @utils.expects_func_args(\u0027instance\u0027)"},{"line_number":1419,"context_line":"    def helper(function):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_129f9051","line":1416,"in_reply_to":"3fa7e38b_ac9c27bf","updated":"2020-01-04 14:32:07.000000000","message":"I wasn\u0027t sure what to say, I just knew it should say you probably don\u0027t want to make this True unless you know what you\u0027re doing. I think I probably didn\u0027t say anything cells specific to avoid coupling it to how I\u0027m relying on it in this series and if there was another use case later.  I figure if someone needs this in the future they\u0027ll look at the one existing place it\u0027s used and sort out why it\u0027s used there.","commit_id":"24bf2aaa7441430a84b475efca9f4777dc243452"}]}