)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a0f120ca99d5b6871c8471c4d0b3e4e1c4afa886","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Nova should switch to using tenant ID for admin authentication."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements blueprint tenant-id-based-auth-for-neutron"},{"line_number":13,"context_line":"DocImpact: New flag introduced"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I4a4ffe84fdcf98ace81fd148f096cad483aad96c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAVX%2F%2F%2BmU%3D","line":13,"updated":"2014-02-27 02:03:26.000000000","message":"I\u0027d probably also add a mention of deprecating neutron_admin_tenant_name.","commit_id":"9f438593471c4b770cf87a92ba43e04357165b74"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"47b33fbd383a93fa725de31a555eb38031462544","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               secret\u003dTrue),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_id\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027Tenant id for connecting to neutron in admin context\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_name\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027Tenant name for connecting to neutron in admin context. \u0027"},{"line_number":57,"context_line":"                    \u0027Only used if neutron_admin_tenant_id is not set. Note \u0027"},{"line_number":58,"context_line":"                    \u0027that with Keystone V3 tenant names may not be unique.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FnLY%3D","line":55,"updated":"2014-02-25 17:13:22.000000000","message":"is there any reason why this shouldn\u0027t be marked deprecated?","commit_id":"02fbcbe80aceefb916b9d6736f7b0c88c56a2206"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4a4fbc641c8f683f52d0a78b83a81c9c25f9e26d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               secret\u003dTrue),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_id\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027Tenant id for connecting to neutron in admin context\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_name\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027Tenant name for connecting to neutron in admin context. \u0027"},{"line_number":57,"context_line":"                    \u0027Only used if neutron_admin_tenant_id is not set. Note \u0027"},{"line_number":58,"context_line":"                    \u0027that with Keystone V3 tenant names may not be unique.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fj%2Fg%3D","line":55,"in_reply_to":"AAAAU3%2F%2FmFo%3D","updated":"2014-02-25 22:25:50.000000000","message":"Well it leaves us with a behavior in the code where if they specify both, id is used. I think I\u0027d rather just decide name isn\u0027t good enough any more (which I think is valid), and go with id instead. Especially as keystone is deprecating v2 in icehouse.","commit_id":"02fbcbe80aceefb916b9d6736f7b0c88c56a2206"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"ea95bbf7af5eb87cfe00ffd1e60dc4398438656b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               secret\u003dTrue),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_id\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027Tenant id for connecting to neutron in admin context\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_name\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027Tenant name for connecting to neutron in admin context. \u0027"},{"line_number":57,"context_line":"                    \u0027Only used if neutron_admin_tenant_id is not set. Note \u0027"},{"line_number":58,"context_line":"                    \u0027that with Keystone V3 tenant names may not be unique.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FmFo%3D","line":55,"in_reply_to":"AAAAU3%2F%2FnLY%3D","updated":"2014-02-25 18:49:56.000000000","message":"Name is still a valid way to authenticate - so I didn\u0027t see why users (who might choose to keep names unique) should be forced to change. \n\nThis was more about adding an extra capability ready for the switch to Keystone V3 than mandating a change, so I didn\u0027t think it was right to deprecate the tenant_name option","commit_id":"02fbcbe80aceefb916b9d6736f7b0c88c56a2206"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a39dfe24ff61b6cdf92b7fafeeb4d51dc9b3dc35","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_name\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027DEPRECATED: Tenant name for connecting to neutron in \u0027"},{"line_number":56,"context_line":"                    \u0027admin context.  This option is deprecated.  Please use \u0027"},{"line_number":57,"context_line":"                    \u0027neutron_admin_tenant_id instead .Note that with Keystone \u0027"},{"line_number":58,"context_line":"                    \u0027V3 tenant names may not be unique.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027neutron_region_name\u0027,"},{"line_number":60,"context_line":"               help\u003d\u0027Region name for connecting to neutron in admin context\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAU3%2F%2FY7c%3D","line":57,"updated":"2014-02-26 22:00:05.000000000","message":"Because this is help, I think we should probably get the spacing right around the period. Which is a minor nit.","commit_id":"3bc29c68604f28c59bd9042d2138db4bf1cd74f7"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"ba7d8127c0dba72ad584967415924f6aaad97e5c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_name\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027DEPRECATED: Tenant name for connecting to neutron in \u0027"},{"line_number":56,"context_line":"                    \u0027admin context.  This option is deprecated.  Please use \u0027"},{"line_number":57,"context_line":"                    \u0027neutron_admin_tenant_id instead .Note that with Keystone \u0027"},{"line_number":58,"context_line":"                    \u0027V3 tenant names may not be unique.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027neutron_region_name\u0027,"},{"line_number":60,"context_line":"               help\u003d\u0027Region name for connecting to neutron in admin context\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2F%2F3Q%3D","line":57,"in_reply_to":"AAAAU3%2F%2FY7c%3D","updated":"2014-02-26 22:55:23.000000000","message":"Done","commit_id":"3bc29c68604f28c59bd9042d2138db4bf1cd74f7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a0f120ca99d5b6871c8471c4d0b3e4e1c4afa886","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_id\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027Tenant id for connecting to neutron in admin context\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_name\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027DEPRECATED: Tenant name for connecting to neutron in \u0027"},{"line_number":56,"context_line":"                    \u0027admin context.  This option is deprecated.  Please use \u0027"},{"line_number":57,"context_line":"                    \u0027neutron_admin_tenant_id instead. Note that with Keystone \u0027"},{"line_number":58,"context_line":"                    \u0027V3 tenant names may not be unique.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVX%2F%2F%2Bmw%3D","line":55,"updated":"2014-02-27 02:03:26.000000000","message":"There is actually a better way to deprecate an option, see DeprecatedOpt in oslo.config:\n\nhttps://github.com/openstack/oslo.config/blob/master/oslo/config/cfg.py#L764","commit_id":"9f438593471c4b770cf87a92ba43e04357165b74"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"64ed3ff0c7d0fab786e869cd530c59ae71cf783a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_id\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027Tenant id for connecting to neutron in admin context\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_name\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027DEPRECATED: Tenant name for connecting to neutron in \u0027"},{"line_number":56,"context_line":"                    \u0027admin context.  This option is deprecated.  Please use \u0027"},{"line_number":57,"context_line":"                    \u0027neutron_admin_tenant_id instead. Note that with Keystone \u0027"},{"line_number":58,"context_line":"                    \u0027V3 tenant names may not be unique.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVX%2F%2F7w4%3D","line":55,"in_reply_to":"AAAAVX%2F%2F%2Bi4%3D","updated":"2014-02-27 09:38:17.000000000","message":"Yep - that\u0027s my understanding too, the oslo deprecation tooling seems to only really cope with a rename (i.e. it allows you to change the name and group of a config value, but not to say that  \"newopt\u003dnewval\"  replaces \"oldopt\u003doldval\"\n\nIf I declare that \"oldopt\" is deprecated be \"newopt\", and the config file includes \"oldopt\" then when I try to get the value of \"newopt\" it will return the value of \"oldopt\" without telling me that it found \"oldopt\" and not \"newopt\"","commit_id":"9f438593471c4b770cf87a92ba43e04357165b74"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"20d51ef9c1613c97a6bf6e742ea50aea4055cd36","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_id\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027Tenant id for connecting to neutron in admin context\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_name\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027DEPRECATED: Tenant name for connecting to neutron in \u0027"},{"line_number":56,"context_line":"                    \u0027admin context.  This option is deprecated.  Please use \u0027"},{"line_number":57,"context_line":"                    \u0027neutron_admin_tenant_id instead. Note that with Keystone \u0027"},{"line_number":58,"context_line":"                    \u0027V3 tenant names may not be unique.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVX%2F%2F%2Bi4%3D","line":55,"in_reply_to":"AAAAVX%2F%2F%2Bmw%3D","updated":"2014-02-27 02:12:11.000000000","message":"I might be wrong about how DeprecatedOpt it used, it actually looks like the deprecated stuff in olso.config is to deprecate one option in favor of another, so when it parses the options and the old option shows up, it will replace it with the new so the underlying code works.  That\u0027s not what we\u0027re doing here.  I\u0027m asking around about it in IRC to see if the oslo guys can clarify.","commit_id":"9f438593471c4b770cf87a92ba43e04357165b74"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"75c8c7770dc52993ede00610c9e8b731239d2ef4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_id\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027Tenant id for connecting to neutron in admin context\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_name\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027DEPRECATED: Tenant name for connecting to neutron in \u0027"},{"line_number":56,"context_line":"                    \u0027admin context.  This option is deprecated.  Please use \u0027"},{"line_number":57,"context_line":"                    \u0027neutron_admin_tenant_id instead. Note that with Keystone \u0027"},{"line_number":58,"context_line":"                    \u0027V3 tenant names may not be unique.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVX%2F%2F4Eo%3D","line":55,"in_reply_to":"AAAAVX%2F%2F6eo%3D","updated":"2014-02-27 16:42:19.000000000","message":"Dims, I opened wishlist bug 1285768.","commit_id":"9f438593471c4b770cf87a92ba43e04357165b74"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"1624b5ab37225c756cf67ae75a50b4a19d4ed868","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_id\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027Tenant id for connecting to neutron in admin context\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027neutron_admin_tenant_name\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027DEPRECATED: Tenant name for connecting to neutron in \u0027"},{"line_number":56,"context_line":"                    \u0027admin context.  This option is deprecated.  Please use \u0027"},{"line_number":57,"context_line":"                    \u0027neutron_admin_tenant_id instead. Note that with Keystone \u0027"},{"line_number":58,"context_line":"                    \u0027V3 tenant names may not be unique.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVX%2F%2F6eo%3D","line":55,"in_reply_to":"AAAAVX%2F%2F7w4%3D","updated":"2014-02-27 12:21:25.000000000","message":"Correct, DeprecatedOpt is only where there is a name change or a name+group change. Can you please log a request to support this use case please?\n\nthanks,\ndims","commit_id":"9f438593471c4b770cf87a92ba43e04357165b74"}],"nova/tests/network/test_neutronv2.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5fe55511de98eaa2ba69895101b9497f1e0604da","unresolved":false,"context_lines":[{"line_number":2039,"context_line":"        self.flags(neutron_admin_tenant_id\u003d\u0027admin_tenant_id\u0027)"},{"line_number":2040,"context_line":"        my_context \u003d context.RequestContext(\u0027userid\u0027, \u0027my_tenantid\u0027,"},{"line_number":2041,"context_line":"                                            auth_token\u003d\u0027token\u0027)"},{"line_number":2042,"context_line":"        self.mox.StubOutWithMock(client.Client, \"__init__\")"},{"line_number":2043,"context_line":"        client.Client.__init__("},{"line_number":2044,"context_line":"            auth_url\u003dCONF.neutron_admin_auth_url,"},{"line_number":2045,"context_line":"            password\u003dCONF.neutron_admin_password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FmE4%3D","line":2042,"updated":"2014-02-25 18:51:54.000000000","message":"Should be using mock now, otherwise can this be consolidated with the previous test case so we can avoid the 95% duplication in code?","commit_id":"02fbcbe80aceefb916b9d6736f7b0c88c56a2206"}]}