)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"322d350a7232c9955ed41614bd37fea2ae4fb9f6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"vhost-user does not use the kernel vhost module and"},{"line_number":22,"context_line":"was not constained by the kernel limitation on queue"},{"line_number":23,"context_line":"count however the change to adress bug #1570631 did not"},{"line_number":24,"context_line":"thake that into account."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This change removes the max queue limit based on kernel"},{"line_number":27,"context_line":"version for vhost-user interfaces and also asserts that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_656d9997","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":5},"updated":"2020-04-07 13:34:54.000000000","message":"take","commit_id":"a6b27d79d0012b7a70808b310bdd2ec88b219885"}],"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"322d350a7232c9955ed41614bd37fea2ae4fb9f6","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        self.flags(max_queues\u003d2, group\u003d\u0027libvirt\u0027)"},{"line_number":675,"context_line":"        self._test_virtio_multiqueue(10, \u00272\u0027)"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def _test_vhostuser_os_vif_multiqueue(self, cpus\u003d4):"},{"line_number":678,"context_line":"        d \u003d vif.LibvirtGenericVIFDriver()"},{"line_number":679,"context_line":"        hostimpl \u003d host.Host(\"qemu:///system\")"},{"line_number":680,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict("}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_85c09de2","line":677,"range":{"start_line":677,"start_character":52,"end_line":677,"end_character":55},"updated":"2020-04-07 13:34:54.000000000","message":"no need to set this since you\u0027re never using the default","commit_id":"a6b27d79d0012b7a70808b310bdd2ec88b219885"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6129b221f230c27ec3828b59a3fe121d4e09ab27","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        self.flags(max_queues\u003d2, group\u003d\u0027libvirt\u0027)"},{"line_number":675,"context_line":"        self._test_virtio_multiqueue(10, \u00272\u0027)"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def _test_vhostuser_os_vif_multiqueue(self, cpus\u003d4):"},{"line_number":678,"context_line":"        d \u003d vif.LibvirtGenericVIFDriver()"},{"line_number":679,"context_line":"        hostimpl \u003d host.Host(\"qemu:///system\")"},{"line_number":680,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict("}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_58215cfb","line":677,"range":{"start_line":677,"start_character":52,"end_line":677,"end_character":55},"in_reply_to":"df33271e_85c09de2","updated":"2023-02-15 17:42:04.000000000","message":"yep that is fair","commit_id":"a6b27d79d0012b7a70808b310bdd2ec88b219885"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"322d350a7232c9955ed41614bd37fea2ae4fb9f6","unresolved":false,"context_lines":[{"line_number":552,"context_line":"            img_props \u003d image_meta.properties"},{"line_number":553,"context_line":"            multiqueue \u003d img_props.get(\u0027hw_vif_multiqueue_enabled\u0027)"},{"line_number":554,"context_line":"            self._set_config_VIFVHostUser("},{"line_number":555,"context_line":"                instance, vif, conf, host, multiqueue\u003dmultiqueue)"},{"line_number":556,"context_line":"        elif isinstance(vif, osv_vifs.VIFHostDevice):"},{"line_number":557,"context_line":"            self._set_config_VIFHostDevice(instance, vif, conf, host)"},{"line_number":558,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_d898cc6b","line":555,"updated":"2020-04-07 13:34:54.000000000","message":"I don\u0027t like the special casing of this particular helper, nor the fact that we\u0027re reselecting our multiqueue value so far away from the original place we do that (_get_virtio_mq_settings). Let\u0027s do that in one place instead.\n\nCould we do this inside \u0027get_base_config\u0027 instead? We could modify that to pass the entire VIF object in instead of just vif.address, and then do this check inside there? Alternatively, we could move the call to \u0027_get_virtio_mq_settings\u0027 out of \u0027get_base_config\u0027 into here, which would be even nicer but might not be possible (I haven\u0027t quite re-grokked the relationship between \u0027vnic_type\u0027 and the VIF object type)","commit_id":"a6b27d79d0012b7a70808b310bdd2ec88b219885"}]}