)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"079ae6241497d2f86b8c0b1a5afc2f019f86089c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nikola Dipanov \u003cndipanov@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-30 16:14:44 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move some compute methods to BDM objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch makes the compute manager\u0027s"},{"line_number":10,"context_line":"_get_instance_volume_block_device_info method use objects internally."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F998Y%3D","line":7,"updated":"2014-01-31 15:28:12.000000000","message":"This patch affects only one method in compute manager. I would argue that the patch title is thus incorrect :)","commit_id":"620336031aee93c35ab2cefbdea3386791a836af"}],"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e1e2f66407d2ac03ecd61ab5fe5f246981cfb9b0","unresolved":false,"context_lines":[{"line_number":1543,"context_line":"    def _get_instance_volume_bdms(self, context, instance, legacy\u003dTrue):"},{"line_number":1544,"context_line":"        if isinstance(instance, instance_obj.Instance):"},{"line_number":1545,"context_line":"            instance \u003d obj_base.obj_to_primitive(instance)"},{"line_number":1546,"context_line":"        return self._get_volume_bdms("},{"line_number":1547,"context_line":"            self.conductor_api.block_device_mapping_get_all_by_instance("},{"line_number":1548,"context_line":"                context, instance, legacy), legacy)"},{"line_number":1549,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAU3%2F%2F9aw%3D","line":1546,"updated":"2014-02-23 13:40:45.000000000","message":"Out of interst, why was this not changed to:\nblock_device_obj.BlockDeviceMappingList.get_by_instance_uuid(context, instance[\u0027uuid\u0027])?","commit_id":"76054ed1c144ee06444cfe4cf5cb31e87a86130f"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"329a458fe502b82e921a937f952c70552f6d677d","unresolved":false,"context_lines":[{"line_number":2383,"context_line":"                               _fake_get_instance_volume_bdms):"},{"line_number":2384,"context_line":"            block_device_info \u003d ("},{"line_number":2385,"context_line":"                self.compute._get_instance_volume_block_device_info("},{"line_number":2386,"context_line":"                    self.context, self._create_fake_instance())"},{"line_number":2387,"context_line":"            )"},{"line_number":2388,"context_line":"            expected \u003d {"},{"line_number":2389,"context_line":"                \u0027block_device_mapping\u0027: [{"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FpuM%3D","line":2386,"updated":"2014-02-11 18:31:44.000000000","message":"needs a test for bdms \u003d None","commit_id":"fa3c74f5bb7d08b96dc4448694457fcbba38455f"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"a13d377d4551d729c4cc0ca19c219fedf1e6ee9f","unresolved":false,"context_lines":[{"line_number":2383,"context_line":"                               _fake_get_instance_volume_bdms):"},{"line_number":2384,"context_line":"            block_device_info \u003d ("},{"line_number":2385,"context_line":"                self.compute._get_instance_volume_block_device_info("},{"line_number":2386,"context_line":"                    self.context, self._create_fake_instance())"},{"line_number":2387,"context_line":"            )"},{"line_number":2388,"context_line":"            expected \u003d {"},{"line_number":2389,"context_line":"                \u0027block_device_mapping\u0027: [{"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FgiM%3D","line":2386,"in_reply_to":"AAAAUX%2F%2FpuM%3D","updated":"2014-02-12 19:02:28.000000000","message":"Well this one kind of tests that - we need to test the other one where we pass in bdms, but yeah - will add it.","commit_id":"fa3c74f5bb7d08b96dc4448694457fcbba38455f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"07fc42ef0c8ac1d7033906c0e1ba57cb89080238","unresolved":false,"context_lines":[{"line_number":2476,"context_line":"                }]"},{"line_number":2477,"context_line":"            }"},{"line_number":2478,"context_line":"            self.assertTrue(mock_get_by_instance.called)"},{"line_number":2479,"context_line":"            self.assertEqual(block_device_info, expected)"},{"line_number":2480,"context_line":""},{"line_number":2481,"context_line":"    def test_get_instance_volume_block_device_info_passed_bdms(self):"},{"line_number":2482,"context_line":"        bdms \u003d block_device_obj.block_device_make_list(self.context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2FEsI%3D","line":2479,"updated":"2014-02-17 10:01:47.000000000","message":"the expected parameter should be first","commit_id":"59f623c471f9a9fffa488dded45a23baf75a5e9a"}]}