)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0594ad440755d0b87a94ce7d9fdda2463d80381d","unresolved":false,"context_lines":[{"line_number":22415,"context_line":"        query \u003d \"devices/disk[source/@file \u003d \u0027%s\u0027]/boot/@order\" % disk_path"},{"line_number":22416,"context_line":"        self.assertEqual(\u00271\u0027, domain.xpath(query)[0])"},{"line_number":22417,"context_line":""},{"line_number":22418,"context_line":"    def test_rescue_stable_device_bfv(self):"},{"line_number":22419,"context_line":"        instance \u003d self._create_instance({\u0027config_drive\u0027: str(True)})"},{"line_number":22420,"context_line":"        # Set ephemeral_gb to 0 to avoid any disk.local disks for being used"},{"line_number":22421,"context_line":"        instance.ephemeral_gb \u003d 0"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_cb600fd2","line":22418,"updated":"2020-03-24 16:41:21.000000000","message":"Something is missing from this test. I reverted the change from the libvirt/driver.py L3458 and the test still passes.","commit_id":"a1a46729d125260ab706c4e060daf6c87b9d1713"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"85860571a3b6fd46e5210bab013bd9f7d9ca5c69","unresolved":false,"context_lines":[{"line_number":22415,"context_line":"        query \u003d \"devices/disk[source/@file \u003d \u0027%s\u0027]/boot/@order\" % disk_path"},{"line_number":22416,"context_line":"        self.assertEqual(\u00271\u0027, domain.xpath(query)[0])"},{"line_number":22417,"context_line":""},{"line_number":22418,"context_line":"    def test_rescue_stable_device_bfv(self):"},{"line_number":22419,"context_line":"        instance \u003d self._create_instance({\u0027config_drive\u0027: str(True)})"},{"line_number":22420,"context_line":"        # Set ephemeral_gb to 0 to avoid any disk.local disks for being used"},{"line_number":22421,"context_line":"        instance.ephemeral_gb \u003d 0"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_c1dc4c76","line":22418,"in_reply_to":"df33271e_08f947c7","updated":"2020-03-26 11:36:21.000000000","message":"OK, but then what test covers the change in the current patch?","commit_id":"a1a46729d125260ab706c4e060daf6c87b9d1713"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"353617af944d69e6b62e76495c5e7d9857019f7f","unresolved":false,"context_lines":[{"line_number":22415,"context_line":"        query \u003d \"devices/disk[source/@file \u003d \u0027%s\u0027]/boot/@order\" % disk_path"},{"line_number":22416,"context_line":"        self.assertEqual(\u00271\u0027, domain.xpath(query)[0])"},{"line_number":22417,"context_line":""},{"line_number":22418,"context_line":"    def test_rescue_stable_device_bfv(self):"},{"line_number":22419,"context_line":"        instance \u003d self._create_instance({\u0027config_drive\u0027: str(True)})"},{"line_number":22420,"context_line":"        # Set ephemeral_gb to 0 to avoid any disk.local disks for being used"},{"line_number":22421,"context_line":"        instance.ephemeral_gb \u003d 0"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_214ff892","line":22418,"in_reply_to":"df33271e_c1dc4c76","updated":"2020-03-26 12:18:53.000000000","message":"Gah, apologies. I\u0027ll add a simple test to assert the capability but might follow up with a functional test that tries to assert the actual traits in a functional env.","commit_id":"a1a46729d125260ab706c4e060daf6c87b9d1713"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"a9a6d2acfb77ba689b463367675ec55e3ee3cb22","unresolved":false,"context_lines":[{"line_number":22415,"context_line":"        query \u003d \"devices/disk[source/@file \u003d \u0027%s\u0027]/boot/@order\" % disk_path"},{"line_number":22416,"context_line":"        self.assertEqual(\u00271\u0027, domain.xpath(query)[0])"},{"line_number":22417,"context_line":""},{"line_number":22418,"context_line":"    def test_rescue_stable_device_bfv(self):"},{"line_number":22419,"context_line":"        instance \u003d self._create_instance({\u0027config_drive\u0027: str(True)})"},{"line_number":22420,"context_line":"        # Set ephemeral_gb to 0 to avoid any disk.local disks for being used"},{"line_number":22421,"context_line":"        instance.ephemeral_gb \u003d 0"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_08f947c7","line":22418,"in_reply_to":"df33271e_cb600fd2","updated":"2020-03-25 15:24:37.000000000","message":"Yeah so this is slightly awkward.\n\nI0e1241ae691afd2af12ef15706c454c05d9f932c introduced support for this within the libvirt driver but it wasn\u0027t reachable at the time due to the following conditional in the compute layer:\n\nhttps://github.com/openstack/nova/blob/35240b0d8c450c42d6f44be5f1df58d850a020d3/nova/compute/api.py#L4238-L4241\n\nThis change is more concerned with reporting the COMPUTE_RESCUE_BFV trait introduced in 622c9635cb225ad2570c671c7b3b14df00532bc6.\n\nI\u0027ll add a more explict note and test for that now.","commit_id":"a1a46729d125260ab706c4e060daf6c87b9d1713"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8b8852d52151698a51e95ee2ec84c49f733927e0","unresolved":false,"context_lines":[{"line_number":3470,"context_line":"                    context, self._image_api, self._volume_api,"},{"line_number":3471,"context_line":"                    block_device_info[\u0027block_device_mapping\u0027],"},{"line_number":3472,"context_line":"                    legacy_bdm\u003dFalse)"},{"line_number":3473,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image_meta_dict)"},{"line_number":3474,"context_line":""},{"line_number":3475,"context_line":"        else:"},{"line_number":3476,"context_line":"            LOG.info(\"Attempting an unstable device rescue\", instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":20,"id":"df33271e_a37bf5bb","line":3473,"updated":"2020-04-08 14:37:03.000000000","message":"looks like you merged two different things into one patch (enable the BFV trait as the main change and try to lookup back to the bdms for the image metadata) but that\u0027s a nit.","commit_id":"d356bca756d53d18ec9f6091ee4258180ddb98c6"}]}