)]}'
{"nova/policies/agents.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"df5ea401b5369298c1f8934e924bdfa29fa623dd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027list\u0027,"},{"line_number":42,"context_line":"        check_str\u003dbase.SYSTEM_READER,"},{"line_number":43,"context_line":"        description\u003d\"\"\"List guest agent builds"},{"line_number":44,"context_line":"This is XenAPI driver specific."},{"line_number":45,"context_line":"It is used to force the upgrade of the XenAPI guest agent on instance boot."},{"line_number":46,"context_line":"\"\"\","},{"line_number":47,"context_line":"        operations\u003d["},{"line_number":48,"context_line":"            {"},{"line_number":49,"context_line":"                \u0027path\u0027: \u0027/os-agents\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5fdb9a78","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":4},"updated":"2020-01-09 03:20:37.000000000","message":"nit: Because it\u0027s text in the body, I think proper indentation is more appropriate.","commit_id":"b76da979425b161697cb00755d39cb04e1daa002"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"82f07c457f8b16ae5620ccecd84ff4a94a94dcda","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027list\u0027,"},{"line_number":42,"context_line":"        check_str\u003dbase.SYSTEM_READER,"},{"line_number":43,"context_line":"        description\u003d\"\"\"List guest agent builds"},{"line_number":44,"context_line":"This is XenAPI driver specific."},{"line_number":45,"context_line":"It is used to force the upgrade of the XenAPI guest agent on instance boot."},{"line_number":46,"context_line":"\"\"\","},{"line_number":47,"context_line":"        operations\u003d["},{"line_number":48,"context_line":"            {"},{"line_number":49,"context_line":"                \u0027path\u0027: \u0027/os-agents\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5bc40041","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":4},"in_reply_to":"3fa7e38b_5fdb9a78","updated":"2020-01-09 20:42:39.000000000","message":"Done","commit_id":"b76da979425b161697cb00755d39cb04e1daa002"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"df5ea401b5369298c1f8934e924bdfa29fa623dd","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027create\u0027,"},{"line_number":59,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN,"},{"line_number":60,"context_line":"        description\u003d\"\"\"Create guest agent builds"},{"line_number":61,"context_line":"This is XenAPI driver specific."},{"line_number":62,"context_line":"It is used to force the upgrade of the XenAPI guest agent on instance boot."},{"line_number":63,"context_line":"\"\"\","},{"line_number":64,"context_line":"        operations\u003d["},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ffcfe6af","line":63,"range":{"start_line":61,"start_character":0,"end_line":63,"end_character":4},"updated":"2020-01-09 03:20:37.000000000","message":"ditto","commit_id":"b76da979425b161697cb00755d39cb04e1daa002"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"df5ea401b5369298c1f8934e924bdfa29fa623dd","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027update\u0027,"},{"line_number":77,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN,"},{"line_number":78,"context_line":"        description\u003d\"\"\"Update guest agent builds"},{"line_number":79,"context_line":"This is XenAPI driver specific."},{"line_number":80,"context_line":"It is used to force the upgrade of the XenAPI guest agent on instance boot."},{"line_number":81,"context_line":"\"\"\","},{"line_number":82,"context_line":"        operations\u003d["},{"line_number":83,"context_line":"            {"},{"line_number":84,"context_line":"                \u0027path\u0027: \u0027/os-agents/{agent_build_id}\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1fd3e260","line":81,"range":{"start_line":79,"start_character":0,"end_line":81,"end_character":4},"updated":"2020-01-09 03:20:37.000000000","message":"ditto","commit_id":"b76da979425b161697cb00755d39cb04e1daa002"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"df5ea401b5369298c1f8934e924bdfa29fa623dd","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027delete\u0027,"},{"line_number":94,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN,"},{"line_number":95,"context_line":"        description\u003d\"\"\"Delete guest agent builds"},{"line_number":96,"context_line":"This is XenAPI driver specific."},{"line_number":97,"context_line":"It is used to force the upgrade of the XenAPI guest agent on instance boot."},{"line_number":98,"context_line":"\"\"\","},{"line_number":99,"context_line":"        operations\u003d["},{"line_number":100,"context_line":"            {"},{"line_number":101,"context_line":"                \u0027path\u0027: \u0027/os-agents/{agent_build_id}\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_bfc5ee91","line":98,"range":{"start_line":96,"start_character":0,"end_line":98,"end_character":4},"updated":"2020-01-09 03:20:37.000000000","message":"ditto","commit_id":"b76da979425b161697cb00755d39cb04e1daa002"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8f79c7ca930f294cb4aa59788c40b8793ed29681","unresolved":false,"context_lines":[{"line_number":34,"context_line":"``nova.conf [oslo_policy] enforce_scope\u003dTrue`` which is False by default."},{"line_number":35,"context_line":"Old policies are marked as deprecated and silently going to be ignored"},{"line_number":36,"context_line":"in nova 23.0.0 (OpenStack W) release"},{"line_number":37,"context_line":"\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"agents_policies \u003d ["},{"line_number":40,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_83759835","line":37,"updated":"2020-02-07 17:35:38.000000000","message":"I see this defined a lot. Maybe we could put it in a \u0027common\u0027 module later?","commit_id":"3a00ac6b957c77a0e96679cb9e1730b85ed85c5f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"19d391fe1d8866ed5a30621da74566b043f0a3e7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"``nova.conf [oslo_policy] enforce_scope\u003dTrue`` which is False by default."},{"line_number":35,"context_line":"Old policies are marked as deprecated and silently going to be ignored"},{"line_number":36,"context_line":"in nova 23.0.0 (OpenStack W) release"},{"line_number":37,"context_line":"\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"agents_policies \u003d ["},{"line_number":40,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_aa9ae05c","line":37,"in_reply_to":"3fa7e38b_83759835","updated":"2020-02-08 16:13:08.000000000","message":"i need to shorten this as done in base patch.","commit_id":"3a00ac6b957c77a0e96679cb9e1730b85ed85c5f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8f79c7ca930f294cb4aa59788c40b8793ed29681","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027list\u0027,"},{"line_number":42,"context_line":"        check_str\u003dbase.SYSTEM_READER,"},{"line_number":43,"context_line":"        description\u003d\"\"\"List guest agent builds"},{"line_number":44,"context_line":"                    This is XenAPI driver specific."},{"line_number":45,"context_line":"                    It is used to force the upgrade of the XenAPI guest"},{"line_number":46,"context_line":"                    agent on instance boot."},{"line_number":47,"context_line":"                    \"\"\","},{"line_number":48,"context_line":"        operations\u003d["},{"line_number":49,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_43a0008f","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":43},"updated":"2020-02-07 17:35:38.000000000","message":"Does the oslo.policy docs correctly strip this leading whitespace? Also, this wrapping is really weird. Could we not keep doing it as before?\n\nLater: checked the build and it does. Phew. Don\u0027t like this wrapping though :)","commit_id":"3a00ac6b957c77a0e96679cb9e1730b85ed85c5f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"19d391fe1d8866ed5a30621da74566b043f0a3e7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027list\u0027,"},{"line_number":42,"context_line":"        check_str\u003dbase.SYSTEM_READER,"},{"line_number":43,"context_line":"        description\u003d\"\"\"List guest agent builds"},{"line_number":44,"context_line":"                    This is XenAPI driver specific."},{"line_number":45,"context_line":"                    It is used to force the upgrade of the XenAPI guest"},{"line_number":46,"context_line":"                    agent on instance boot."},{"line_number":47,"context_line":"                    \"\"\","},{"line_number":48,"context_line":"        operations\u003d["},{"line_number":49,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_4aa32c9d","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":43},"in_reply_to":"3fa7e38b_43a0008f","updated":"2020-02-08 16:13:08.000000000","message":"ok, let\u0027s keep as before and that is how it is in all other policies also","commit_id":"3a00ac6b957c77a0e96679cb9e1730b85ed85c5f"}],"nova/tests/unit/policies/test_agents.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ef70c22b7789e4d5eaaf4dd6f92da0447aed912f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        ]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"class AgentsDeprecatedPolicyTest(base.BasePolicyTest):"},{"line_number":164,"context_line":"    \"\"\"Test os-agents APIs Deprecated policies."},{"line_number":165,"context_line":"    This class checks if deprecated policy rules are"},{"line_number":166,"context_line":"    overridden by user on policy.json file then they"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_8174c869","line":163,"updated":"2020-03-02 10:39:49.000000000","message":"Nice, thanks.","commit_id":"ee7768d227d973fd19ef15754668e7273b5e0851"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7e208107d00c4f987395c7e2a5308930e044f4f4","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        # Overridde rule with different checks than defaults so that we can"},{"line_number":181,"context_line":"        # verify the rule overridden case."},{"line_number":182,"context_line":"        override_rules \u003d {self.deprecated_policy: base_policy.RULE_ADMIN_API}"},{"line_number":183,"context_line":"        # NOTE(gmann): Only override the deprecated rule in policy file so"},{"line_number":184,"context_line":"        # that"},{"line_number":185,"context_line":"        # we can verify if overridden checks are considered by oslo.policy."},{"line_number":186,"context_line":"        # Oslo.policy will consider the overridden rules if:"},{"line_number":187,"context_line":"        #  1. overridden deprecated rule\u0027s checks are different than defaults"},{"line_number":188,"context_line":"        #  2. new rules are not present in policy file"}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_df298e8a","line":185,"range":{"start_line":183,"start_character":0,"end_line":185,"end_character":75},"updated":"2020-03-30 11:52:23.000000000","message":"strange wrapping","commit_id":"116af3fde4695df1dd74041926963a765704bf7a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c8aee13decb54e76813e14e3b7d9e19d26e412d5","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        # Overridde rule with different checks than defaults so that we can"},{"line_number":181,"context_line":"        # verify the rule overridden case."},{"line_number":182,"context_line":"        override_rules \u003d {self.deprecated_policy: base_policy.RULE_ADMIN_API}"},{"line_number":183,"context_line":"        # NOTE(gmann): Only override the deprecated rule in policy file so"},{"line_number":184,"context_line":"        # that"},{"line_number":185,"context_line":"        # we can verify if overridden checks are considered by oslo.policy."},{"line_number":186,"context_line":"        # Oslo.policy will consider the overridden rules if:"},{"line_number":187,"context_line":"        #  1. overridden deprecated rule\u0027s checks are different than defaults"},{"line_number":188,"context_line":"        #  2. new rules are not present in policy file"}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_2e8165c4","line":185,"range":{"start_line":183,"start_character":0,"end_line":185,"end_character":75},"in_reply_to":"df33271e_df298e8a","updated":"2020-03-30 16:01:38.000000000","message":"Done","commit_id":"116af3fde4695df1dd74041926963a765704bf7a"}]}