)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dae5abbb16255d5f7143a856e333db94cd63efc8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"refresh the instance info cache, to be sure that what nova stores in"},{"line_number":14,"context_line":"its database is taken from neutron."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This will also help operators managing wrong info cache, by doing an"},{"line_number":17,"context_line":"http request against nova event API (admin only) in order to force"},{"line_number":18,"context_line":"triggering this info cache update."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I9bbcfc0dd008162499e65437a689574b80e5c18a"},{"line_number":21,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@corp.ovh.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_803188ef","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":34},"updated":"2020-05-14 20:09:47.000000000","message":"humm, I thought this API is being used by openstack services only.","commit_id":"b22152da36455a30b4109c3eb3169da592887081"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a821638fe5942f2b381808e4f895725f4c43f291","unresolved":false,"context_lines":[{"line_number":13,"context_line":"refresh the instance info cache, to be sure that what nova stores in"},{"line_number":14,"context_line":"its database is taken from neutron."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This will also help operators managing wrong info cache, by doing an"},{"line_number":17,"context_line":"http request against nova event API (admin only) in order to force"},{"line_number":18,"context_line":"triggering this info cache update."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I9bbcfc0dd008162499e65437a689574b80e5c18a"},{"line_number":21,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@corp.ovh.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_a4348e94","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":34},"in_reply_to":"ff570b3c_803188ef","updated":"2020-05-15 16:29:08.000000000","message":"it is and that was what i was concerned about\noperators should not be manualy sending events to this endpoint\n\nwhich is why if we were to support it i was wondering if we wanted to introduces something new such as a force refersh event for that. a network change event should not be harmful but vif plugged or unlpluged could have un intended consequences. network-vif-deleted will try to do a port detach for example.\n\ngiven we dont even really want to support you detaching a port via a neuton port delete in general i certenly dont want operators hitting the evnet api with a network-vif-deleted event manully. so the usecase is more of  a concern then the technical aspect. i still think we need a releasel note and some docs for this change.","commit_id":"b22152da36455a30b4109c3eb3169da592887081"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e77302496501881e2cce0ec81023d0d7258ff7da","unresolved":false,"context_lines":[{"line_number":13,"context_line":"refresh the instance info cache, to be sure that what nova stores in"},{"line_number":14,"context_line":"its database is taken from neutron."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This will also help operators managing wrong info cache, by doing an"},{"line_number":17,"context_line":"http request against nova event API (admin only) in order to force"},{"line_number":18,"context_line":"triggering this info cache update."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I9bbcfc0dd008162499e65437a689574b80e5c18a"},{"line_number":21,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@corp.ovh.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_926ce9ce","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":34},"in_reply_to":"ff570b3c_a4348e94","updated":"2020-05-19 20:25:05.000000000","message":"true, there is no way to make APIs internal or external but at least in api-ref we mention this API use case clearly. This use case is some back door entry to do the things which is much harmful in many cases. \n\n- https://docs.openstack.org/api-ref/compute/#create-external-events-os-server-external-events","commit_id":"b22152da36455a30b4109c3eb3169da592887081"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"5a54edb925d81c18f42af5765130ab4ba5382eb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fd75b787_c568ff1e","updated":"2023-06-28 13:51:24.000000000","message":"I am still running this patch downstream on a old nova release, but it seems it\u0027s not needed anymore based on sean comment.","commit_id":"b22152da36455a30b4109c3eb3169da592887081"}],"nova/compute/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dae5abbb16255d5f7143a856e333db94cd63efc8","unresolved":false,"context_lines":[{"line_number":10065,"context_line":"                              \u0027event %s.\u0027, event.key, instance\u003dinstance)"},{"line_number":10066,"context_line":"                    self.network_api.get_instance_nw_info("},{"line_number":10067,"context_line":"                        context, instance, refresh_vif_id\u003devent.tag,"},{"line_number":10068,"context_line":"                        force_refresh\u003dTrue)"},{"line_number":10069,"context_line":"                except exception.NotFound as e:"},{"line_number":10070,"context_line":"                    LOG.info(\u0027Failed to process external instance event \u0027"},{"line_number":10071,"context_line":"                             \u0027%(event)s due to: %(error)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_80186875","line":10068,"range":{"start_line":10068,"start_character":42,"end_line":10068,"end_character":43},"updated":"2020-05-14 20:09:47.000000000","message":"if event is not for specific port then it will refresh full cache otherwise not. I think this is right thing to do as this is network changed event so refreshing the cache with latest info from neutron is right thing.","commit_id":"b22152da36455a30b4109c3eb3169da592887081"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a821638fe5942f2b381808e4f895725f4c43f291","unresolved":false,"context_lines":[{"line_number":10065,"context_line":"                              \u0027event %s.\u0027, event.key, instance\u003dinstance)"},{"line_number":10066,"context_line":"                    self.network_api.get_instance_nw_info("},{"line_number":10067,"context_line":"                        context, instance, refresh_vif_id\u003devent.tag,"},{"line_number":10068,"context_line":"                        force_refresh\u003dTrue)"},{"line_number":10069,"context_line":"                except exception.NotFound as e:"},{"line_number":10070,"context_line":"                    LOG.info(\u0027Failed to process external instance event \u0027"},{"line_number":10071,"context_line":"                             \u0027%(event)s due to: %(error)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_a4c2ce57","line":10068,"range":{"start_line":10068,"start_character":42,"end_line":10068,"end_character":43},"in_reply_to":"ff570b3c_80186875","updated":"2020-05-15 16:29:08.000000000","message":"it will do a full refresh in etither case.\n\nwhat force_referesh\u003dTrue does is tell nova to ignore the ports it thinks are assocaited with the vm and get that list form neutorn and then update the cache with that info.\n\nthat we should not need to do on every network changed event.","commit_id":"b22152da36455a30b4109c3eb3169da592887081"}]}