)]}'
{"nova/api/openstack/compute/images.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5651b67ac6b4c3fa6cd4809df820c0aa0cbfe10f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from nova.api.openstack.compute.views import images as views_images"},{"line_number":22,"context_line":"from nova.api.openstack import wsgi"},{"line_number":23,"context_line":"from nova import exception"},{"line_number":24,"context_line":"from nova.i18n import _"},{"line_number":25,"context_line":"import nova.image"},{"line_number":26,"context_line":"import nova.utils"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_f56a7781","side":"PARENT","line":24,"range":{"start_line":24,"start_character":22,"end_line":24,"end_character":23},"updated":"2020-02-17 23:12:23.000000000","message":"unrealted observation but this is actully pretty bad pattern when you think about it.\n\nif people dont know we do this and to \n\nx , _ \u003d some_mulit_return_func()\n\nthen they will assign the result to the module replacing it globally.","commit_id":"0b1a33ec9ce903e2261dd5ae7b0db8e2968135dc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"09da216f7556ed3134bcbb71ddfbf008fe874938","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from nova.api.openstack.compute.views import images as views_images"},{"line_number":22,"context_line":"from nova.api.openstack import wsgi"},{"line_number":23,"context_line":"from nova import exception"},{"line_number":24,"context_line":"from nova.i18n import _"},{"line_number":25,"context_line":"import nova.image"},{"line_number":26,"context_line":"import nova.utils"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_76320311","side":"PARENT","line":24,"range":{"start_line":24,"start_character":22,"end_line":24,"end_character":23},"in_reply_to":"3fa7e38b_f56a7781","updated":"2020-02-18 15:24:29.000000000","message":"To be clear, it\u0027ll just replace it within the module, at runtime, so any subsequent use of the marker function will explode. I agree that\u0027s bad, but should get caught with fairly high probability before we ship it.\n\nIn fact, I\u0027m sure Sundar came to me with this exact issue at some point while he was developing the cyborg code, but I can\u0027t find that conversation. Anyway, point is, he found it during dev.","commit_id":"0b1a33ec9ce903e2261dd5ae7b0db8e2968135dc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"76aac4ff1a80dd362fb91fbbb10185ce3a20ff29","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from nova import exception"},{"line_number":24,"context_line":"from nova.i18n import _"},{"line_number":25,"context_line":"import nova.image"},{"line_number":26,"context_line":"import nova.utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"SUPPORTED_FILTERS \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_baa2ae3f","side":"PARENT","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":17},"updated":"2020-02-17 22:48:49.000000000","message":"How was this not causing problems before?","commit_id":"0b1a33ec9ce903e2261dd5ae7b0db8e2968135dc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"09da216f7556ed3134bcbb71ddfbf008fe874938","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from nova import exception"},{"line_number":24,"context_line":"from nova.i18n import _"},{"line_number":25,"context_line":"import nova.image"},{"line_number":26,"context_line":"import nova.utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"SUPPORTED_FILTERS \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_d172e1af","side":"PARENT","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":17},"in_reply_to":"3fa7e38b_3506cfce","updated":"2020-02-18 15:24:29.000000000","message":"I wasn\u0027t asking about the import order (which appears to be correct) -- I was asking about the fact that this import appears to be unused, which is something pep8 usually flags.","commit_id":"0b1a33ec9ce903e2261dd5ae7b0db8e2968135dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5651b67ac6b4c3fa6cd4809df820c0aa0cbfe10f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from nova import exception"},{"line_number":24,"context_line":"from nova.i18n import _"},{"line_number":25,"context_line":"import nova.image"},{"line_number":26,"context_line":"import nova.utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"SUPPORTED_FILTERS \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_3506cfce","side":"PARENT","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":17},"in_reply_to":"3fa7e38b_baa2ae3f","updated":"2020-02-17 23:12:23.000000000","message":"the import order check basically removes all the keywords and \u0027.\u0027 charaters and compares what is left so this just happend to be be in the right place to not break the check.\n\nat least that is what stephen told me before when i found other weird cases i did not bother looking at the code since it seam correct.","commit_id":"0b1a33ec9ce903e2261dd5ae7b0db8e2968135dc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aca33ecd56d9ae36707d3525195faee40980c5ef","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from nova import exception"},{"line_number":24,"context_line":"from nova.i18n import _"},{"line_number":25,"context_line":"import nova.image"},{"line_number":26,"context_line":"import nova.utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"SUPPORTED_FILTERS \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_f1e7dd0f","side":"PARENT","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":17},"in_reply_to":"3fa7e38b_d172e1af","updated":"2020-02-18 15:32:40.000000000","message":"Yeah, not a clue why that was allowed, tbh","commit_id":"0b1a33ec9ce903e2261dd5ae7b0db8e2968135dc"}],"nova/image/glance.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"76aac4ff1a80dd362fb91fbbb10185ce3a20ff29","unresolved":false,"context_lines":[{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"@profiler.trace_cls(\"nova_image\")"},{"line_number":1023,"context_line":"class API(object):"},{"line_number":1024,"context_line":"    \"\"\"API for interacting with the image service.\"\"\""},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"    def _get_session_and_image_id(self, context, id_or_uri):"},{"line_number":1027,"context_line":"        \"\"\"Returns a tuple of (session, image_id). If the supplied `id_or_uri`"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_1a19828a","line":1024,"range":{"start_line":1024,"start_character":4,"end_line":1024,"end_character":53},"updated":"2020-02-17 22:48:49.000000000","message":"Original docstring:\n\n    \"\"\"Responsible for exposing a relatively stable internal API for other\n    modules in Nova to retrieve information about disk images. This API\n    attempts to match the nova.volume.api and nova.network.api calling\n    interface.\n    \"\"\"","commit_id":"92101bd55a30e9a276e19ff02bb2534549bdeada"}]}