)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"484127c020caf7f380a1ce7c018bf20c2b09c55c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new virtio-scsi cotroller will be presented to the guests,"},{"line_number":10,"context_line":"when hw_disk_bus will be set to virtio-scsi for image"},{"line_number":11,"context_line":"or provided via block device mapping disk_bus option for volumes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially implements blueprint libvirt-virtio-scsi-driver"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F92kM%3D","line":11,"updated":"2014-02-03 09:57:49.000000000","message":"This is not the right approach for properties. The existing hw_disk_bus\u0027 property represents the generic class of disk bus. ie ide/scsi/virtio.  What we have here is a need to choose between specification implementations of the scsi bus. This should be done via a separate property - hw_disk_bus_model.","commit_id":"e837edd2d73938b7c6862347f4cf05f8d432cfa1"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"484127c020caf7f380a1ce7c018bf20c2b09c55c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"or provided via block device mapping disk_bus option for volumes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially implements blueprint libvirt-virtio-scsi-driver"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2723494130055687a9dfc58b1a27e586116fdff3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F92lE%3D","line":14,"updated":"2014-02-03 09:57:49.000000000","message":"Needs \u0027DocImpact\u0027 too","commit_id":"e837edd2d73938b7c6862347f4cf05f8d432cfa1"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b16dc6e3f81871c635d511c630d8c5d28dcdf082","unresolved":false,"context_lines":[{"line_number":15,"context_line":"       [image]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements blueprint libvirt-virtio-scsi-driver"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2723494130055687a9dfc58b1a27e586116fdff3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F9qL4%3D","line":18,"updated":"2014-02-05 09:28:06.000000000","message":"Can you add DocImpact","commit_id":"a73ddce8f74ab935829562bd672dc5cc1eb442dc"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"556f9b657b609ea6e1d9c07cd19ded0c5ffb88e2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"       [image]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements blueprint libvirt-virtio-scsi-driver"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2723494130055687a9dfc58b1a27e586116fdff3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F9ojE%3D","line":18,"in_reply_to":"AAAAUH%2F9qL4%3D","updated":"2014-02-05 14:06:48.000000000","message":"Done","commit_id":"a73ddce8f74ab935829562bd672dc5cc1eb442dc"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"e5213f4763224f364e6ba1ca2e2c2e96d53dcb04","unresolved":false,"context_lines":[{"line_number":14,"context_line":"       --property hw_disk_bus_model\u003dvirtio-scsi \\"},{"line_number":15,"context_line":"       [image]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"Partially implements blueprint libvirt-virtio-scsi-driver"},{"line_number":19,"context_line":"Change-Id: I2723494130055687a9dfc58b1a27e586116fdff3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F9ohE%3D","line":17,"updated":"2014-02-05 14:10:08.000000000","message":"It is better add some detail for DocImpact.","commit_id":"3d1c71f6f9474d8663aac1fca120794b4528226c"},{"author":{"_account_id":7808,"name":"Xavier Queralt","email":"xqueralt@gmail.com","username":"xqueralt"},"change_message_id":"f59aa9df43b56952701e3ed6c06b096cb9c63584","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"glance image-update \\"},{"line_number":14,"context_line":"       --property hw_scsi_model\u003dvirtio-scsi \\"},{"line_number":15,"context_line":"       [image]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"Partially implements blueprint libvirt-virtio-scsi-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUX%2F%2F1a4%3D","line":15,"updated":"2014-02-10 14:45:18.000000000","message":"It might be worth mentioning that the property hw_disk_bus\u003dscsi needs to be set too in order to configure the disk to use the scsi bus, otherwise it will be using the default virtio-blk bus.","commit_id":"86cd7d225e450da2bde737fffda645622ee6368f"}],"nova/tests/virt/libvirt/test_libvirt.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"e5213f4763224f364e6ba1ca2e2c2e96d53dcb04","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                                    [], bd_info)"},{"line_number":1051,"context_line":"        self.assertEqual(type(cfg.devices[2]),"},{"line_number":1052,"context_line":"                         vconfig.LibvirtConfigGuestDisk)"},{"line_number":1053,"context_line":"        self.assertEqual(cfg.devices[2].target_dev, \u0027sdc\u0027)"},{"line_number":1054,"context_line":"        self.assertEqual(cfg.devices[2].target_bus, \u0027scsi\u0027)"},{"line_number":1055,"context_line":"        self.assertEqual(type(cfg.devices[3]),"},{"line_number":1056,"context_line":"                         vconfig.LibvirtConfigGuestDisk)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9ohw%3D","line":1053,"updated":"2014-02-05 14:10:08.000000000","message":"assertEqual(expected, observed).","commit_id":"3d1c71f6f9474d8663aac1fca120794b4528226c"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"751c5f3eca5f17903a184d66c9f455c82415a8a7","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                                    [], bd_info)"},{"line_number":1051,"context_line":"        self.assertEqual(type(cfg.devices[2]),"},{"line_number":1052,"context_line":"                         vconfig.LibvirtConfigGuestDisk)"},{"line_number":1053,"context_line":"        self.assertEqual(cfg.devices[2].target_dev, \u0027sdc\u0027)"},{"line_number":1054,"context_line":"        self.assertEqual(cfg.devices[2].target_bus, \u0027scsi\u0027)"},{"line_number":1055,"context_line":"        self.assertEqual(type(cfg.devices[3]),"},{"line_number":1056,"context_line":"                         vconfig.LibvirtConfigGuestDisk)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9au4%3D","line":1053,"in_reply_to":"AAAAUH%2F9oLo%3D","updated":"2014-02-07 02:04:25.000000000","message":"OK","commit_id":"3d1c71f6f9474d8663aac1fca120794b4528226c"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b3383f802655876a3c8234264f7d3e65cf2bb1bf","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                                    [], bd_info)"},{"line_number":1051,"context_line":"        self.assertEqual(type(cfg.devices[2]),"},{"line_number":1052,"context_line":"                         vconfig.LibvirtConfigGuestDisk)"},{"line_number":1053,"context_line":"        self.assertEqual(cfg.devices[2].target_dev, \u0027sdc\u0027)"},{"line_number":1054,"context_line":"        self.assertEqual(cfg.devices[2].target_bus, \u0027scsi\u0027)"},{"line_number":1055,"context_line":"        self.assertEqual(type(cfg.devices[3]),"},{"line_number":1056,"context_line":"                         vconfig.LibvirtConfigGuestDisk)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9oLo%3D","line":1053,"in_reply_to":"AAAAUH%2F9oP0%3D","updated":"2014-02-05 15:01:12.000000000","message":"Agreed, consistency is better here - cleanup belongs in a separate patch.","commit_id":"3d1c71f6f9474d8663aac1fca120794b4528226c"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"dff9a5501c54143396c353230444ffebcdfd8a77","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                                    [], bd_info)"},{"line_number":1051,"context_line":"        self.assertEqual(type(cfg.devices[2]),"},{"line_number":1052,"context_line":"                         vconfig.LibvirtConfigGuestDisk)"},{"line_number":1053,"context_line":"        self.assertEqual(cfg.devices[2].target_dev, \u0027sdc\u0027)"},{"line_number":1054,"context_line":"        self.assertEqual(cfg.devices[2].target_bus, \u0027scsi\u0027)"},{"line_number":1055,"context_line":"        self.assertEqual(type(cfg.devices[3]),"},{"line_number":1056,"context_line":"                         vconfig.LibvirtConfigGuestDisk)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9oP0%3D","line":1053,"in_reply_to":"AAAAUH%2F9ohw%3D","updated":"2014-02-05 14:59:24.000000000","message":"All assertEqual calls in this file have it\u0027s arguments in a from of (expected, observed),\nI doubt that having this one different, will help anyone understand the code better.\n\nI think changing assertEqual to the form (expected, observed), should be done in a different patch and probably include a rule in nova/hacking/checks.py","commit_id":"3d1c71f6f9474d8663aac1fca120794b4528226c"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b16dc6e3f81871c635d511c630d8c5d28dcdf082","unresolved":false,"context_lines":[{"line_number":2983,"context_line":"                image_meta.get(\u0027properties\u0027, {}).get(\u0027hw_disk_bus_model\u0027)):"},{"line_number":2984,"context_line":"            scsi_controller \u003d vconfig.LibvirtConfigGuestController()"},{"line_number":2985,"context_line":"            scsi_controller.type \u003d \u0027scsi\u0027"},{"line_number":2986,"context_line":"            scsi_controller.model \u003d \u0027virtio-scsi\u0027"},{"line_number":2987,"context_line":"            devices.append(scsi_controller)"},{"line_number":2988,"context_line":""},{"line_number":2989,"context_line":"        return devices"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9qMI%3D","line":2986,"updated":"2014-02-05 09:28:06.000000000","message":"s/scsi_controller/disk_controller/ throughout\n\nand use   disk_controller.model \u003d image_meta.get(\u0027properties\u0027, {}).get(\u0027hw_disk_bus_model\u0027)","commit_id":"a73ddce8f74ab935829562bd672dc5cc1eb442dc"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"556f9b657b609ea6e1d9c07cd19ded0c5ffb88e2","unresolved":false,"context_lines":[{"line_number":2983,"context_line":"                image_meta.get(\u0027properties\u0027, {}).get(\u0027hw_disk_bus_model\u0027)):"},{"line_number":2984,"context_line":"            scsi_controller \u003d vconfig.LibvirtConfigGuestController()"},{"line_number":2985,"context_line":"            scsi_controller.type \u003d \u0027scsi\u0027"},{"line_number":2986,"context_line":"            scsi_controller.model \u003d \u0027virtio-scsi\u0027"},{"line_number":2987,"context_line":"            devices.append(scsi_controller)"},{"line_number":2988,"context_line":""},{"line_number":2989,"context_line":"        return devices"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9oi8%3D","line":2986,"in_reply_to":"AAAAUH%2F9qMI%3D","updated":"2014-02-05 14:06:48.000000000","message":"Done","commit_id":"a73ddce8f74ab935829562bd672dc5cc1eb442dc"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"c15f834eff5c3bd9c82b14157792b8cf2a1dd115","unresolved":false,"context_lines":[{"line_number":2985,"context_line":"            disk_controller \u003d vconfig.LibvirtConfigGuestController()"},{"line_number":2986,"context_line":"            disk_controller.type \u003d \u0027scsi\u0027"},{"line_number":2987,"context_line":"            disk_controller.model \u003d disk_bus_model"},{"line_number":2988,"context_line":"            devices.append(disk_controller)"},{"line_number":2989,"context_line":""},{"line_number":2990,"context_line":"        return devices"},{"line_number":2991,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9fR4%3D","line":2988,"updated":"2014-02-06 15:30:02.000000000","message":"I think I was actually wrong in my previous comments on this.\n\nI forgot that we have  \u0027hw_disk_bus\u0027,  \u0027hw_cdrom_bus\u0027 and \u0027hw_floppy_bus\u0027 all of which can refer to \u0027scsi\u0027. We don\u0027t want the controller to be separate for each of those. What we want is a single SCSI controller whether used for  disk/cdrom/floppy.\n\nSo I\u0027d suggest we change the property name to \u0027hw_scsi_model\u0027 and the variable put back to \u0027scsi_controller\u0027","commit_id":"3d1c71f6f9474d8663aac1fca120794b4528226c"}]}