)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2565f220c132936fa7d63f2bf9bd0cf31d2e4044","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Modifications:"},{"line_number":29,"context_line":"\tnova/tests/functional/libvirt/test_numa_servers.py"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"NOTE(stephenfin): The new tests added in \u0027test_numa_servers.py\u0027 had to"},{"line_number":32,"context_line":"be modified to use the old-style \u0027_wait_for_state_change\u0027 function,"},{"line_number":33,"context_line":"since change I80cdc0a33ec27b1389130c22f9c3a8ff69f6b1a0 isn\u0027t present on"},{"line_number":34,"context_line":"\u0027stable/train\u0027 and it\u0027s too large and invasive to justify backporting."},{"line_number":35,"context_line":"In addition, a \u0027super()\u0027 call had to be updated to use the Python 2"},{"line_number":36,"context_line":"compatible \u0027super(ClassName, self)\u0027 style."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NOTE(sean-k-mooney): due to the lack of"},{"line_number":39,"context_line":"Icacda8484c9ede1a0ddf0831bc457b83b1dd6931 the Fake HostInfo objects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_1b8a9a1d","line":36,"range":{"start_line":31,"start_character":0,"end_line":36,"end_character":42},"updated":"2020-01-17 10:23:25.000000000","message":"I think this bit could be dropped since it\u0027s not relevant to this particular backport. We only need to care about the changes compared to the patch this was backported from (the stable/train version)","commit_id":"061e25015a93c345e39b7b340ad166c378d072ee"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cf9597c626de226b28c0b9a69888b33355ffe259","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Modifications:"},{"line_number":29,"context_line":"\tnova/tests/functional/libvirt/test_numa_servers.py"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"NOTE(stephenfin): The new tests added in \u0027test_numa_servers.py\u0027 had to"},{"line_number":32,"context_line":"be modified to use the old-style \u0027_wait_for_state_change\u0027 function,"},{"line_number":33,"context_line":"since change I80cdc0a33ec27b1389130c22f9c3a8ff69f6b1a0 isn\u0027t present on"},{"line_number":34,"context_line":"\u0027stable/train\u0027 and it\u0027s too large and invasive to justify backporting."},{"line_number":35,"context_line":"In addition, a \u0027super()\u0027 call had to be updated to use the Python 2"},{"line_number":36,"context_line":"compatible \u0027super(ClassName, self)\u0027 style."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NOTE(sean-k-mooney): due to the lack of"},{"line_number":39,"context_line":"Icacda8484c9ede1a0ddf0831bc457b83b1dd6931 the Fake HostInfo objects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_d4860f60","line":36,"range":{"start_line":31,"start_character":0,"end_line":36,"end_character":42},"in_reply_to":"3fa7e38b_1b8a9a1d","updated":"2020-01-17 14:16:56.000000000","message":"ya i could drop this.\nill remove it if other think its worth it and ill drop it in the backport to older branches in any case.\nim planning to bring these back to queens upstream since i need to do it downstream anyway.","commit_id":"061e25015a93c345e39b7b340ad166c378d072ee"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f4838b7e5016e462c40a99af60bf31dd96c79b49","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Modifications:"},{"line_number":29,"context_line":"\tnova/tests/functional/libvirt/test_numa_servers.py"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"NOTE(stephenfin): The new tests added in \u0027test_numa_servers.py\u0027 had to"},{"line_number":32,"context_line":"be modified to use the old-style \u0027_wait_for_state_change\u0027 function,"},{"line_number":33,"context_line":"since change I80cdc0a33ec27b1389130c22f9c3a8ff69f6b1a0 isn\u0027t present on"},{"line_number":34,"context_line":"\u0027stable/train\u0027 and it\u0027s too large and invasive to justify backporting."},{"line_number":35,"context_line":"In addition, a \u0027super()\u0027 call had to be updated to use the Python 2"},{"line_number":36,"context_line":"compatible \u0027super(ClassName, self)\u0027 style."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NOTE(sean-k-mooney): due to the lack of"},{"line_number":39,"context_line":"Icacda8484c9ede1a0ddf0831bc457b83b1dd6931 the Fake HostInfo objects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_cb7dfbe6","line":36,"range":{"start_line":31,"start_character":0,"end_line":36,"end_character":42},"in_reply_to":"3fa7e38b_d4860f60","updated":"2020-01-20 13:25:07.000000000","message":"Yup we can drop this.","commit_id":"061e25015a93c345e39b7b340ad166c378d072ee"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f4838b7e5016e462c40a99af60bf31dd96c79b49","unresolved":false,"context_lines":[{"line_number":36,"context_line":"compatible \u0027super(ClassName, self)\u0027 style."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NOTE(sean-k-mooney): due to the lack of"},{"line_number":39,"context_line":"Icacda8484c9ede1a0ddf0831bc457b83b1dd6931 the Fake HostInfo objects"},{"line_number":40,"context_line":"created in the functional tests where updated to use the NUMAHostInfo"},{"line_number":41,"context_line":"class."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_6b6c0733","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":41},"updated":"2020-01-20 13:25:07.000000000","message":"This has been present since stable/pike so I don\u0027t understand why we\u0027ve changed to fakelibvirt.NUMAHostInfo here on stable/stein?\n\nhttps://github.com/openstack/nova/blob/2fceddc451bd021f137c6756c5314e08eb4443de/nova/tests/unit/virt/libvirt/fakelibvirt.py#L465-L503","commit_id":"061e25015a93c345e39b7b340ad166c378d072ee"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0740d9bdbb65606696f971338c99ccb7659d794a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"compatible \u0027super(ClassName, self)\u0027 style."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NOTE(sean-k-mooney): due to the lack of"},{"line_number":39,"context_line":"Icacda8484c9ede1a0ddf0831bc457b83b1dd6931 the Fake HostInfo objects"},{"line_number":40,"context_line":"created in the functional tests where updated to use the NUMAHostInfo"},{"line_number":41,"context_line":"class."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_4b290b9a","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":41},"in_reply_to":"3fa7e38b_6b6c0733","updated":"2020-01-20 13:39:18.000000000","message":"Looks like we actually wanted to list Id3e0668acb71b3c7350b73b4afff7e940c6dfb1d here.","commit_id":"061e25015a93c345e39b7b340ad166c378d072ee"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b3df73bdc7f7fc5aadfd6a190218c3da9b09f081","unresolved":false,"context_lines":[{"line_number":36,"context_line":"compatible \u0027super(ClassName, self)\u0027 style."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NOTE(sean-k-mooney): due to the lack of"},{"line_number":39,"context_line":"Icacda8484c9ede1a0ddf0831bc457b83b1dd6931 the Fake HostInfo objects"},{"line_number":40,"context_line":"created in the functional tests where updated to use the NUMAHostInfo"},{"line_number":41,"context_line":"class."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_f1b224e8","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":41},"in_reply_to":"3fa7e38b_6b6c0733","updated":"2020-01-20 14:46:49.000000000","message":"yep you are right. in master NUMAHostInfo has been remvoed and the functionality merged into HostInfo. so we need to use NUMAHostInfo on stable branches however i added the change id for the commit that added NUMAHostInfo not the change id for the commit that merged it back into HostInfo so ill fix that.\ngood spot","commit_id":"061e25015a93c345e39b7b340ad166c378d072ee"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8848d3446ba401e03e09f165d5591fad113aa19c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"compatible \u0027super(ClassName, self)\u0027 style."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NOTE(sean-k-mooney): due to the lack of"},{"line_number":39,"context_line":"Icacda8484c9ede1a0ddf0831bc457b83b1dd6931 the Fake HostInfo objects"},{"line_number":40,"context_line":"created in the functional tests where updated to use the NUMAHostInfo"},{"line_number":41,"context_line":"class."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_7c392b3e","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":41},"in_reply_to":"3fa7e38b_f1b224e8","updated":"2020-01-20 15:37:55.000000000","message":"actully no that is not the change id i want\n\nthis is the change id i wanted \nIfcda7336d56c9b623720ee018ec5697740986273\n\nhttps://github.com/openstack/nova/commit/c619c3b5847de85b21ffcbf750c10421d8b7d193#diff-ede661771530c1367d24c1c0099d754c\n\nthat is not present before stable/train","commit_id":"061e25015a93c345e39b7b340ad166c378d072ee"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"616791feb00195eaf0baa61b2df54430baade529","unresolved":false,"context_lines":[{"line_number":25,"context_line":"rebuilding NUMA instances with new images. This change also asserts that"},{"line_number":26,"context_line":"in place rebuilds of numa instances is currently not supported."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Modifications:"},{"line_number":29,"context_line":"\tnova/tests/functional/libvirt/test_numa_servers.py"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"NOTE(sean-k-mooney): due to the lack of"},{"line_number":32,"context_line":"Ifcda7336d56c9b623720ee018ec5697740986273 the Fake HostInfo objects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_1ed33a61","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":51},"updated":"2020-01-21 15:48:00.000000000","message":"Please replace this with:\n\nConflicts:\n    nova/api/openstack/compute/servers.py\n    nova/tests/functional/libvirt/test_numa_servers.py\n\nto have both conflicting file here. servers.py conflict is due to not having patch I5576fa2a67d2771614266022428b4a95487ab6d5 in Stein.","commit_id":"67ee8e3861aa9c618130cbe2a15e39b2bfcbc4cc"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"616791feb00195eaf0baa61b2df54430baade529","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"NOTE(sean-k-mooney): due to the lack of"},{"line_number":32,"context_line":"Ifcda7336d56c9b623720ee018ec5697740986273 the Fake HostInfo objects"},{"line_number":33,"context_line":"created in the functional tests where updated to use the NUMAHostInfo"},{"line_number":34,"context_line":"class. Prior to Ifcda7336d56c9b623720ee018ec5697740986273 the"},{"line_number":35,"context_line":"Fake HostInfo class did not construct a numa toplogy from the kwargs"},{"line_number":36,"context_line":"and instead only set a numa topology if if it was passed in during"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_9ec88a75","line":33,"range":{"start_line":33,"start_character":32,"end_line":33,"end_character":37},"updated":"2020-01-21 15:48:00.000000000","message":"nit: were","commit_id":"67ee8e3861aa9c618130cbe2a15e39b2bfcbc4cc"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"616791feb00195eaf0baa61b2df54430baade529","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Ifcda7336d56c9b623720ee018ec5697740986273 the Fake HostInfo objects"},{"line_number":33,"context_line":"created in the functional tests where updated to use the NUMAHostInfo"},{"line_number":34,"context_line":"class. Prior to Ifcda7336d56c9b623720ee018ec5697740986273 the"},{"line_number":35,"context_line":"Fake HostInfo class did not construct a numa toplogy from the kwargs"},{"line_number":36,"context_line":"and instead only set a numa topology if if it was passed in during"},{"line_number":37,"context_line":"construction. In older release the initalistation of the numa"},{"line_number":38,"context_line":"topology form kwargs was a feature of NUMAHostInfo."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_3e65d6b0","line":35,"range":{"start_line":35,"start_character":45,"end_line":35,"end_character":52},"updated":"2020-01-21 15:48:00.000000000","message":"nit: topology","commit_id":"67ee8e3861aa9c618130cbe2a15e39b2bfcbc4cc"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"616791feb00195eaf0baa61b2df54430baade529","unresolved":false,"context_lines":[{"line_number":33,"context_line":"created in the functional tests where updated to use the NUMAHostInfo"},{"line_number":34,"context_line":"class. Prior to Ifcda7336d56c9b623720ee018ec5697740986273 the"},{"line_number":35,"context_line":"Fake HostInfo class did not construct a numa toplogy from the kwargs"},{"line_number":36,"context_line":"and instead only set a numa topology if if it was passed in during"},{"line_number":37,"context_line":"construction. In older release the initalistation of the numa"},{"line_number":38,"context_line":"topology form kwargs was a feature of NUMAHostInfo."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_7ef4aed0","line":36,"range":{"start_line":36,"start_character":37,"end_line":36,"end_character":42},"updated":"2020-01-21 15:48:00.000000000","message":"nit: remove redundant if","commit_id":"67ee8e3861aa9c618130cbe2a15e39b2bfcbc4cc"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"616791feb00195eaf0baa61b2df54430baade529","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class. Prior to Ifcda7336d56c9b623720ee018ec5697740986273 the"},{"line_number":35,"context_line":"Fake HostInfo class did not construct a numa toplogy from the kwargs"},{"line_number":36,"context_line":"and instead only set a numa topology if if it was passed in during"},{"line_number":37,"context_line":"construction. In older release the initalistation of the numa"},{"line_number":38,"context_line":"topology form kwargs was a feature of NUMAHostInfo."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Closes-Bug: #1763766"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_7e1d8e0e","line":37,"range":{"start_line":37,"start_character":35,"end_line":37,"end_character":49},"updated":"2020-01-21 15:48:00.000000000","message":"nit: initialization","commit_id":"67ee8e3861aa9c618130cbe2a15e39b2bfcbc4cc"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"616791feb00195eaf0baa61b2df54430baade529","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Fake HostInfo class did not construct a numa toplogy from the kwargs"},{"line_number":36,"context_line":"and instead only set a numa topology if if it was passed in during"},{"line_number":37,"context_line":"construction. In older release the initalistation of the numa"},{"line_number":38,"context_line":"topology form kwargs was a feature of NUMAHostInfo."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Closes-Bug: #1763766"},{"line_number":41,"context_line":"Partial-implements: blueprint inplace-rebuild-of-numa-instances"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_5e10d2f4","line":38,"range":{"start_line":38,"start_character":9,"end_line":38,"end_character":13},"updated":"2020-01-21 15:48:00.000000000","message":"nit: from","commit_id":"67ee8e3861aa9c618130cbe2a15e39b2bfcbc4cc"}],"nova/exception.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"616791feb00195eaf0baa61b2df54430baade529","unresolved":false,"context_lines":[{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"class ImageNUMATopologyRebuildConflict(Invalid):"},{"line_number":1940,"context_line":"    msg_fmt \u003d _("},{"line_number":1941,"context_line":"        \"An instance\u0027s NUMA typology cannot be changed as part of a rebuild. \""},{"line_number":1942,"context_line":"        \"The image provided is invalid for this instance.\")"},{"line_number":1943,"context_line":""},{"line_number":1944,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7b684021","line":1941,"range":{"start_line":1941,"start_character":28,"end_line":1941,"end_character":36},"updated":"2020-01-21 15:48:00.000000000","message":"Matt noticed this and complained in the Train version of this patch. Maybe (as an exception) the typo (topology) should be fixed here, in this patch...","commit_id":"67ee8e3861aa9c618130cbe2a15e39b2bfcbc4cc"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"5400e70c6b960b957c7b059d0e3786f3994572b5","unresolved":false,"context_lines":[{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"class ImageNUMATopologyRebuildConflict(Invalid):"},{"line_number":1940,"context_line":"    msg_fmt \u003d _("},{"line_number":1941,"context_line":"        \"An instance\u0027s NUMA typology cannot be changed as part of a rebuild. \""},{"line_number":1942,"context_line":"        \"The image provided is invalid for this instance.\")"},{"line_number":1943,"context_line":""},{"line_number":1944,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_8326e3cb","line":1941,"range":{"start_line":1941,"start_character":28,"end_line":1941,"end_character":36},"in_reply_to":"3fa7e38b_70960bf2","updated":"2020-01-22 11:58:44.000000000","message":"I\u0027m okay with that, thanks!","commit_id":"67ee8e3861aa9c618130cbe2a15e39b2bfcbc4cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0a9aa63732c9e60d3cca3dffdcb76a5432f9f7e3","unresolved":false,"context_lines":[{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"class ImageNUMATopologyRebuildConflict(Invalid):"},{"line_number":1940,"context_line":"    msg_fmt \u003d _("},{"line_number":1941,"context_line":"        \"An instance\u0027s NUMA typology cannot be changed as part of a rebuild. \""},{"line_number":1942,"context_line":"        \"The image provided is invalid for this instance.\")"},{"line_number":1943,"context_line":""},{"line_number":1944,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_70960bf2","line":1941,"range":{"start_line":1941,"start_character":28,"end_line":1941,"end_character":36},"in_reply_to":"3fa7e38b_7b684021","updated":"2020-01-22 10:57:53.000000000","message":"We\u0027ve a follow-up to tackle this so I think we should keep these as clean as possible and backport that instead of changing this here","commit_id":"67ee8e3861aa9c618130cbe2a15e39b2bfcbc4cc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"40ff5a17917de852292582b75f76f8b6a3635ccd","unresolved":false,"context_lines":[{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"class ImageNUMATopologyRebuildConflict(Invalid):"},{"line_number":1940,"context_line":"    msg_fmt \u003d _("},{"line_number":1941,"context_line":"        \"An instance\u0027s NUMA typology cannot be changed as part of a rebuild. \""},{"line_number":1942,"context_line":"        \"The image provided is invalid for this instance.\")"},{"line_number":1943,"context_line":""},{"line_number":1944,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_bc20dcb2","line":1941,"range":{"start_line":1941,"start_character":28,"end_line":1941,"end_character":36},"in_reply_to":"3fa7e38b_8326e3cb","updated":"2020-01-22 15:05:11.000000000","message":"yes this is addressed in https://review.opendev.org/#/c/702974/2/nova/exception.py","commit_id":"67ee8e3861aa9c618130cbe2a15e39b2bfcbc4cc"}]}