)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"1a99b17916100a44fdf4c2edbf740fa2d9d1b90c","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Conflicts:"},{"line_number":29,"context_line":"    nova/api/openstack/compute/servers.py"},{"line_number":30,"context_line":"    nova/tests/functional/integrated_helpers.py"},{"line_number":31,"context_line":"    nova/tests/functional/libvirt/test_numa_servers.py"},{"line_number":32,"context_line":"    nova/tests/unit/compute/test_compute_api.py"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_aa10a9a9","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":47},"updated":"2020-08-05 17:12:39.000000000","message":"this is due to patch If76fc076e964c9492727dabdc1f5d7e9c295c7fe is not present in Rocky.","commit_id":"643405b3a751f7547417e48e00db05d9fe8e99c4"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"1a99b17916100a44fdf4c2edbf740fa2d9d1b90c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    nova/api/openstack/compute/servers.py"},{"line_number":30,"context_line":"    nova/tests/functional/integrated_helpers.py"},{"line_number":31,"context_line":"    nova/tests/functional/libvirt/test_numa_servers.py"},{"line_number":32,"context_line":"    nova/tests/unit/compute/test_compute_api.py"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Modified:"},{"line_number":35,"context_line":"    nova/tests/unit/api/openstack/compute/test_server_actions.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_4ac3cd38","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":47},"updated":"2020-08-05 17:12:39.000000000","message":"this is due to patch I25454cd408e08589e5cfd6107dcbadd15bbb405f is not present in Rocky.","commit_id":"643405b3a751f7547417e48e00db05d9fe8e99c4"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"1a99b17916100a44fdf4c2edbf740fa2d9d1b90c","unresolved":false,"context_lines":[{"line_number":984,"context_line":"        # stable/rocky we explicitly catch the NUMA rebuild conflict instead of"},{"line_number":985,"context_line":"        # extending the INVALID_FLAVOR_IMAGE_EXCEPTIONS tuple which was"},{"line_number":986,"context_line":"        # introduced in the stein release."},{"line_number":987,"context_line":"        except exception.ImageNUMATopologyRebuildConflict as error:"},{"line_number":988,"context_line":"            raise exc.HTTPBadRequest(explanation\u003derror.format_message())"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"        instance \u003d self._get_server(context, req, id, is_detail\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_6a8a116a","line":987,"range":{"start_line":987,"start_character":25,"end_line":987,"end_character":57},"updated":"2020-08-05 17:12:39.000000000","message":"I guess this is \u0027rebuild\u0027 specific exception as its name suggests and we don\u0027t need this exception to expect to come at \u0027create\u0027 and \u0027resize\u0027, where the original patch also places INVALID_FLAVOR_IMAGE_EXCEPTIONS.","commit_id":"643405b3a751f7547417e48e00db05d9fe8e99c4"}],"nova/compute/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"be690a47a412972eccf8a596757ca42128156b60","unresolved":false,"context_lines":[{"line_number":3358,"context_line":"        # change in the future. we pull out the image metadata into"},{"line_number":3359,"context_line":"        # separate variable to make future testing of this easier."},{"line_number":3360,"context_line":"        old_image_meta \u003d instance.image_meta"},{"line_number":3361,"context_line":"        new_image_meta \u003d objects.ImageMeta.from_dict(image)"},{"line_number":3362,"context_line":"        old_constraints \u003d hardware.numa_get_constraints(flavor, old_image_meta)"},{"line_number":3363,"context_line":"        new_constraints \u003d hardware.numa_get_constraints(flavor, new_image_meta)"},{"line_number":3364,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_82083d25","line":3361,"range":{"start_line":3361,"start_character":5,"end_line":3361,"end_character":59},"updated":"2020-01-21 13:22:19.000000000","message":"The UUID failures are comming from here. it appears that all the failing test are using invalid uuids due to this.\n\n_test_rebuild in nova/tests/unit/compute/test_compute.py\n\nhttps://github.com/openstack/nova/blob/86067192b0f55550fa903484dbb3a57fe19d7eab/nova/tests/unit/compute/test_compute.py#L9007-L9061\n\nincorrectly generate invalid image ref uuids\n\nwith mock.patch.object(self.compute_api.compute_task_api,\n                               \u0027rebuild_instance\u0027, fake_rpc_rebuild):\nimage_ref \u003d instance[\"image_ref\"] + \u0027-new_image_ref\u0027\n\nsince this function is now called on all rebuild all unit tests, that test rebuild and inherit form ComputeTestCase they will fail by raising an invalid UUID excption form ovo.\n\nin stein I34ffaf285718059b55f90e812b57f1e11d566c6f\n\nhttps://github.com/openstack/nova/commit/52d515ba7dbb22433d8fceeafd3bc045aa2781ac#diff-15fd759815954327b4765c2457d2644eR8917\n\nmodifed the fuctional test to use a real uuid instead however we cant backport that change so will have to replicate just the uuid change.","commit_id":"62dc74b61cf87d3ed9d5e93d1c2c5182f2ae7d50"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"be690a47a412972eccf8a596757ca42128156b60","unresolved":false,"context_lines":[{"line_number":6315,"context_line":"                self.compute_api._validate_numa_rebuild, instance,"},{"line_number":6316,"context_line":"                image, flavor)"},{"line_number":6317,"context_line":""},{"line_number":6318,"context_line":"    @mock.patch(\u0027nova.pci.request.get_pci_requests_from_flavor\u0027)"},{"line_number":6319,"context_line":"    def test_pci_validated(self, mock_request):"},{"line_number":6320,"context_line":"        \"\"\"Tests that calling _validate_flavor_image_nostatus() with"},{"line_number":6321,"context_line":"        validate_pci\u003dTrue results in get_pci_requests_from_flavor() being"},{"line_number":6322,"context_line":"        called."},{"line_number":6323,"context_line":"        \"\"\""},{"line_number":6324,"context_line":"        image \u003d dict(id\u003duuids.image_id, status\u003d\u0027foo\u0027)"},{"line_number":6325,"context_line":"        flavor \u003d self._create_flavor()"},{"line_number":6326,"context_line":"        self.compute_api._validate_flavor_image_nostatus(self.context,"},{"line_number":6327,"context_line":"            image, flavor, root_bdm\u003dNone, validate_pci\u003dTrue)"},{"line_number":6328,"context_line":"        mock_request.assert_called_once_with(flavor)"},{"line_number":6329,"context_line":""},{"line_number":6330,"context_line":"    def test_validate_and_build_base_options_translate_neutron_secgroup(self):"},{"line_number":6331,"context_line":"        \"\"\"Tests that _check_requested_secgroups will return a uuid for a"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1f458644","line":6328,"range":{"start_line":6318,"start_character":0,"end_line":6328,"end_character":52},"updated":"2020-01-21 13:22:19.000000000","message":"this should not be backported its part of a different feature and included by mistake. ill remove it in the next version.","commit_id":"62dc74b61cf87d3ed9d5e93d1c2c5182f2ae7d50"}]}